[PATCH v2 0/5] staging: mt7621-gpio: some driver cleanups

[PATCH v2 0/5] staging: mt7621-gpio: some driver cleanups

[Sergio Paracuellos]

The following patch series fix some checkpatch complains
about this driver. There is still some complains about dt-bindings
not being added to its correct Documentation place inside the kernel
but it should be ok when this driver will be move out of staging.
Changes have not been tested and also compiled but it should not have 
any problem about them.

Changes in v2:
    - mtk,mt7621-gpio.txt dt-bindings description moved inside the
      staging folder because is still uncomplete.
    - TODO has been updated with real stuff missing to get this
      driver out of staging.

Sergio Paracuellos (5):
  staging: mt7621-gpio: fix some warnings because of lines exceeded 80
    characters
  staging: mt7621-gpio: add SPDX identifier
  dt-bindings: add compatible string for 'mtk' MediaTek
  staging: mt7621-gpio: dt-bindings: add documentation for mt7621-gpio
  staging: mt7621-gpio: update TODO file

 .../devicetree/bindings/vendor-prefixes.txt        |  1 +
 drivers/staging/mt7621-gpio/TODO                   |  3 +-
 drivers/staging/mt7621-gpio/gpio-mt7621.c          | 24 +++++-----
 drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt    | 51 ++++++++++++++++++++++
 4 files changed, 68 insertions(+), 11 deletions(-)
 create mode 100644 drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt

-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 1/5] staging: mt7621-gpio: fix some warnings because of lines exceeded 80 characters

[Sergio Paracuellos]

This patch silence some complains of checkpatch script because
of the use of long lines.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
---
 drivers/staging/mt7621-gpio/gpio-mt7621.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c
index c9ef936..a6dcfdf 100644
--- a/drivers/staging/mt7621-gpio/gpio-mt7621.c
+++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c
@@ -65,7 +65,9 @@ mtk_gpio_w32(struct mtk_gc *rg, u8 reg, u32 val)
 static inline u32
 mtk_gpio_r32(struct mtk_gc *rg, u8 reg)
 {
-	return ioread32(mediatek_gpio_membase + (reg * 0x10) + (rg->bank * 0x4));
+	u32 offset = (reg * 0x10) + (rg->bank * 0x4);
+
+	return ioread32(mediatek_gpio_membase + offset);
 }
 
 static void
@@ -140,7 +142,8 @@ mediatek_gpio_to_irq(struct gpio_chip *chip, unsigned int pin)
 {
 	struct mtk_gc *rg = to_mediatek_gpio(chip);
 
-	return irq_create_mapping(mediatek_gpio_irq_domain, pin + (rg->bank * MTK_BANK_WIDTH));
+	return irq_create_mapping(mediatek_gpio_irq_domain,
+				  pin + (rg->bank * MTK_BANK_WIDTH));
 }
 
 static int
@@ -197,7 +200,8 @@ mediatek_gpio_irq_handler(struct irq_desc *desc)
 		pending = mtk_gpio_r32(rg, GPIO_REG_STAT);
 
 		for_each_set_bit(bit, &pending, MTK_BANK_WIDTH) {
-			u32 map = irq_find_mapping(mediatek_gpio_irq_domain, (MTK_BANK_WIDTH * i) + bit);
+			u32 map = irq_find_mapping(mediatek_gpio_irq_domain,
+						   (MTK_BANK_WIDTH * i) + bit);
 
 			generic_handle_irq(map);
 			mtk_gpio_w32(rg, GPIO_REG_STAT, BIT(bit));
@@ -287,9 +291,11 @@ static struct irq_chip mediatek_gpio_irq_chip = {
 };
 
 static int
-mediatek_gpio_gpio_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
+mediatek_gpio_gpio_map(struct irq_domain *d, unsigned int irq,
+		       irq_hw_number_t hw)
 {
-	irq_set_chip_and_handler(irq, &mediatek_gpio_irq_chip, handle_level_irq);
+	irq_set_chip_and_handler(irq, &mediatek_gpio_irq_chip,
+				 handle_level_irq);
 	irq_set_handler_data(irq, d);
 
 	return 0;
@@ -324,7 +330,8 @@ mediatek_gpio_probe(struct platform_device *pdev)
 			mediatek_gpio_bank_probe(pdev, bank);
 
 	if (mediatek_gpio_irq_domain)
-		irq_set_chained_handler(mediatek_gpio_irq, mediatek_gpio_irq_handler);
+		irq_set_chained_handler(mediatek_gpio_irq,
+					mediatek_gpio_irq_handler);
 
 	return 0;
 }
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 2/5] staging: mt7621-gpio: add SPDX identifier

[Sergio Paracuellos]

It's good to have SPDX identifiers in driver files to make it easier to
audit the kernel tree for correct licenses.

Fix up the one of staging gpio-mt7621 file to have a proper SPDX
identifier, based on the license text in the file itself. The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
---
 drivers/staging/mt7621-gpio/gpio-mt7621.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c
index a6dcfdf..a577381 100644
--- a/drivers/staging/mt7621-gpio/gpio-mt7621.c
+++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c
@@ -1,8 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License version 2 as published
- * by the Free Software Foundation.
- *
  * Copyright (C) 2009-2011 Gabor Juhos <juhosg@openwrt.org>
  * Copyright (C) 2013 John Crispin <blogic@openwrt.org>
  */
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 3/5] dt-bindings: add compatible string for 'mtk' MediaTek

[Sergio Paracuellos]

There is a complain of checkpatch script about the not documented
DT compatible string for vendor "mtk". Add it to vendor-prefixes.txt
file.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index b5f978a..a588a29 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -228,6 +228,7 @@ mqmaker	mqmaker Inc.
 mscc	Microsemi Corporation
 msi	Micro-Star International Co. Ltd.
 mti	Imagination Technologies Ltd. (formerly MIPS Technologies Inc.)
+mtk	MediaTek
 multi-inno	Multi-Inno Technology Co.,Ltd
 mundoreader	Mundo Reader S.L.
 murata	Murata Manufacturing Co., Ltd.
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 4/5] staging: mt7621-gpio: dt-bindings: add documentation for mt7621-gpio

[Sergio Paracuellos]

This commit add missing dt bindings documentation for mt7621-gpio
driver. There is some missing stuff here about interrupts with is
not also being used in the mt7621.dtsi file. So just include in
staging a incomplete version before moving this to kernel's dt-bindings
place.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt | 51 +++++++++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt

diff --git a/drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt b/drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt
new file mode 100644
index 0000000..5fe4bb5
--- /dev/null
+++ b/drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt
@@ -0,0 +1,51 @@
+Mediatek SoC GPIO controller bindings
+
+The IP core used inside these SoCs has 3 banks of 32 GPIOs each.
+The registers of all the banks are interwoven inside one single IO range.
+We load one GPIO controller instance per bank. To make this possible
+we support 2 types of nodes. The parent node defines the memory I/O range and
+has 3 children each describing a single bank.
+
+Required properties for the top level node:
+- compatible:
+  - "mtk,mt7621-gpio" for Mediatek controllers
+- reg : Physical base address and length of the controller's registers
+
+Required properties for the GPIO bank node:
+- compatible:
+  - "mtk,mt7621-gpio-bank" for Mediatek banks
+- #gpio-cells : Should be two.
+  - first cell is the pin number
+  - second cell is used to specify optional parameters (unused)
+- gpio-controller : Marks the device node as a GPIO controller
+- reg : The id of the bank that the node describes.
+
+Example:
+	gpio@600 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		compatible = "mtk,mt7621-gpio";
+		reg = <0x600 0x100>;
+
+		gpio0: bank@0 {
+			reg = <0>;
+			compatible = "mtk,mt7621-gpio-bank";
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
+
+		gpio1: bank@1 {
+			reg = <1>;
+			compatible = "mtk,mt7621-gpio-bank";
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
+
+		gpio2: bank@2 {
+			reg = <2>;
+			compatible = "mtk,mt7621-gpio-bank";
+			gpio-controller;
+			#gpio-cells = <2>;
+		};
+	};
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 5/5] staging: mt7621-gpio: update TODO file

[Sergio Paracuellos]

This commit updates TODO file with missing things to
get this driver ready to be mainlined.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: NeilBrown <neil@brown.name>
---
 drivers/staging/mt7621-gpio/TODO | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO
index 7143905..54e6271 100644
--- a/drivers/staging/mt7621-gpio/TODO
+++ b/drivers/staging/mt7621-gpio/TODO
@@ -1,5 +1,6 @@
 
-- general code review and clean up
+- general code review and clean up: avoid global variables and use drvdata allocated instead
 - ensure device-tree requirements are documented
+- make sure interrupts work
 
 Cc:  NeilBrown <neil@brown.name>
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/5] staging: mt7621-gpio: some driver cleanups

[NeilBrown]

[-- Attachment #1: Type: text/plain, Size: 1552 bytes --]

On Tue, May 15 2018, Sergio Paracuellos wrote:

> The following patch series fix some checkpatch complains
> about this driver. There is still some complains about dt-bindings
> not being added to its correct Documentation place inside the kernel
> but it should be ok when this driver will be move out of staging.
> Changes have not been tested and also compiled but it should not have 
> any problem about them.
>
> Changes in v2:
>     - mtk,mt7621-gpio.txt dt-bindings description moved inside the
>       staging folder because is still uncomplete.
>     - TODO has been updated with real stuff missing to get this
>       driver out of staging.
>
> Sergio Paracuellos (5):
>   staging: mt7621-gpio: fix some warnings because of lines exceeded 80
>     characters
>   staging: mt7621-gpio: add SPDX identifier
>   dt-bindings: add compatible string for 'mtk' MediaTek
>   staging: mt7621-gpio: dt-bindings: add documentation for mt7621-gpio
>   staging: mt7621-gpio: update TODO file

Thanks,
 all looks good.

 Reviewed-by: NeilBrown <neil@brown.name>

for the whole series.

NeilBrown

>
>  .../devicetree/bindings/vendor-prefixes.txt        |  1 +
>  drivers/staging/mt7621-gpio/TODO                   |  3 +-
>  drivers/staging/mt7621-gpio/gpio-mt7621.c          | 24 +++++-----
>  drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt    | 51 ++++++++++++++++++++++
>  4 files changed, 68 insertions(+), 11 deletions(-)
>  create mode 100644 drivers/staging/mt7621-gpio/mtk,mt7621-gpio.txt
>
> -- 
> 2.7.4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH v2 3/5] dt-bindings: add compatible string for 'mtk' MediaTek

[Greg KH]

On Tue, May 15, 2018 at 06:49:55AM +0200, Sergio Paracuellos wrote:
> There is a complain of checkpatch script about the not documented
> DT compatible string for vendor "mtk". Add it to vendor-prefixes.txt
> file.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index b5f978a..a588a29 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -228,6 +228,7 @@ mqmaker	mqmaker Inc.
>  mscc	Microsemi Corporation
>  msi	Micro-Star International Co. Ltd.
>  mti	Imagination Technologies Ltd. (formerly MIPS Technologies Inc.)
> +mtk	MediaTek

Same issue as the v1 patch :(
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 0/5] staging: mt7621-gpio: some driver cleanups

[Greg KH]

On Tue, May 15, 2018 at 04:18:56PM +1000, NeilBrown wrote:
> On Tue, May 15 2018, Sergio Paracuellos wrote:
> 
> > The following patch series fix some checkpatch complains
> > about this driver. There is still some complains about dt-bindings
> > not being added to its correct Documentation place inside the kernel
> > but it should be ok when this driver will be move out of staging.
> > Changes have not been tested and also compiled but it should not have 
> > any problem about them.
> >
> > Changes in v2:
> >     - mtk,mt7621-gpio.txt dt-bindings description moved inside the
> >       staging folder because is still uncomplete.
> >     - TODO has been updated with real stuff missing to get this
> >       driver out of staging.
> >
> > Sergio Paracuellos (5):
> >   staging: mt7621-gpio: fix some warnings because of lines exceeded 80
> >     characters
> >   staging: mt7621-gpio: add SPDX identifier
> >   dt-bindings: add compatible string for 'mtk' MediaTek
> >   staging: mt7621-gpio: dt-bindings: add documentation for mt7621-gpio
> >   staging: mt7621-gpio: update TODO file
> 
> Thanks,
>  all looks good.
> 
>  Reviewed-by: NeilBrown <neil@brown.name>
> 
> for the whole series.

I can't take the dt patches for the previously reviewed reasons, but
I'll queue up the other 3 now, thanks.

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 5/5] staging: mt7621-gpio: update TODO file

[Greg KH]

On Tue, May 15, 2018 at 06:49:57AM +0200, Sergio Paracuellos wrote:
> This commit updates TODO file with missing things to
> get this driver ready to be mainlined.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> Reviewed-by: NeilBrown <neil@brown.name>
> ---
>  drivers/staging/mt7621-gpio/TODO | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO
> index 7143905..54e6271 100644
> --- a/drivers/staging/mt7621-gpio/TODO
> +++ b/drivers/staging/mt7621-gpio/TODO
> @@ -1,5 +1,6 @@
>  
> -- general code review and clean up
> +- general code review and clean up: avoid global variables and use drvdata allocated instead

This now goes beyond 80 columns so someone else will send a patch fixing
that up :)

How about making this two lines instead please.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v2 5/5] staging: mt7621-gpio: update TODO file

[Sergio Paracuellos]

On Tue, May 15, 2018 at 09:29:04AM +0200, Greg KH wrote:
> On Tue, May 15, 2018 at 06:49:57AM +0200, Sergio Paracuellos wrote:
> > This commit updates TODO file with missing things to
> > get this driver ready to be mainlined.
> > 
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > Reviewed-by: NeilBrown <neil@brown.name>
> > ---
> >  drivers/staging/mt7621-gpio/TODO | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO
> > index 7143905..54e6271 100644
> > --- a/drivers/staging/mt7621-gpio/TODO
> > +++ b/drivers/staging/mt7621-gpio/TODO
> > @@ -1,5 +1,6 @@
> >  
> > -- general code review and clean up
> > +- general code review and clean up: avoid global variables and use drvdata allocated instead
> 
> This now goes beyond 80 columns so someone else will send a patch fixing
> that up :)
> 
> How about making this two lines instead please.

Ack! I'll include this in my next series. 

> 
> thanks,
> 
> greg k-h

Best regards,
    Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel