* [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...
@ 2018-05-16 15:06 Igor Mammedov
2018-05-16 15:15 ` Eric Blake
2018-05-16 17:41 ` Eduardo Habkost
0 siblings, 2 replies; 3+ messages in thread
From: Igor Mammedov @ 2018-05-16 15:06 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost, armbru, eblake
When using following CLI:
-numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
"Invalid node 128, max possible could be 128"
Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
v4:
- e error message suggested by Markus
v3:
- s/,/./ in error message
- add '.' at the end of sentence
---
numa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/numa.c b/numa.c
index 188bfdf..33572bf 100644
--- a/numa.c
+++ b/numa.c
@@ -141,9 +141,8 @@ static void parse_numa_distance(NumaDistOptions *dist, Error **errp)
uint8_t val = dist->val;
if (src >= MAX_NODES || dst >= MAX_NODES) {
- error_setg(errp,
- "Invalid node %d, max possible could be %d",
- MAX(src, dst), MAX_NODES);
+ error_setg(errp, "Parameter '%s' expects an integer between 0 and %d",
+ src >= MAX_NODES ? "src" : "dst", MAX_NODES - 1);
return;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...
2018-05-16 15:06 [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, Igor Mammedov
@ 2018-05-16 15:15 ` Eric Blake
2018-05-16 17:41 ` Eduardo Habkost
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2018-05-16 15:15 UTC (permalink / raw)
To: Igor Mammedov, qemu-devel; +Cc: ehabkost, armbru
On 05/16/2018 10:06 AM, Igor Mammedov wrote:
> When using following CLI:
> -numa dist,src=128,dst=1,val=20
> user gets a rather confusing error message:
> "Invalid node 128, max possible could be 128"
>
> Where 128 is number of nodes that QEMU supports (MAX_NODES),
> while src/dst is an index up to that limit, so it should be
> MAX_NODES - 1 in error message.
> Make error message to explicitly state valid range for node
> index to be more clear.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, ...
2018-05-16 15:06 [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, Igor Mammedov
2018-05-16 15:15 ` Eric Blake
@ 2018-05-16 17:41 ` Eduardo Habkost
1 sibling, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2018-05-16 17:41 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, armbru, eblake
On Wed, May 16, 2018 at 05:06:14PM +0200, Igor Mammedov wrote:
> When using following CLI:
> -numa dist,src=128,dst=1,val=20
> user gets a rather confusing error message:
> "Invalid node 128, max possible could be 128"
>
> Where 128 is number of nodes that QEMU supports (MAX_NODES),
> while src/dst is an index up to that limit, so it should be
> MAX_NODES - 1 in error message.
> Make error message to explicitly state valid range for node
> index to be more clear.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Queued, thanks.
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-16 17:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 15:06 [Qemu-devel] [PATCH v4] numa: clarify error message when node index is out of range in -numa dist, Igor Mammedov
2018-05-16 15:15 ` Eric Blake
2018-05-16 17:41 ` Eduardo Habkost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.