* [PATCH] ethdev: update description for functions @ 2018-05-17 10:59 Vipin Varghese 2018-05-17 12:32 ` Ferruh Yigit 2018-05-18 5:12 ` [PATCH v2] " Vipin Varghese 0 siblings, 2 replies; 6+ messages in thread From: Vipin Varghese @ 2018-05-17 10:59 UTC (permalink / raw) To: dev, john.mcnamara, lee.daly, deepak.k.jain; +Cc: Vipin Varghese Change adds extra information on name parameter for API rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name. Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> --- lib/librte_ethdev/rte_ethdev.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index f8815e9..7387686 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -3657,7 +3657,10 @@ rte_eth_dev_l2_tunnel_offload_set(uint16_t port_id, /** * Get the port id from pci address or device name -* Ex: 0000:2:00.0 or vdev name net_pcap0 +* Ex: +* - PCIe, 0000:2:00.0 +* - SoC, fslgmac0 +* - vdev driver name, net_pcap0 * * @param name * pci address or name of the device @@ -3672,6 +3675,10 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id); /** * Get the device name from port id +* Ex: +* - PCIe Bus:Domian:Function, 0000:02:00.0 +* - SoC device name, fslgmac0 +* - VDEV driver name, net_pcap0, net_null0, net_tun0 or net_tap0 * * @param port_id * Port identifier of the device. -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ethdev: update description for functions 2018-05-17 10:59 [PATCH] ethdev: update description for functions Vipin Varghese @ 2018-05-17 12:32 ` Ferruh Yigit 2018-05-18 5:03 ` Varghese, Vipin 2018-05-18 5:12 ` [PATCH v2] " Vipin Varghese 1 sibling, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2018-05-17 12:32 UTC (permalink / raw) To: Vipin Varghese, dev, john.mcnamara, lee.daly, deepak.k.jain On 5/17/2018 11:59 AM, Vipin Varghese wrote: > Change adds extra information on name parameter for API > rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name. > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > --- > lib/librte_ethdev/rte_ethdev.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index f8815e9..7387686 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -3657,7 +3657,10 @@ rte_eth_dev_l2_tunnel_offload_set(uint16_t port_id, > > /** > * Get the port id from pci address or device name > -* Ex: 0000:2:00.0 or vdev name net_pcap0 > +* Ex: > +* - PCIe, 0000:2:00.0 > +* - SoC, fslgmac0 > +* - vdev driver name, net_pcap0 driver name is "net_pcap", device name is "net_pcap0". Original "vdev name" seems more accurate, is there a reason to change it to "driver name"? > * > * @param name > * pci address or name of the device > @@ -3672,6 +3675,10 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id); > > /** > * Get the device name from port id > +* Ex: What do you think say "Ex device name:" here and remove "device name" from below: PCIe, 0000:02:00.0 SoC, fslgmac0 vdev, net_pcap0, net_null0, net_tun0 or net_tap0, ... > +* - PCIe Bus:Domian:Function, 0000:02:00.0 > +* - SoC device name, fslgmac0 > +* - VDEV driver name, net_pcap0, net_null0, net_tun0 or net_tap0 Why VDEV capitalized? > * > * @param port_id > * Port identifier of the device. > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ethdev: update description for functions 2018-05-17 12:32 ` Ferruh Yigit @ 2018-05-18 5:03 ` Varghese, Vipin 0 siblings, 0 replies; 6+ messages in thread From: Varghese, Vipin @ 2018-05-18 5:03 UTC (permalink / raw) To: Yigit, Ferruh, dev, Mcnamara, John, Daly, Lee, Jain, Deepak K Thanks you for the corrections, I had sent the diff from the wrong folder. Will be sending out V2 for the corrected one. > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, May 17, 2018 6:03 PM > To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Mcnamara, > John <john.mcnamara@intel.com>; Daly, Lee <lee.daly@intel.com>; Jain, > Deepak K <deepak.k.jain@intel.com> > Subject: Re: [dpdk-dev] [PATCH] ethdev: update description for functions > > On 5/17/2018 11:59 AM, Vipin Varghese wrote: > > Change adds extra information on name parameter for API > > rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name. > > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > > --- > > lib/librte_ethdev/rte_ethdev.h | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_ethdev/rte_ethdev.h > > b/lib/librte_ethdev/rte_ethdev.h index f8815e9..7387686 100644 > > --- a/lib/librte_ethdev/rte_ethdev.h > > +++ b/lib/librte_ethdev/rte_ethdev.h > > @@ -3657,7 +3657,10 @@ rte_eth_dev_l2_tunnel_offload_set(uint16_t > > port_id, > > > > /** > > * Get the port id from pci address or device name > > -* Ex: 0000:2:00.0 or vdev name net_pcap0 > > +* Ex: > > +* - PCIe, 0000:2:00.0 > > +* - SoC, fslgmac0 > > +* - vdev driver name, net_pcap0 > > driver name is "net_pcap", device name is "net_pcap0". > Original "vdev name" seems more accurate, is there a reason to change it to > "driver name"? > > > * > > * @param name > > * pci address or name of the device > > @@ -3672,6 +3675,10 @@ rte_eth_dev_get_port_by_name(const char > *name, > > uint16_t *port_id); > > > > /** > > * Get the device name from port id > > +* Ex: > > What do you think say "Ex device name:" here and remove "device name" from > below: > PCIe, 0000:02:00.0 > SoC, fslgmac0 > vdev, net_pcap0, net_null0, net_tun0 or net_tap0, ... > > > +* - PCIe Bus:Domian:Function, 0000:02:00.0 > > +* - SoC device name, fslgmac0 > > +* - VDEV driver name, net_pcap0, net_null0, net_tun0 or net_tap0 > > Why VDEV capitalized? > > > * > > * @param port_id > > * Port identifier of the device. > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ethdev: update description for functions 2018-05-17 10:59 [PATCH] ethdev: update description for functions Vipin Varghese 2018-05-17 12:32 ` Ferruh Yigit @ 2018-05-18 5:12 ` Vipin Varghese 2018-05-21 15:15 ` Ferruh Yigit 1 sibling, 1 reply; 6+ messages in thread From: Vipin Varghese @ 2018-05-18 5:12 UTC (permalink / raw) To: dev, john.mcnamara, ferruh.yigit, deepak.k.jain; +Cc: Vipin Varghese Change adds extra information on name parameter for API rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name. Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> --- lib/librte_ethdev/rte_ethdev.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h index f8815e9..66463a9 100644 --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -3657,7 +3657,10 @@ rte_eth_dev_l2_tunnel_offload_set(uint16_t port_id, /** * Get the port id from pci address or device name -* Ex: 0000:2:00.0 or vdev name net_pcap0 +* Ex: +* - PCIe, 0000:2:00.0 +* - SoC, fsl-gmac0 +* - vdev, net_pcap0 * * @param name * pci address or name of the device @@ -3672,6 +3675,10 @@ rte_eth_dev_get_port_by_name(const char *name, uint16_t *port_id); /** * Get the device name from port id +* Ex: +* - PCIe Bus:Domian:Function, 0000:02:00.0 +* - SoC device name, fsl-gmac0 +* - vdev dpdk name, net_[pcap0|null0|tun0|tap0] * * @param port_id * Port identifier of the device. -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ethdev: update description for functions 2018-05-18 5:12 ` [PATCH v2] " Vipin Varghese @ 2018-05-21 15:15 ` Ferruh Yigit 2018-05-21 15:16 ` Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2018-05-21 15:15 UTC (permalink / raw) To: Vipin Varghese, dev, john.mcnamara, deepak.k.jain On 5/18/2018 6:12 AM, Vipin Varghese wrote: > Change adds extra information on name parameter for API > rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name. > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ethdev: update description for functions 2018-05-21 15:15 ` Ferruh Yigit @ 2018-05-21 15:16 ` Ferruh Yigit 0 siblings, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2018-05-21 15:16 UTC (permalink / raw) To: Vipin Varghese, dev, john.mcnamara, deepak.k.jain On 5/21/2018 4:15 PM, Ferruh Yigit wrote: > On 5/18/2018 6:12 AM, Vipin Varghese wrote: >> Change adds extra information on name parameter for API >> rte_eth_dev_get_name_by_port and rte_eth_dev_get_port_by_name. >> >> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com> > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-21 15:16 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-05-17 10:59 [PATCH] ethdev: update description for functions Vipin Varghese 2018-05-17 12:32 ` Ferruh Yigit 2018-05-18 5:03 ` Varghese, Vipin 2018-05-18 5:12 ` [PATCH v2] " Vipin Varghese 2018-05-21 15:15 ` Ferruh Yigit 2018-05-21 15:16 ` Ferruh Yigit
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.