All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] vmcore: move get_vmcore_size out of __init
@ 2018-05-21 13:37 ` Rahul Lakkireddy
  0 siblings, 0 replies; 5+ messages in thread
From: Rahul Lakkireddy @ 2018-05-21 13:37 UTC (permalink / raw)
  To: netdev, kexec, linux-fsdevel, linux-kernel
  Cc: davem, viro, ebiederm, stephen, akpm, torvalds, ganeshgr,
	nirranjan, indranil, Rahul Lakkireddy

Fix below build warning:

WARNING: vmlinux.o(.text+0x422bb8): Section mismatch in reference from
the function vmcore_add_device_dump() to the function
.init.text:get_vmcore_size.constprop.5()

The function vmcore_add_device_dump() references
the function __init get_vmcore_size.constprop.5().
This is often because vmcore_add_device_dump lacks a __init
annotation or the annotation of get_vmcore_size.constprop.5 is wrong.

Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
---
 fs/proc/vmcore.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 247c3499e5bd..cfb6674331fd 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -649,8 +649,8 @@ static struct vmcore* __init get_new_element(void)
 	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
 }
 
-static u64 __init get_vmcore_size(size_t elfsz, size_t elfnotesegsz,
-				  struct list_head *vc_list)
+static u64 get_vmcore_size(size_t elfsz, size_t elfnotesegsz,
+			   struct list_head *vc_list)
 {
 	u64 size;
 	struct vmcore *m;
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH net-next] vmcore: move get_vmcore_size out of __init
@ 2018-05-21 13:37 ` Rahul Lakkireddy
  0 siblings, 0 replies; 5+ messages in thread
From: Rahul Lakkireddy @ 2018-05-21 13:37 UTC (permalink / raw)
  To: netdev-u79uwXL29TY76Z2rM5mHXA,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: indranil-ut6Up61K2wZBDgjK7y7TUQ,
	nirranjan-ut6Up61K2wZBDgjK7y7TUQ,
	stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ,
	ganeshgr-ut6Up61K2wZBDgjK7y7TUQ, Rahul Lakkireddy,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q,
	viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn

Fix below build warning:

WARNING: vmlinux.o(.text+0x422bb8): Section mismatch in reference from
the function vmcore_add_device_dump() to the function
.init.text:get_vmcore_size.constprop.5()

The function vmcore_add_device_dump() references
the function __init get_vmcore_size.constprop.5().
This is often because vmcore_add_device_dump lacks a __init
annotation or the annotation of get_vmcore_size.constprop.5 is wrong.

Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Ganesh Goudar <ganeshgr-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
---
 fs/proc/vmcore.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 247c3499e5bd..cfb6674331fd 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -649,8 +649,8 @@ static struct vmcore* __init get_new_element(void)
 	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
 }
 
-static u64 __init get_vmcore_size(size_t elfsz, size_t elfnotesegsz,
-				  struct list_head *vc_list)
+static u64 get_vmcore_size(size_t elfsz, size_t elfnotesegsz,
+			   struct list_head *vc_list)
 {
 	u64 size;
 	struct vmcore *m;
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH net-next] vmcore: move get_vmcore_size out of __init
@ 2018-05-21 13:37 ` Rahul Lakkireddy
  0 siblings, 0 replies; 5+ messages in thread
From: Rahul Lakkireddy @ 2018-05-21 13:37 UTC (permalink / raw)
  To: netdev, kexec, linux-fsdevel, linux-kernel
  Cc: indranil, nirranjan, stephen, ganeshgr, Rahul Lakkireddy,
	ebiederm, akpm, torvalds, davem, viro

Fix below build warning:

WARNING: vmlinux.o(.text+0x422bb8): Section mismatch in reference from
the function vmcore_add_device_dump() to the function
.init.text:get_vmcore_size.constprop.5()

The function vmcore_add_device_dump() references
the function __init get_vmcore_size.constprop.5().
This is often because vmcore_add_device_dump lacks a __init
annotation or the annotation of get_vmcore_size.constprop.5 is wrong.

Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>
---
 fs/proc/vmcore.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 247c3499e5bd..cfb6674331fd 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -649,8 +649,8 @@ static struct vmcore* __init get_new_element(void)
 	return kzalloc(sizeof(struct vmcore), GFP_KERNEL);
 }
 
-static u64 __init get_vmcore_size(size_t elfsz, size_t elfnotesegsz,
-				  struct list_head *vc_list)
+static u64 get_vmcore_size(size_t elfsz, size_t elfnotesegsz,
+			   struct list_head *vc_list)
 {
 	u64 size;
 	struct vmcore *m;
-- 
2.14.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH net-next] vmcore: move get_vmcore_size out of __init
  2018-05-21 13:37 ` Rahul Lakkireddy
@ 2018-05-21 16:34   ` David Miller
  -1 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-05-21 16:34 UTC (permalink / raw)
  To: rahul.lakkireddy
  Cc: netdev, kexec, linux-fsdevel, linux-kernel, viro, ebiederm,
	stephen, akpm, torvalds, ganeshgr, nirranjan, indranil

From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Mon, 21 May 2018 19:07:50 +0530

> Fix below build warning:
> 
> WARNING: vmlinux.o(.text+0x422bb8): Section mismatch in reference from
> the function vmcore_add_device_dump() to the function
> .init.text:get_vmcore_size.constprop.5()
> 
> The function vmcore_add_device_dump() references
> the function __init get_vmcore_size.constprop.5().
> This is often because vmcore_add_device_dump lacks a __init
> annotation or the annotation of get_vmcore_size.constprop.5 is wrong.
> 
> Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH net-next] vmcore: move get_vmcore_size out of __init
@ 2018-05-21 16:34   ` David Miller
  0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2018-05-21 16:34 UTC (permalink / raw)
  To: rahul.lakkireddy
  Cc: indranil, netdev, nirranjan, kexec, linux-kernel, stephen,
	ganeshgr, ebiederm, linux-fsdevel, akpm, torvalds, viro

From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Mon, 21 May 2018 19:07:50 +0530

> Fix below build warning:
> 
> WARNING: vmlinux.o(.text+0x422bb8): Section mismatch in reference from
> the function vmcore_add_device_dump() to the function
> .init.text:get_vmcore_size.constprop.5()
> 
> The function vmcore_add_device_dump() references
> the function __init get_vmcore_size.constprop.5().
> This is often because vmcore_add_device_dump lacks a __init
> annotation or the annotation of get_vmcore_size.constprop.5 is wrong.
> 
> Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@chelsio.com>

Applied, thank you.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-21 16:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-21 13:37 [PATCH net-next] vmcore: move get_vmcore_size out of __init Rahul Lakkireddy
2018-05-21 13:37 ` Rahul Lakkireddy
2018-05-21 13:37 ` Rahul Lakkireddy
2018-05-21 16:34 ` David Miller
2018-05-21 16:34   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.