* [RESEND PATCH 3/4] dt-bindings: PCI: cadence: Add DT bindings for optional PHYs
@ 2018-05-22 13:32 ` Alan Douglas
0 siblings, 0 replies; 5+ messages in thread
From: Alan Douglas @ 2018-05-22 13:32 UTC (permalink / raw)
To: bhelgaas, kishon, lorenzo.pieralisi, linux-pci, devicetree
Cc: linux-kernel, cyrille.pitchen, Alan Douglas
Update DT documentation to include optional PHYs for cadence PCIe
host and endpoint controllers.
Signed-off-by: Alan Douglas <adouglas@cadence.com>
---
Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++
Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
index 9a305237..e40c635 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
@@ -9,6 +9,8 @@ Required properties:
Optional properties:
- max-functions: Maximum number of functions that can be configured (default 1).
+- phys: From PHY bindings: List of Generic PHY phandles.
+- phy-names: List of names to identify the PHY.
Example:
@@ -19,4 +21,6 @@ pcie@fc000000 {
reg-names = "reg", "mem";
cdns,max-outbound-regions = <16>;
max-functions = /bits/ 8 <8>;
+ phys = <&ep_phy0 &ep_phy1>;
+ phy-names = "pcie-lane0","pcie-lane1";
};
diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
index 20a33f3..c0ca4c1 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
@@ -24,6 +24,8 @@ Optional properties:
translations (default 32)
- vendor-id: The PCI vendor ID (16 bits, default is design dependent)
- device-id: The PCI device ID (16 bits, default is design dependent)
+- phys: From PHY bindings: List of Generic PHY phandles.
+- phy-names: List of names to identify the PHY.
Example:
--
2.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH 3/4] dt-bindings: PCI: cadence: Add DT bindings for optional PHYs
@ 2018-05-22 13:32 ` Alan Douglas
0 siblings, 0 replies; 5+ messages in thread
From: Alan Douglas @ 2018-05-22 13:32 UTC (permalink / raw)
To: bhelgaas, kishon, lorenzo.pieralisi, linux-pci, devicetree
Cc: linux-kernel, cyrille.pitchen, Alan Douglas
Update DT documentation to include optional PHYs for cadence PCIe
host and endpoint controllers.
Signed-off-by: Alan Douglas <adouglas@cadence.com>
---
Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++
Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
index 9a305237..e40c635 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
@@ -9,6 +9,8 @@ Required properties:
Optional properties:
- max-functions: Maximum number of functions that can be configured (default 1).
+- phys: From PHY bindings: List of Generic PHY phandles.
+- phy-names: List of names to identify the PHY.
Example:
@@ -19,4 +21,6 @@ pcie@fc000000 {
reg-names = "reg", "mem";
cdns,max-outbound-regions = <16>;
max-functions = /bits/ 8 <8>;
+ phys = <&ep_phy0 &ep_phy1>;
+ phy-names = "pcie-lane0","pcie-lane1";
};
diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
index 20a33f3..c0ca4c1 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
@@ -24,6 +24,8 @@ Optional properties:
translations (default 32)
- vendor-id: The PCI vendor ID (16 bits, default is design dependent)
- device-id: The PCI device ID (16 bits, default is design dependent)
+- phys: From PHY bindings: List of Generic PHY phandles.
+- phy-names: List of names to identify the PHY.
Example:
--
2.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH 3/4] dt-bindings: PCI: cadence: Add DT bindings for optional PHYs
2018-05-22 13:32 ` Alan Douglas
(?)
@ 2018-05-23 18:52 ` Rob Herring
2018-05-24 8:22 ` Alan Douglas
-1 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-05-23 18:52 UTC (permalink / raw)
To: Alan Douglas
Cc: bhelgaas, kishon, lorenzo.pieralisi, linux-pci, devicetree,
linux-kernel, cyrille.pitchen
On Tue, May 22, 2018 at 02:32:32PM +0100, Alan Douglas wrote:
> Update DT documentation to include optional PHYs for cadence PCIe
> host and endpoint controllers.
>
> Signed-off-by: Alan Douglas <adouglas@cadence.com>
> ---
> Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++
> Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> index 9a305237..e40c635 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> @@ -9,6 +9,8 @@ Required properties:
>
> Optional properties:
> - max-functions: Maximum number of functions that can be configured (default 1).
> +- phys: From PHY bindings: List of Generic PHY phandles.
> +- phy-names: List of names to identify the PHY.
You need to define how many. I'd assume one, but I guess your example is
1 per lane.
>
> Example:
>
> @@ -19,4 +21,6 @@ pcie@fc000000 {
> reg-names = "reg", "mem";
> cdns,max-outbound-regions = <16>;
> max-functions = /bits/ 8 <8>;
> + phys = <&ep_phy0 &ep_phy1>;
> + phy-names = "pcie-lane0","pcie-lane1";
> };
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
> index 20a33f3..c0ca4c1 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt
> @@ -24,6 +24,8 @@ Optional properties:
> translations (default 32)
> - vendor-id: The PCI vendor ID (16 bits, default is design dependent)
> - device-id: The PCI device ID (16 bits, default is design dependent)
> +- phys: From PHY bindings: List of Generic PHY phandles.
> +- phy-names: List of names to identify the PHY.
>
> Example:
>
> --
> 2.2.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [RESEND PATCH 3/4] dt-bindings: PCI: cadence: Add DT bindings for optional PHYs
2018-05-23 18:52 ` Rob Herring
@ 2018-05-24 8:22 ` Alan Douglas
0 siblings, 0 replies; 5+ messages in thread
From: Alan Douglas @ 2018-05-24 8:22 UTC (permalink / raw)
To: Rob Herring
Cc: bhelgaas, kishon, lorenzo.pieralisi, linux-pci, devicetree,
linux-kernel, cyrille.pitchen
On 23 May 2018 19:52, Rob Herring wrote:
> On Tue, May 22, 2018 at 02:32:32PM +0100, Alan Douglas wrote:
> > Update DT documentation to include optional PHYs for cadence PCIe
> > host and endpoint controllers.
> >
> > Signed-off-by: Alan Douglas <adouglas@cadence.com>
> > ---
> > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++
> > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-
> ep.txt
> > index 9a305237..e40c635 100644
> > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> > @@ -9,6 +9,8 @@ Required properties:
> >
> > Optional properties:
> > - max-functions: Maximum number of functions that can be configured (default 1).
> > +- phys: From PHY bindings: List of Generic PHY phandles.
> > +- phy-names: List of names to identify the PHY.
>
> You need to define how many. I'd assume one, but I guess your example is
> 1 per lane.
>
I can update the description in v3 as follows:
- phys: From PHY bindings: List of Generic PHY phandles. One per lane if more than one in the
list. If only one PHY listed it must manage all lanes.
- phy-names: List of names to identify the PHY, one for each in the list.
> >
> > Example:
> >
> > @@ -19,4 +21,6 @@ pcie@fc000000 {
> > reg-names = "reg", "mem";
> > cdns,max-outbound-regions = <16>;
> > max-functions = /bits/ 8 <8>;
> > + phys = <&ep_phy0 &ep_phy1>;
> > + phy-names = "pcie-lane0","pcie-lane1";
> > };
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [RESEND PATCH 3/4] dt-bindings: PCI: cadence: Add DT bindings for optional PHYs
@ 2018-05-24 8:22 ` Alan Douglas
0 siblings, 0 replies; 5+ messages in thread
From: Alan Douglas @ 2018-05-24 8:22 UTC (permalink / raw)
To: Rob Herring
Cc: bhelgaas, kishon, lorenzo.pieralisi, linux-pci, devicetree,
linux-kernel, cyrille.pitchen
On 23 May 2018 19:52, Rob Herring wrote:
> On Tue, May 22, 2018 at 02:32:32PM +0100, Alan Douglas wrote:
> > Update DT documentation to include optional PHYs for cadence PCIe
> > host and endpoint controllers.
> >
> > Signed-off-by: Alan Douglas <adouglas@cadence.com>
> > ---
> > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt | 4 ++++
> > Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.txt | 2 ++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.tx=
t b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-
> ep.txt
> > index 9a305237..e40c635 100644
> > --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> > +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.txt
> > @@ -9,6 +9,8 @@ Required properties:
> >
> > Optional properties:
> > - max-functions: Maximum number of functions that can be configured (d=
efault 1).
> > +- phys: From PHY bindings: List of Generic PHY phandles.
> > +- phy-names: List of names to identify the PHY.
>=20
> You need to define how many. I'd assume one, but I guess your example is
> 1 per lane.
>=20
I can update the description in v3 as follows:
- phys: From PHY bindings: List of Generic PHY phandles. One per lane if m=
ore than one in the
list. If only one PHY listed it must manage all lanes.=20
- phy-names: List of names to identify the PHY, one for each in the list.
> >
> > Example:
> >
> > @@ -19,4 +21,6 @@ pcie@fc000000 {
> > reg-names =3D "reg", "mem";
> > cdns,max-outbound-regions =3D <16>;
> > max-functions =3D /bits/ 8 <8>;
> > + phys =3D <&ep_phy0 &ep_phy1>;
> > + phy-names =3D "pcie-lane0","pcie-lane1";
> > };
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-24 8:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-22 13:32 [RESEND PATCH 3/4] dt-bindings: PCI: cadence: Add DT bindings for optional PHYs Alan Douglas
2018-05-22 13:32 ` Alan Douglas
2018-05-23 18:52 ` Rob Herring
2018-05-24 8:22 ` Alan Douglas
2018-05-24 8:22 ` Alan Douglas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.