[PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

[PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

[Inki Dae]

This patch makes RC_CORE to be selected with this driver.

sil_sii8620 driver calls remote controller interfaces directly
so RC_CORE should be enabled mandatorily.

And some boards not using remote controller device don't really
need to know that RC_CORE config should be enabled to use sil_sii8620
driver only for HDMI.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/bridge/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 3aa65bd..0290fc3 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -72,8 +72,9 @@ config DRM_PARADE_PS8622
 
 config DRM_SIL_SII8620
 	tristate "Silicon Image SII8620 HDMI/MHL bridge"
-	depends on OF && RC_CORE
+	depends on OF
 	select DRM_KMS_HELPER
+	select RC_CORE
 	help
 	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
 
-- 
1.9.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

[Andrzej Hajda]

On 24.05.2018 09:07, Inki Dae wrote:
> This patch makes RC_CORE to be selected with this driver.
>
> sil_sii8620 driver calls remote controller interfaces directly
> so RC_CORE should be enabled mandatorily.
>
> And some boards not using remote controller device don't really
> need to know that RC_CORE config should be enabled to use sil_sii8620
> driver only for HDMI.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 3aa65bd..0290fc3 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -72,8 +72,9 @@ config DRM_PARADE_PS8622
>  
>  config DRM_SIL_SII8620
>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"
> -	depends on OF && RC_CORE
> +	depends on OF
>  	select DRM_KMS_HELPER
> +	select RC_CORE

RC_CORE depends on INPUT so it will break compilation if INPUT is not
defined.
Adding also 'select INPUT' should work:

-	depends on OF && RC_CORE
+	depends on OF
 	select DRM_KMS_HELPER
+	select INPUT
+	select RC_CORE


Regards
Andrzej



>  	help
>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
>  


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: sil_sii8620: do not have a dependency of RC_CORE

[Inki Dae]

2018년 05월 24일 17:03에 Andrzej Hajda 이(가) 쓴 글:
> On 24.05.2018 09:07, Inki Dae wrote:
>> This patch makes RC_CORE to be selected with this driver.
>>
>> sil_sii8620 driver calls remote controller interfaces directly
>> so RC_CORE should be enabled mandatorily.
>>
>> And some boards not using remote controller device don't really
>> need to know that RC_CORE config should be enabled to use sil_sii8620
>> driver only for HDMI.
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>>  drivers/gpu/drm/bridge/Kconfig | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>> index 3aa65bd..0290fc3 100644
>> --- a/drivers/gpu/drm/bridge/Kconfig
>> +++ b/drivers/gpu/drm/bridge/Kconfig
>> @@ -72,8 +72,9 @@ config DRM_PARADE_PS8622
>>  
>>  config DRM_SIL_SII8620
>>  	tristate "Silicon Image SII8620 HDMI/MHL bridge"
>> -	depends on OF && RC_CORE
>> +	depends on OF
>>  	select DRM_KMS_HELPER
>> +	select RC_CORE
> 
> RC_CORE depends on INPUT so it will break compilation if INPUT is not
> defined.
> Adding also 'select INPUT' should work:

Opps, I will post v2 soon.

Thanks,
Inki Dae

> 
> -	depends on OF && RC_CORE
> +	depends on OF
>  	select DRM_KMS_HELPER
> +	select INPUT
> +	select RC_CORE
> 
> 
> Regards
> Andrzej
> 
> 
> 
>>  	help
>>  	  Silicon Image SII8620 HDMI/MHL bridge chip driver.
>>  
> 
> 
> 
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel