From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 4/6] drm/i915: Apply the full CPU domain markup before freezing
Date: Fri, 01 Jun 2018 16:04:14 +0300 [thread overview]
Message-ID: <1527858254.3392.5.camel@linux.intel.com> (raw)
In-Reply-To: <20180601093554.13083-4-chris@chris-wilson.co.uk>
On Fri, 2018-06-01 at 10:35 +0100, Chris Wilson wrote:
> Let's not take any chances by using a shortcut to mark the objects as in
> the CPU domain upon freezing (all pages will be written to disk and so
> on restore all objects will start from the CPU domain). Currently, we
> simply mark the objects as being in the CPU domain, bypassing the
> flushes. Let's call the full domain transfer function so that we have
> less special case code (and symmetry with the suspend path) even though
> it will be mostly redundant.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Right, so the naming sees to be symmetry to this function... I'm
assuming this has no performance impact, so:
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Graphics Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-01 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 9:35 [PATCH 1/6] drm/i915/gtt: Avoid calling non-existent allocate_va_range Chris Wilson
2018-06-01 9:35 ` [PATCH 2/6] drm/i915/gtt: Don't restore the non-existent PDE for GGTT Chris Wilson
2018-06-01 12:56 ` Joonas Lahtinen
2018-06-01 13:55 ` Chris Wilson
2018-06-01 9:35 ` [PATCH 3/6] drm/i915: Flush all writes before suspend Chris Wilson
2018-06-01 13:01 ` Joonas Lahtinen
2018-06-01 9:35 ` [PATCH 4/6] drm/i915: Apply the full CPU domain markup before freezing Chris Wilson
2018-06-01 13:04 ` Joonas Lahtinen [this message]
2018-06-01 9:35 ` [PATCH 5/6] drm/i915/gtt: Enable full-ppgtt by default for HSW Chris Wilson
2018-06-01 9:35 ` [PATCH 6/6] drm/i915/gtt: Enable full-ppgtt by default everywhere! Chris Wilson
2018-06-01 10:01 ` ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/i915/gtt: Avoid calling non-existent allocate_va_range Patchwork
2018-06-01 11:37 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527858254.3392.5.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.