All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	fabio.estevam@nxp.com, kernel@pengutronix.de,
	mark.rutland@arm.com, matteo.lisi@engicam.com,
	michael@amarulasolutions.com, mturquette@baylibre.com,
	robh+dt@kernel.org, shawnguo@kernel.org
Cc: linux-clk@vger.kernel.org, Linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clk: imx6ul: add GPIO clock gates
Date: Fri, 01 Jun 2018 23:19:23 -0700	[thread overview]
Message-ID: <152792036327.225090.14543251343485084840@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1439344955.9677.1526991935718@email.1und1.de>

Quoting Stefan Wahren (2018-05-22 05:25:35)
> > +++ b/include/dt-bindings/clock/imx6ul-clock.h
> > @@ -242,20 +242,25 @@
> >  #define IMX6UL_CLK_CKO2_PODF         229
> >  #define IMX6UL_CLK_CKO2                      230
> >  #define IMX6UL_CLK_CKO                       231
> > +#define IMX6UL_CLK_GPIO1             232
> > +#define IMX6UL_CLK_GPIO2             233
> > +#define IMX6UL_CLK_GPIO3             234
> > +#define IMX6UL_CLK_GPIO4             235
> > +#define IMX6UL_CLK_GPIO5             236
> 
> this change looks like a breakage of devicetree ABI. You are changing the mean of the existing clock IDs on i.MX6ULL, which probably regress the combination of older DTBs with newer kernel.
> 

Agreed. Why can't we just tack on more numbers at the end?

> >  
> >  /* For i.MX6ULL */
> > -#define IMX6ULL_CLK_ESAI_PRED                232

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	fabio.estevam@nxp.com, kernel@pengutronix.de,
	mark.rutland@arm.com, matteo.lisi@engicam.com,
	michael@amarulasolutions.com, mturquette@baylibre.com,
	robh+dt@kernel.org, shawnguo@kernel.org
Cc: linux-clk@vger.kernel.org, Linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] clk: imx6ul: add GPIO clock gates
Date: Fri, 01 Jun 2018 23:19:23 -0700	[thread overview]
Message-ID: <152792036327.225090.14543251343485084840@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1439344955.9677.1526991935718@email.1und1.de>

Quoting Stefan Wahren (2018-05-22 05:25:35)
> > +++ b/include/dt-bindings/clock/imx6ul-clock.h
> > @@ -242,20 +242,25 @@
> >  #define IMX6UL_CLK_CKO2_PODF         229
> >  #define IMX6UL_CLK_CKO2                      230
> >  #define IMX6UL_CLK_CKO                       231
> > +#define IMX6UL_CLK_GPIO1             232
> > +#define IMX6UL_CLK_GPIO2             233
> > +#define IMX6UL_CLK_GPIO3             234
> > +#define IMX6UL_CLK_GPIO4             235
> > +#define IMX6UL_CLK_GPIO5             236
> =

> this change looks like a breakage of devicetree ABI. You are changing the=
 mean of the existing clock IDs on i.MX6ULL, which probably regress the com=
bination of older DTBs with newer kernel.
> =


Agreed. Why can't we just tack on more numbers at the end?

> >  =

> >  /* For i.MX6ULL */
> > -#define IMX6ULL_CLK_ESAI_PRED                232

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@kernel.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: imx6ul: add GPIO clock gates
Date: Fri, 01 Jun 2018 23:19:23 -0700	[thread overview]
Message-ID: <152792036327.225090.14543251343485084840@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1439344955.9677.1526991935718@email.1und1.de>

Quoting Stefan Wahren (2018-05-22 05:25:35)
> > +++ b/include/dt-bindings/clock/imx6ul-clock.h
> > @@ -242,20 +242,25 @@
> >  #define IMX6UL_CLK_CKO2_PODF         229
> >  #define IMX6UL_CLK_CKO2                      230
> >  #define IMX6UL_CLK_CKO                       231
> > +#define IMX6UL_CLK_GPIO1             232
> > +#define IMX6UL_CLK_GPIO2             233
> > +#define IMX6UL_CLK_GPIO3             234
> > +#define IMX6UL_CLK_GPIO4             235
> > +#define IMX6UL_CLK_GPIO5             236
> 
> this change looks like a breakage of devicetree ABI. You are changing the mean of the existing clock IDs on i.MX6ULL, which probably regress the combination of older DTBs with newer kernel.
> 

Agreed. Why can't we just tack on more numbers at the end?

> >  
> >  /* For i.MX6ULL */
> > -#define IMX6ULL_CLK_ESAI_PRED                232

  reply	other threads:[~2018-06-02  6:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22  3:25 [PATCH 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
2018-05-22  3:25 ` Anson Huang
2018-05-22  3:26 ` [PATCH 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
2018-05-22  3:26   ` Anson Huang
2018-05-22 11:26   ` Fabio Estevam
2018-05-22 11:26     ` Fabio Estevam
2018-05-22 11:25 ` [PATCH 1/2] clk: imx6ul: add GPIO clock gates Fabio Estevam
2018-05-22 11:25   ` Fabio Estevam
2018-05-22 12:25 ` Stefan Wahren
2018-05-22 12:25   ` Stefan Wahren
2018-06-02  6:19   ` Stephen Boyd [this message]
2018-06-02  6:19     ` Stephen Boyd
2018-06-02  6:19     ` Stephen Boyd
2018-06-03  1:36     ` Anson Huang
2018-06-03  1:36       ` Anson Huang
2018-06-03  1:36       ` Anson Huang
2018-06-02 13:48   ` Fabio Estevam
2018-06-02 13:48     ` Fabio Estevam
2018-06-02 14:04     ` Michael Nazzareno Trimarchi
2018-06-02 14:04       ` Michael Nazzareno Trimarchi
2018-06-02 14:07       ` Fabio Estevam
2018-06-02 14:07         ` Fabio Estevam
2018-06-02 14:12         ` Michael Nazzareno Trimarchi
2018-06-02 14:12           ` Michael Nazzareno Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152792036327.225090.14543251343485084840@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matteo.lisi@engicam.com \
    --cc=michael@amarulasolutions.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.