obmc-gerrit: A tool for automagically adding reviewers to your patches

obmc-gerrit: A tool for automagically adding reviewers to your patches

[Andrew Jeffery]

Hello,

I've created a helper script that automatically adds reviewers to your patches when you push them to Gerrit:

https://github.com/openbmc/openbmc-tools/tree/master/amboar/obmc-scripts/maintainers

Why do you care? I'm hoping that it reduces the time it takes for your patches to get attention *and* relieves you from the tedium of adding the reviewers yourself.

The script is a wrapper for `git push` that also parses the MAINTAINERS file in the root of the repository. I recently sent a flood of patches adding a MAINTAINERS file to each repo maintained by the OpenBMC organisation, so obmc-gerrit should be generally useful in the very near future.

I'm always open to feedback, so make sure to reply here or ping me on IRC if you have opinions.

Cheers,

Andrew

Re: obmc-gerrit: A tool for automagically adding reviewers to your patches

[Emily Shaffer]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

Excellent! Thanks Andrew!!!!!

On Mon, May 21, 2018 at 6:45 PM Andrew Jeffery <andrew@aj.id.au> wrote:

> Hello,
>
> I've created a helper script that automatically adds reviewers to your
> patches when you push them to Gerrit:
>
>
> https://github.com/openbmc/openbmc-tools/tree/master/amboar/obmc-scripts/maintainers
>
> Why do you care? I'm hoping that it reduces the time it takes for your
> patches to get attention *and* relieves you from the tedium of adding the
> reviewers yourself.
>
> The script is a wrapper for `git push` that also parses the MAINTAINERS
> file in the root of the repository. I recently sent a flood of patches
> adding a MAINTAINERS file to each repo maintained by the OpenBMC
> organisation, so obmc-gerrit should be generally useful in the very near
> future.
>
> I'm always open to feedback, so make sure to reply here or ping me on IRC
> if you have opinions.
>
> Cheers,
>
> Andrew
>

[-- Attachment #2: Type: text/html, Size: 1333 bytes --]

Re: obmc-gerrit: A tool for automagically adding reviewers to your patches

[Andrew Jeffery]

On Fri, 1 Jun 2018, at 09:07, Emily Shaffer wrote:
> Excellent! Thanks Andrew!!!!!

No worries.

I'm wondering whether I should also add support for parsing 'Cc:' tags out of the commit messages and further mangling the refspec based on that...

Thoughts?

Andrew

Re: obmc-gerrit: A tool for automagically adding reviewers to your patches

[Emily Shaffer]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

At least in IPMI etc I haven't seen people use this. Are they common
elsewhere in the project?

On Thu, May 31, 2018 at 5:56 PM Andrew Jeffery <andrew@aj.id.au> wrote:

> On Fri, 1 Jun 2018, at 09:07, Emily Shaffer wrote:
> > Excellent! Thanks Andrew!!!!!
>
> No worries.
>
> I'm wondering whether I should also add support for parsing 'Cc:' tags out
> of the commit messages and further mangling the refspec based on that...
>
> Thoughts?
>
> Andrew
>

[-- Attachment #2: Type: text/html, Size: 739 bytes --]

Re: obmc-gerrit: A tool for automagically adding reviewers to your patches

[Andrew Jeffery]

On Sat, 2 Jun 2018, at 02:16, Emily Shaffer wrote:
> At least in IPMI etc I haven't seen people use this. Are they common
> elsewhere in the project?
> 

The Cc: tag is common in the kernel as it uses a mailing-list based development method. As such it's pretty well established.  The thought was so that I could be even lazier about pushing changes to Gerrit.

Nothing would *force* you to use it, was just wondering if it would be convenient for anyone besides me (i.e. is there enough interest to warrant the effort).

Andrew