* [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode
@ 2018-06-07 12:45 Geert Uytterhoeven
2018-06-08 15:08 ` Ramon Fried
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2018-06-07 12:45 UTC (permalink / raw)
To: Eyal Ilsar, Kalle Valo, David S . Miller
Cc: Arnd Bergmann, wcn36xx, linux-wireless, netdev, linux-kernel,
Geert Uytterhoeven
Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program
drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program
drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program
Remove the BOM, the rest of the file is plain ASCII anyway.
Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text
and after:
drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wireless/ath/wcn36xx/testmode.c
index 1279064a3b716c2e..51a038022c8b8040 100644
--- a/drivers/net/wireless/ath/wcn36xx/testmode.c
+++ b/drivers/net/wireless/ath/wcn36xx/testmode.c
@@ -1,4 +1,4 @@
-/*
+/*
* Copyright (c) 2018, The Linux Foundation. All rights reserved.
*
* Permission to use, copy, modify, and/or distribute this software for any
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode
2018-06-07 12:45 [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode Geert Uytterhoeven
@ 2018-06-08 15:08 ` Ramon Fried
2018-06-11 14:13 ` Kalle Valo
2018-06-28 9:29 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Ramon Fried @ 2018-06-08 15:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Eyal Ilsar, Kalle Valo, David S . Miller, Arnd Bergmann, netdev,
linux-wireless, open list, wcn36xx
On Thu, Jun 7, 2018 at 3:45 PM, Geert Uytterhoeven <geert@linux-m68k.org> w=
rote:
> Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray =E2=80=98=
\357=E2=80=99 in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray =E2=80=98=
\273=E2=80=99 in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray =E2=80=98=
\277=E2=80=99 in program
>
> Remove the BOM, the rest of the file is plain ASCII anyway.
>
> Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode =
(with BOM) text
>
> and after:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
>
> Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM=
)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks Geert !
Acked-by: Ramon Fried <ramon.fried@gmail.com>
> ---
> drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wi=
reless/ath/wcn36xx/testmode.c
> index 1279064a3b716c2e..51a038022c8b8040 100644
> --- a/drivers/net/wireless/ath/wcn36xx/testmode.c
> +++ b/drivers/net/wireless/ath/wcn36xx/testmode.c
> @@ -1,4 +1,4 @@
> -=EF=BB=BF/*
> +/*
> * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> *
> * Permission to use, copy, modify, and/or distribute this software for =
any
> --
> 2.7.4
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode
@ 2018-06-08 15:08 ` Ramon Fried
0 siblings, 0 replies; 6+ messages in thread
From: Ramon Fried @ 2018-06-08 15:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Eyal Ilsar, Kalle Valo, David S . Miller, Arnd Bergmann, netdev,
linux-wireless, open list, wcn36xx
On Thu, Jun 7, 2018 at 3:45 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program
>
> Remove the BOM, the rest of the file is plain ASCII anyway.
>
> Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text
>
> and after:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
>
> Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thanks Geert !
Acked-by: Ramon Fried <ramon.fried@gmail.com>
> ---
> drivers/net/wireless/ath/wcn36xx/testmode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/testmode.c b/drivers/net/wireless/ath/wcn36xx/testmode.c
> index 1279064a3b716c2e..51a038022c8b8040 100644
> --- a/drivers/net/wireless/ath/wcn36xx/testmode.c
> +++ b/drivers/net/wireless/ath/wcn36xx/testmode.c
> @@ -1,4 +1,4 @@
> -/*
> +/*
> * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> *
> * Permission to use, copy, modify, and/or distribute this software for any
> --
> 2.7.4
>
>
> _______________________________________________
> wcn36xx mailing list
> wcn36xx@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/wcn36xx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode
2018-06-07 12:45 [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode Geert Uytterhoeven
@ 2018-06-11 14:13 ` Kalle Valo
2018-06-11 14:13 ` Kalle Valo
2018-06-28 9:29 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-06-11 14:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Eyal Ilsar, David S . Miller, Arnd Bergmann, netdev,
linux-wireless, linux-kernel, wcn36xx
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray =E2=80=98=
\357=E2=80=99 in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray =E2=80=98=
\273=E2=80=99 in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray =E2=80=98=
\277=E2=80=99 in program
>
> Remove the BOM, the rest of the file is plain ASCII anyway.
>
> Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode =
(with BOM) text
>
> and after:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
>
> Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM=
)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
I'll queue this for 4.18.
--=20
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode
@ 2018-06-11 14:13 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-06-11 14:13 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Eyal Ilsar, David S . Miller, Arnd Bergmann, netdev,
linux-wireless, linux-kernel, wcn36xx
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program
>
> Remove the BOM, the rest of the file is plain ASCII anyway.
>
> Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text
>
> and after:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
>
> Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
I'll queue this for 4.18.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: wcn36xx: Remove Unicode Byte Order Mark from testcode
2018-06-07 12:45 [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode Geert Uytterhoeven
2018-06-08 15:08 ` Ramon Fried
2018-06-11 14:13 ` Kalle Valo
@ 2018-06-28 9:29 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2018-06-28 9:29 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Eyal Ilsar, David S . Miller, Arnd Bergmann, wcn36xx,
linux-wireless, netdev, linux-kernel, Geert Uytterhoeven
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Older gcc (< 4.4) doesn't like files starting with a Unicode BOM:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\357’ in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\273’ in program
> drivers/net/wireless/ath/wcn36xx/testmode.c:1: error: stray ‘\277’ in program
>
> Remove the BOM, the rest of the file is plain ASCII anyway.
>
> Output of "file drivers/net/wireless/ath/wcn36xx/testmode.c" before:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, UTF-8 Unicode (with BOM) text
>
> and after:
>
> drivers/net/wireless/ath/wcn36xx/testmode.c: C source, ASCII text
>
> Fixes: 87f825e6e246cee0 ("wcn36xx: Add support for Factory Test Mode (FTM)")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Ramon Fried <ramon.fried@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-current branch of ath.git, thanks.
371d5e9d99e1 wcn36xx: Remove Unicode Byte Order Mark from testcode
--
https://patchwork.kernel.org/patch/10451875/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-28 9:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-07 12:45 [PATCH] wcn36xx: Remove Unicode Byte Order Mark from testcode Geert Uytterhoeven
2018-06-08 15:08 ` Ramon Fried
2018-06-08 15:08 ` Ramon Fried
2018-06-11 14:13 ` Kalle Valo
2018-06-11 14:13 ` Kalle Valo
2018-06-28 9:29 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.