* Re: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak
@ 2018-06-12 7:48 ` Minas Harutyunyan
0 siblings, 0 replies; 4+ messages in thread
From: Minas Harutyunyan @ 2018-06-12 7:48 UTC (permalink / raw)
To: Zeng Tao, Minas.Harutyunyan; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
On 6/12/2018 10:51 AM, Zeng Tao wrote:
> In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
> a usb request, the current flow will complete one usb request with no
> hardware transfer, this will lead to a packet drop on the usb bus.
>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> ---
> drivers/usb/dwc2/gadget.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f0d9ccf..fbe65f6 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
>
> tmp = dwc2_hsotg_read_frameno(hsotg);
> if (using_desc_dma(hsotg)) {
> - dwc2_hsotg_complete_request(hsotg, hs_ep,
> - get_ep_head(hs_ep), 0);
> -
> hs_ep->target_frame = tmp;
> dwc2_gadget_incr_frame_num(hs_ep);
> dwc2_gadget_start_isoc_ddma(hs_ep);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak
@ 2018-06-12 7:48 ` Minas Harutyunyan
0 siblings, 0 replies; 4+ messages in thread
From: Minas Harutyunyan @ 2018-06-12 7:48 UTC (permalink / raw)
To: Zeng Tao, Minas.Harutyunyan; +Cc: Greg Kroah-Hartman, linux-usb, linux-kernel
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
On 6/12/2018 10:51 AM, Zeng Tao wrote:
> In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
> a usb request, the current flow will complete one usb request with no
> hardware transfer, this will lead to a packet drop on the usb bus.
>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
> ---
> drivers/usb/dwc2/gadget.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index f0d9ccf..fbe65f6 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
>
> tmp = dwc2_hsotg_read_frameno(hsotg);
> if (using_desc_dma(hsotg)) {
> - dwc2_hsotg_complete_request(hsotg, hs_ep,
> - get_ep_head(hs_ep), 0);
> -
> hs_ep->target_frame = tmp;
> dwc2_gadget_incr_frame_num(hs_ep);
> dwc2_gadget_start_isoc_ddma(hs_ep);
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak
@ 2018-06-12 14:49 ` Zengtao (B)
0 siblings, 0 replies; 4+ messages in thread
From: Zeng Tao @ 2018-06-12 14:49 UTC (permalink / raw)
To: hminas; +Cc: prime.zeng, Greg Kroah-Hartman, linux-usb, linux-kernel
In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
a usb request, the current flow will complete one usb request with no
hardware transfer, this will lead to a packet drop on the usb bus.
Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
---
drivers/usb/dwc2/gadget.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index f0d9ccf..fbe65f6 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
tmp = dwc2_hsotg_read_frameno(hsotg);
if (using_desc_dma(hsotg)) {
- dwc2_hsotg_complete_request(hsotg, hs_ep,
- get_ep_head(hs_ep), 0);
-
hs_ep->target_frame = tmp;
dwc2_gadget_incr_frame_num(hs_ep);
dwc2_gadget_start_isoc_ddma(hs_ep);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak
@ 2018-06-12 14:49 ` Zengtao (B)
0 siblings, 0 replies; 4+ messages in thread
From: Zengtao (B) @ 2018-06-12 14:49 UTC (permalink / raw)
To: hminas; +Cc: prime.zeng, Greg Kroah-Hartman, linux-usb, linux-kernel
In ISOC transfer, when the NAK interrupt happens, we shouldn't complete
a usb request, the current flow will complete one usb request with no
hardware transfer, this will lead to a packet drop on the usb bus.
Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
---
drivers/usb/dwc2/gadget.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index f0d9ccf..fbe65f6 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2/gadget.c
@@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
tmp = dwc2_hsotg_read_frameno(hsotg);
if (using_desc_dma(hsotg)) {
- dwc2_hsotg_complete_request(hsotg, hs_ep,
- get_ep_head(hs_ep), 0);
-
hs_ep->target_frame = tmp;
dwc2_gadget_incr_frame_num(hs_ep);
dwc2_gadget_start_isoc_ddma(hs_ep);
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-12 14:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 14:49 [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak Zeng Tao
2018-06-12 14:49 ` Zengtao (B)
2018-06-12 7:48 ` [PATCH] " Minas Harutyunyan
2018-06-12 7:48 ` Minas Harutyunyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.