* [PATCH V2] boost: Improve reproducibility
@ 2018-06-15 8:35 mingli.yu
2018-06-17 9:17 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: mingli.yu @ 2018-06-15 8:35 UTC (permalink / raw)
To: openembedded-core, alexander.kanavin, raj.khem
From: Mingli Yu <Mingli.Yu@windriver.com>
Set .file section explicitly for .S files to avoid
the linker introduces the host path in symbols for
object files whose source file is .S
Otherwise, there is a host path in the symbols as
below:
$ readelf --wide --symbols /my-build/boost/1.67.0-r0/boost_1_67_0/x86_64-poky-linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38ed/libboost_context.so.1.67.0
42: 0000000000000000 0 FILE LOCAL DEFAULT ABS /my-build/boost/1.67.0-r0/boost_1_67_0/x86_64-poky-linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38ed/asm/make_x86_64_sysv_elf_gas.o
[YOCTO #12708]
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
...e_x86_64_sysv_elf_gas.S-set-.file-section.patch | 48 ++++++++++++++++++++++
meta/recipes-support/boost/boost_1.67.0.bb | 1 +
2 files changed, 49 insertions(+)
create mode 100644 meta/recipes-support/boost/boost/0001-make_x86_64_sysv_elf_gas.S-set-.file-section.patch
diff --git a/meta/recipes-support/boost/boost/0001-make_x86_64_sysv_elf_gas.S-set-.file-section.patch b/meta/recipes-support/boost/boost/0001-make_x86_64_sysv_elf_gas.S-set-.file-section.patch
new file mode 100644
index 0000000..c2ac49e
--- /dev/null
+++ b/meta/recipes-support/boost/boost/0001-make_x86_64_sysv_elf_gas.S-set-.file-section.patch
@@ -0,0 +1,48 @@
+From c99f798407e44c86e9f64f5b1adf3b4d0549eef2 Mon Sep 17 00:00:00 2001
+From: Mingli Yu <Mingli.Yu@windriver.com>
+Date: Fri, 15 Jun 2018 16:21:56 +0800
+Subject: [PATCH] make_x86_64_sysv_elf_gas.S: set .file section
+
+Set .file section explicitly for .S files to avoid
+the linker introduces the host path in symbols for
+object files whose source file is .S
+Otherwise, there is a host path in the symbols as below:
+$ readelf --wide --symbols /my-build/boost/1.67.0-r0/boost_1_67_0/x86_64-poky-linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38ed/libboost_context.so.1.67.0
+
+42: 0000000000000000 0 FILE LOCAL DEFAULT ABS /my-build/boost/1.67.0-r0/boost_1_67_0/x86_64-poky-linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38ed/asm/make_x86_64_sysv_elf_gas.o
+
+Upstream-Status: Pending
+
+Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
+---
+ libs/context/src/asm/make_i386_sysv_elf_gas.S | 1 +
+ libs/context/src/asm/make_x86_64_sysv_elf_gas.S | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/libs/context/src/asm/make_i386_sysv_elf_gas.S b/libs/context/src/asm/make_i386_sysv_elf_gas.S
+index de77e88..b76de26 100644
+--- a/libs/context/src/asm/make_i386_sysv_elf_gas.S
++++ b/libs/context/src/asm/make_i386_sysv_elf_gas.S
+@@ -24,6 +24,7 @@
+ * *
+ ****************************************************************************************/
+
++.file "make_i386_sysv_elf_gas.S"
+ .text
+ .globl make_fcontext
+ .align 2
+diff --git a/libs/context/src/asm/make_x86_64_sysv_elf_gas.S b/libs/context/src/asm/make_x86_64_sysv_elf_gas.S
+index 25a0c00..0ef3756 100644
+--- a/libs/context/src/asm/make_x86_64_sysv_elf_gas.S
++++ b/libs/context/src/asm/make_x86_64_sysv_elf_gas.S
+@@ -24,6 +24,7 @@
+ * *
+ ****************************************************************************************/
+
++.file "make_x86_64_sysv_elf_gas.S"
+ .text
+ .globl make_fcontext
+ .type make_fcontext,@function
+--
+2.7.4
+
diff --git a/meta/recipes-support/boost/boost_1.67.0.bb b/meta/recipes-support/boost/boost_1.67.0.bb
index eb50899..7bb4511 100644
--- a/meta/recipes-support/boost/boost_1.67.0.bb
+++ b/meta/recipes-support/boost/boost_1.67.0.bb
@@ -7,4 +7,5 @@ SRC_URI += "\
file://boost-math-disable-pch-for-gcc.patch \
file://0001-Apply-boost-1.62.0-no-forced-flags.patch.patch \
file://0003-Don-t-set-up-arch-instruction-set-flags-we-do-that-o.patch \
+ file://0001-make_x86_64_sysv_elf_gas.S-set-.file-section.patch \
"
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2] boost: Improve reproducibility
2018-06-15 8:35 [PATCH V2] boost: Improve reproducibility mingli.yu
@ 2018-06-17 9:17 ` Richard Purdie
2018-06-17 14:04 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2018-06-17 9:17 UTC (permalink / raw)
To: mingli.yu, openembedded-core, alexander.kanavin, raj.khem
On Fri, 2018-06-15 at 16:35 +0800, mingli.yu@windriver.com wrote:
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Set .file section explicitly for .S files to avoid
> the linker introduces the host path in symbols for
> object files whose source file is .S
> Otherwise, there is a host path in the symbols as
> below:
> $ readelf --wide --symbols /my-build/boost/1.67.0-
> r0/boost_1_67_0/x86_64-poky-
> linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38e
> d/libboost_context.so.1.67.0
> 42: 0000000000000000 0 FILE LOCAL DEFAULT ABS /my-build/boost/1.67.0-
> r0/boost_1_67_0/x86_64-poky-
> linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38e
> d/asm/make_x86_64_sysv_elf_gas.o
>
> [YOCTO #12708]
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
>
Thanks for working through this, the final result is a much better fix!
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] boost: Improve reproducibility
2018-06-17 9:17 ` Richard Purdie
@ 2018-06-17 14:04 ` Khem Raj
2018-06-19 1:27 ` Yu, Mingli
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2018-06-17 14:04 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]
On Sun, Jun 17, 2018 at 2:17 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2018-06-15 at 16:35 +0800, mingli.yu@windriver.com wrote:
> > From: Mingli Yu <Mingli.Yu@windriver.com>
> >
> > Set .file section explicitly for .S files to avoid
> > the linker introduces the host path in symbols for
> > object files whose source file is .S
> > Otherwise, there is a host path in the symbols as
> > below:
> > $ readelf --wide --symbols /my-build/boost/1.67.0-
> > r0/boost_1_67_0/x86_64-poky-
> > linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38e
> > d/libboost_context.so.1.67.0
> > 42: 0000000000000000 0 FILE LOCAL DEFAULT ABS /my-build/boost/1.67.0-
> > r0/boost_1_67_0/x86_64-poky-
> > linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38e
> > d/asm/make_x86_64_sysv_elf_gas.o
> >
> > [YOCTO #12708]
> >
> > Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> >
> Thanks for working through this, the final result is a much better fix!
If we add this directive to all the .S files there
Then it can be up streamed too
>
>
> Cheers,
>
> Richard
>
[-- Attachment #2: Type: text/html, Size: 1893 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2] boost: Improve reproducibility
2018-06-17 14:04 ` Khem Raj
@ 2018-06-19 1:27 ` Yu, Mingli
0 siblings, 0 replies; 4+ messages in thread
From: Yu, Mingli @ 2018-06-19 1:27 UTC (permalink / raw)
To: Khem Raj, Richard Purdie; +Cc: openembedded-core
On 2018年06月17日 22:04, Khem Raj wrote:
>
>
> On Sun, Jun 17, 2018 at 2:17 AM Richard Purdie
> <richard.purdie@linuxfoundation.org
> <mailto:richard.purdie@linuxfoundation.org>> wrote:
>
> On Fri, 2018-06-15 at 16:35 +0800, mingli.yu@windriver.com
> <mailto:mingli.yu@windriver.com> wrote:
> > From: Mingli Yu <Mingli.Yu@windriver.com
> <mailto:Mingli.Yu@windriver.com>>
> >
> > Set .file section explicitly for .S files to avoid
> > the linker introduces the host path in symbols for
> > object files whose source file is .S
> > Otherwise, there is a host path in the symbols as
> > below:
> > $ readelf --wide --symbols /my-build/boost/1.67.0-
> > r0/boost_1_67_0/x86_64-poky-
> > linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38e
> > d/libboost_context.so.1.67.0
> > 42: 0000000000000000 0 FILE LOCAL DEFAULT ABS /my-build/boost/1.67.0-
> > r0/boost_1_67_0/x86_64-poky-
> > linux/boost/bin.v2/libs/context/build/aca09349fdb84d131321425f6c3a38e
> > d/asm/make_x86_64_sysv_elf_gas.o
> >
> > [YOCTO #12708]
> >
> > Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com
> <mailto:Mingli.Yu@windriver.com>>
> >
> Thanks for working through this, the final result is a much better fix!
>
>
> If we add this directive to all the .S files there
> Then it can be up streamed too
Yes, I did try to send the related fix to upstream.
Thanks Khem's help!
Thanks,
>
>
>
> Cheers,
>
> Richard
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-19 1:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 8:35 [PATCH V2] boost: Improve reproducibility mingli.yu
2018-06-17 9:17 ` Richard Purdie
2018-06-17 14:04 ` Khem Raj
2018-06-19 1:27 ` Yu, Mingli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.