All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx7: psci: Add support for version command
Date: Fri, 22 Jun 2018 18:40:56 +0000	[thread overview]
Message-ID: <1529692855.28705.222.camel@impinj.com> (raw)
In-Reply-To: <cc1cdf2be721eb3d1824e55ccc1364a0@agner.ch>

On Fri, 2018-06-22 at 11:09 +0200, Stefan Agner wrote:
> On 31.05.2018 20:13, Trent Piepho wrote:
> > This command should be supported for PSCI 1.0.  Current code results in
> > this message from the kernel:  "PSCIv65535.65535 detected in firmware."
> > 
> > This will mess up a kernel check of the PSCI version.  Currently the
> > kernel only cares if the version is at least 1.0 so it doesn't break
> > anything, as the incorrect version and correct version are both >= 1.0,
> > but as soon as a check for > 1.0 goes in it will fail.
> 
> The right direction, it can also be done in C though:
> 
> unsigned int __secure psci_version(u32 function_id)
> {
> 	return ARM_PSCI_VER_1_0;
> }

When the PSCI is left in RAM, does it consist of the entire u-boot
image, or is somehow just the PSCI component left?

I'm curious how placing the code in another object file affects the
PSCI binary.

> But this is not complete though, since also other callbacks need to be
> supported for proper PSCI 1.0 support.
> 
> See also this discussion:

I see this problem was known before I found it.  It would be nice if a
fix could go in before others also find it and waste time
investigating.

It is also the case the reset code in the PSCI does not work on imx7
for some time now, for boards with a reset design following NXP's
recommendations.  This is not hard to change, I've already done so
locally for our product affected by this.

Must these problems remain unaddressed until some future redesign or
major patch from NXP fixes them?

      reply	other threads:[~2018-06-22 18:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 18:13 [U-Boot] [PATCH] imx: mx7: psci: Add support for version command Trent Piepho
2018-06-22  9:09 ` Stefan Agner
2018-06-22 18:40   ` Trent Piepho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529692855.28705.222.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.