All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx7: psci: Add support for version command
Date: Thu, 31 May 2018 11:13:35 -0700	[thread overview]
Message-ID: <20180531181335.27241-1-tpiepho@impinj.com> (raw)

This command should be supported for PSCI 1.0.  Current code results in
this message from the kernel:  "PSCIv65535.65535 detected in firmware."

This will mess up a kernel check of the PSCI version.  Currently the
kernel only cares if the version is at least 1.0 so it doesn't break
anything, as the incorrect version and correct version are both >= 1.0,
but as soon as a check for > 1.0 goes in it will fail.

CC: Anson Huang <Anson.Huang@nxp.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Signed-off-by: Trent Piepho <tpiepho@impinj.com>
---
 arch/arm/mach-imx/mx7/psci.S | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/mach-imx/mx7/psci.S b/arch/arm/mach-imx/mx7/psci.S
index 89dcf880e8..7035f6093b 100644
--- a/arch/arm/mach-imx/mx7/psci.S
+++ b/arch/arm/mach-imx/mx7/psci.S
@@ -57,4 +57,14 @@ psci_system_off:
 3: 	wfi
 	b 3b
 
+.globl psci_version
+psci_version:
+#if defined(CONFIG_ARMV7_PSCI_1_0)
+	ldr	r0, =ARM_PSCI_VER_1_0
+#else
+#error "add support for your PSCI version"
+#endif
+
+	bx	lr
+
 	.popsection
-- 
2.14.3

             reply	other threads:[~2018-05-31 18:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 18:13 Trent Piepho [this message]
2018-06-22  9:09 ` [U-Boot] [PATCH] imx: mx7: psci: Add support for version command Stefan Agner
2018-06-22 18:40   ` Trent Piepho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531181335.27241-1-tpiepho@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.