* [PATCH 1/2] ARM: imx_v6_v7_defconfig: Re-sync defconfig
@ 2018-06-25 12:34 Fabio Estevam
2018-06-25 12:34 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support Fabio Estevam
0 siblings, 1 reply; 10+ messages in thread
From: Fabio Estevam @ 2018-06-25 12:34 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Re-sync imx_v6_v7_defconfig by doing:
make savedefconfig
cp defconfig arch/arm/configs/imx_v6_v7_defconfig
CONFIG_BT_HCIUART_H4 option is selected via Kconfig logic.
CONFIG_SND_SOC_IMX_WM8962 no longer exists as the imx-wm8962 audio
machine layer has been removed.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index f70507a..d14de86 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -81,7 +81,6 @@ CONFIG_CAN=y
CONFIG_CAN_FLEXCAN=y
CONFIG_BT=y
CONFIG_BT_HCIUART=y
-CONFIG_BT_HCIUART_H4=y
CONFIG_BT_HCIUART_LL=y
CONFIG_CFG80211=y
CONFIG_CFG80211_WEXT=y
@@ -282,7 +281,6 @@ CONFIG_SND_SOC_FSL_ASRC=y
CONFIG_SND_IMX_SOC=y
CONFIG_SND_SOC_PHYCORE_AC97=y
CONFIG_SND_SOC_EUKREA_TLV320=y
-CONFIG_SND_SOC_IMX_WM8962=y
CONFIG_SND_SOC_IMX_ES8328=y
CONFIG_SND_SOC_IMX_SGTL5000=y
CONFIG_SND_SOC_IMX_SPDIF=y
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-06-25 12:34 [PATCH 1/2] ARM: imx_v6_v7_defconfig: Re-sync defconfig Fabio Estevam
@ 2018-06-25 12:34 ` Fabio Estevam
2018-06-25 12:57 ` Lucas Stach
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-06-25 12:34 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
USB ULPI can be functional on some boards like imx51-babbge.
This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
the bootloader does not initialize USB.
Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index d14de86..2da678c 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
CONFIG_USB_CHIPIDEA=y
CONFIG_USB_CHIPIDEA_UDC=y
CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
CONFIG_USB_SERIAL=m
CONFIG_USB_SERIAL_GENERIC=y
CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
CONFIG_USB_FUNCTIONFS=m
CONFIG_USB_MASS_STORAGE=m
CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_PLTFM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-06-25 12:34 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support Fabio Estevam
@ 2018-06-25 12:57 ` Lucas Stach
2018-06-25 13:07 ` Fabio Estevam
2018-07-01 13:20 ` Shawn Guo
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Lucas Stach @ 2018-06-25 12:57 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, den 25.06.2018, 09:34 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
>
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.
If the kernel hangs without those options, we might want to have a
check for them in the driver, so it aborts the initialization with a
big warning if the port is using ULPI mode and those options aren't
selected.
Regards,
Lucas
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> ?arch/arm/configs/imx_v6_v7_defconfig | 2 ++
> ?1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> b/arch/arm/configs/imx_v6_v7_defconfig
> index d14de86..2da678c 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
> ?CONFIG_USB_CHIPIDEA=y
> ?CONFIG_USB_CHIPIDEA_UDC=y
> ?CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_USB_CHIPIDEA_ULPI=y
> ?CONFIG_USB_SERIAL=m
> ?CONFIG_USB_SERIAL_GENERIC=y
> ?CONFIG_USB_SERIAL_FTDI_SIO=m
> @@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
> ?CONFIG_USB_FUNCTIONFS=m
> ?CONFIG_USB_MASS_STORAGE=m
> ?CONFIG_USB_G_SERIAL=m
> +CONFIG_USB_ULPI_BUS=y
> ?CONFIG_MMC=y
> ?CONFIG_MMC_SDHCI=y
> ?CONFIG_MMC_SDHCI_PLTFM=y
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-06-25 12:57 ` Lucas Stach
@ 2018-06-25 13:07 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-06-25 13:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lucas,
On Mon, Jun 25, 2018 at 9:57 AM, Lucas Stach <l.stach@pengutronix.de> wrote:
> If the kernel hangs without those options, we might want to have a
> check for them in the driver, so it aborts the initialization with a
> big warning if the port is using ULPI mode and those options aren't
> selected.
That's a good idea. Will do as suggested.
Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-06-25 12:34 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support Fabio Estevam
2018-06-25 12:57 ` Lucas Stach
@ 2018-07-01 13:20 ` Shawn Guo
2018-07-01 13:24 ` Fabio Estevam
2018-07-03 2:02 ` Shawn Guo
2018-07-03 13:10 ` Shawn Guo
3 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2018-07-01 13:20 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
>
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.
Is this hang a regression or what?
Shawn
>
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/configs/imx_v6_v7_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
> index d14de86..2da678c 100644
> --- a/arch/arm/configs/imx_v6_v7_defconfig
> +++ b/arch/arm/configs/imx_v6_v7_defconfig
> @@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
> CONFIG_USB_CHIPIDEA=y
> CONFIG_USB_CHIPIDEA_UDC=y
> CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_USB_CHIPIDEA_ULPI=y
> CONFIG_USB_SERIAL=m
> CONFIG_USB_SERIAL_GENERIC=y
> CONFIG_USB_SERIAL_FTDI_SIO=m
> @@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
> CONFIG_USB_FUNCTIONFS=m
> CONFIG_USB_MASS_STORAGE=m
> CONFIG_USB_G_SERIAL=m
> +CONFIG_USB_ULPI_BUS=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_PLTFM=y
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-07-01 13:20 ` Shawn Guo
@ 2018-07-01 13:24 ` Fabio Estevam
0 siblings, 0 replies; 10+ messages in thread
From: Fabio Estevam @ 2018-07-01 13:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
On Sun, Jul 1, 2018 at 10:20 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
>> USB ULPI can be functional on some boards like imx51-babbge.
>>
>> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
>> the bootloader does not initialize USB.
>
> Is this hang a regression or what?
Yes, it is a regression in 4.18-rc1 caused by commit 03e6275ae381
("usb: chipidea: Fix ULPI on imx51")
I have also sent a USB kernel patch that avoids the hang, but we need
both the USB patch + the defconfig change in 4.18.
Thanks
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-06-25 12:34 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support Fabio Estevam
2018-06-25 12:57 ` Lucas Stach
2018-07-01 13:20 ` Shawn Guo
@ 2018-07-03 2:02 ` Shawn Guo
2018-07-03 2:07 ` Shawn Guo
2018-07-03 13:10 ` Shawn Guo
3 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2018-07-03 2:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
>
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.
>
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied this one as a fix.
Shawn
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-07-03 2:02 ` Shawn Guo
@ 2018-07-03 2:07 ` Shawn Guo
0 siblings, 0 replies; 10+ messages in thread
From: Shawn Guo @ 2018-07-03 2:07 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 03, 2018 at 10:02:37AM +0800, Shawn Guo wrote:
> On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> > USB ULPI can be functional on some boards like imx51-babbge.
> >
> > This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> > the bootloader does not initialize USB.
> >
> > Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> Applied this one as a fix.
Dropped for now, as I suspect that such selection should be done by
driver Kconfig as a dependency.
Shawn
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support
2018-06-25 12:34 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support Fabio Estevam
` (2 preceding siblings ...)
2018-07-03 2:02 ` Shawn Guo
@ 2018-07-03 13:10 ` Shawn Guo
2018-07-03 13:12 ` Fabio Estevam
3 siblings, 1 reply; 10+ messages in thread
From: Shawn Guo @ 2018-07-03 13:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jun 25, 2018 at 09:34:03AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that
> USB ULPI can be functional on some boards like imx51-babbge.
>
> This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when
> the bootloader does not initialize USB.
>
> Suggested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied with editing the commit log a bit to mention commit
03e6275ae381 ("usb: chipidea: Fix ULPI on imx51").
Shawn
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-07-03 13:12 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-25 12:34 [PATCH 1/2] ARM: imx_v6_v7_defconfig: Re-sync defconfig Fabio Estevam
2018-06-25 12:34 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Select ULPI support Fabio Estevam
2018-06-25 12:57 ` Lucas Stach
2018-06-25 13:07 ` Fabio Estevam
2018-07-01 13:20 ` Shawn Guo
2018-07-01 13:24 ` Fabio Estevam
2018-07-03 2:02 ` Shawn Guo
2018-07-03 2:07 ` Shawn Guo
2018-07-03 13:10 ` Shawn Guo
2018-07-03 13:12 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.