[PATCH v3] f2fs: report error if quota off error during umount

[PATCH v3] f2fs: report error if quota off error during umount

[Yunlei He]

Now, we depend on fsck to ensure quota file data is ok,
so we scan whole partition if checkpoint without umount
flag. It's same for quota off error case, which may make
quota file data inconsistent.

Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
 fs/f2fs/super.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 73d7d7e..669a7af 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1820,7 +1820,9 @@ static int f2fs_quota_off(struct super_block *sb, int type)
 	if (!inode || !igrab(inode))
 		return dquot_quota_off(sb, type);
 
-	f2fs_quota_sync(sb, type);
+	err = f2fs_quota_sync(sb, type);
+	if (err)
+		goto out_put;
 
 	err = dquot_quota_off(sb, type);
 	if (err || f2fs_sb_has_quota_ino(sb))
@@ -1839,9 +1841,18 @@ static int f2fs_quota_off(struct super_block *sb, int type)
 void f2fs_quota_off_umount(struct super_block *sb)
 {
 	int type;
+	int err;
 
-	for (type = 0; type < MAXQUOTAS; type++)
-		f2fs_quota_off(sb, type);
+	for (type = 0; type < MAXQUOTAS; type++) {
+		err = f2fs_quota_off(sb, type);
+		if (err) {
+			f2fs_msg(sb, KERN_ERR,
+				"Fail to turn off disk quota "
+				"(type: %d, err: %d), Please "
+				"run fsck to fix it.", type, err);
+			set_sbi_flag(F2FS_SB(sb), SBI_NEED_FSCK);
+		}
+	}
 }
 
 static int f2fs_get_projid(struct inode *inode, kprojid_t *projid)
-- 
1.9.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH v3] f2fs: report error if quota off error during umount

[Chao Yu]

On 2018/6/26 13:12, Yunlei He wrote:
> Now, we depend on fsck to ensure quota file data is ok,
> so we scan whole partition if checkpoint without umount
> flag. It's same for quota off error case, which may make
> quota file data inconsistent.
> 
> Signed-off-by: Yunlei He <heyunlei@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH v3] f2fs: report error if quota off error during umount

[Chao Yu]

Ping,

On 2018/6/26 16:34, Chao Yu wrote:
> On 2018/6/26 13:12, Yunlei He wrote:
>> Now, we depend on fsck to ensure quota file data is ok,
>> so we scan whole partition if checkpoint without umount
>> flag. It's same for quota off error case, which may make
>> quota file data inconsistent.
>>
>> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> 
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> 
> Thanks,
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> 
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH v3] f2fs: report error if quota off error during umount

[Jaegeuk Kim]

On 07/28, Chao Yu wrote:
> Ping,

Please check dev-test.

> 
> On 2018/6/26 16:34, Chao Yu wrote:
> > On 2018/6/26 13:12, Yunlei He wrote:
> >> Now, we depend on fsck to ensure quota file data is ok,
> >> so we scan whole partition if checkpoint without umount
> >> flag. It's same for quota off error case, which may make
> >> quota file data inconsistent.
> >>
> >> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> > 
> > Reviewed-by: Chao Yu <yuchao0@huawei.com>
> > 
> > Thanks,
> > 
> > 
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> > 
> > 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH v3] f2fs: report error if quota off error during umount

[Chao Yu]

On 2018/7/29 10:06, Jaegeuk Kim wrote:
> On 07/28, Chao Yu wrote:
>> Ping,
> 
> Please check dev-test.

I still can't find this patch in last dev-test...

Thanks,

> 
>>
>> On 2018/6/26 16:34, Chao Yu wrote:
>>> On 2018/6/26 13:12, Yunlei He wrote:
>>>> Now, we depend on fsck to ensure quota file data is ok,
>>>> so we scan whole partition if checkpoint without umount
>>>> flag. It's same for quota off error case, which may make
>>>> quota file data inconsistent.
>>>>
>>>> Signed-off-by: Yunlei He <heyunlei@huawei.com>
>>>
>>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>>>
>>> Thanks,
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> Linux-f2fs-devel mailing list
>>> Linux-f2fs-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
>>>
>>>
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH v3] f2fs: report error if quota off error during umount

[Jaegeuk Kim]

On 07/29, Chao Yu wrote:
> On 2018/7/29 10:06, Jaegeuk Kim wrote:
> > On 07/28, Chao Yu wrote:
> >> Ping,
> > 
> > Please check dev-test.
> 
> I still can't find this patch in last dev-test...

Oh, I recalled what happened on this patch. I didn't merge this, since fault
injection test was failed due to this.
Let me check, once everyting is stabilized.

Thanks,

> 
> Thanks,
> 
> > 
> >>
> >> On 2018/6/26 16:34, Chao Yu wrote:
> >>> On 2018/6/26 13:12, Yunlei He wrote:
> >>>> Now, we depend on fsck to ensure quota file data is ok,
> >>>> so we scan whole partition if checkpoint without umount
> >>>> flag. It's same for quota off error case, which may make
> >>>> quota file data inconsistent.
> >>>>
> >>>> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> >>>
> >>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> >>>
> >>> Thanks,
> >>>
> >>>
> >>> ------------------------------------------------------------------------------
> >>> Check out the vibrant tech community on one of the world's most
> >>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >>> _______________________________________________
> >>> Linux-f2fs-devel mailing list
> >>> Linux-f2fs-devel@lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> >>>
> >>>
> > 
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > Linux-f2fs-devel mailing list
> > Linux-f2fs-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> > 

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot