Re: autoip address set/reset loop

[Geoffrey Van Landeghem <geoffrey.vl@gmail.com>]

Subject: Re: autoip address set/reset loop


Hi Daniel,


Well, as said it autoip (APIPA) was not working because of this because it seems to not have assigned any gateway at this stage. This get's assigned in the __connman_connection_gateway_add() function which is called after this DBG(...):

if (!ipconfig->address)
        return -EINVAL;

    service = __connman_service_lookup_from_index(ipconfig->index);
    if (!service)
        return -EINVAL;

    /*
     * Gateway is allowed to be NULL here, see
     * __connman_connection_gateway_add()
     */
    DBG("type %d gw %s peer %s", ipconfig->type,
        ipconfig->address->gateway ? ipconfig->address->gateway : "NULL",
        ipconfig->address->peer ? ipconfig->address->peer : "NULL");

    if (ipconfig->type == CONNMAN_IPCONFIG_TYPE_IPV6 ||
                ipconfig->type == CONNMAN_IPCONFIG_TYPE_IPV4)
        return __connman_connection_gateway_add(service,
                        ipconfig->address->gateway,
                        ipconfig->type,
                        ipconfig->address->peer);

In that __connman_connection_gateway_add() function the null gateway is assigned 0.0.0.0, so your commit was effectively blocking that.