All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoffrey Van Landeghem <geoffrey.vl@gmail.com>
To: geoffrey.vl@gmail.com
Cc: connman@lists.linux.dev, wagi@monom.org
Subject: Re: autoip address set/reset loop
Date: Tue, 22 Nov 2022 19:35:42 +0100	[thread overview]
Message-ID: <2ec046cc-aefc-2a6a-3f1c-5a08c447fd76@gmail.com> (raw)
In-Reply-To: <dda7ee12-1176-6eaf-4f84-a599bfbadee8@gmail.com>

Subject: Re: autoip address set/reset loop


After adding some extra logs I could trace that the issue is due to an error in __connman_ipconfig_gateway_add:

network.c:dhcp_success() lease acquired for ipconfig 0x1a300b0
inet.c:connman_inet_set_address() index 3 address 169.254.5.120 prefix_len 16
inet.c:__connman_inet_modify_address() cmd 0x14 flags 0x104 index 3 family 2 address 169.254.5.120 peer (null) prefixlen 16 broadcast (null) p2p false
ipconfig.c:__connman_ipconfig_gateway_add()
ipconfig.c:__connman_ipconfig_gateway_add() ipconfig->address->gateway NULL
network.c:connman_network_set_error() network 0x1a26080 error 2

There was an extra check introduced there recently which is blocking the function from returning successfully and therefor results in that __connman_connection_gateway_add() is not called either (which should add the '0.0.0.0' gateway).

@Daniel, should your patch be reverted (and maybe accompanied with an extra comment explaining why there is no NULL check for the gateway), or do we somehow assign the 0.0.0.0 somewhere earlier in the process?


  reply	other threads:[~2022-11-22 18:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 10:55 autoip address set/reset loop Geoffrey Van Landeghem
2022-11-22 18:35 ` Geoffrey Van Landeghem [this message]
2022-11-23 14:56 Geoffrey Van Landeghem
2022-11-23 15:10 ` John Keeping
2022-11-23 16:46 ` Daniel Wagner
2022-11-23 16:03 Geoffrey Van Landeghem
2022-11-23 17:12 Geoffrey Van Landeghem
2022-11-23 17:36 ` Daniel Wagner
2022-11-23 18:27   ` Geoffrey Van Landeghem
2022-11-24 11:45     ` Daniel Wagner
2022-11-24 16:34       ` Geoffrey Van Landeghem
2022-11-24 17:30         ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ec046cc-aefc-2a6a-3f1c-5a08c447fd76@gmail.com \
    --to=geoffrey.vl@gmail.com \
    --cc=connman@lists.linux.dev \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.