All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Wang <sean.wang@mediatek.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [dts] [v2] fix green/blue pio-led on bananapi-r2
Date: Wed, 27 Jun 2018 13:54:18 +0800	[thread overview]
Message-ID: <1530078858.29697.32.camel@mtkswgap22> (raw)
In-Reply-To: <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>

On Mon, 2018-06-25 at 12:05 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Mon, 25 Jun 2018 11:57:13 +0200
> Subject: [PATCH] [dts] [v2] fix green/blue pio-led
>  pio-leds (near GPIO-Header) are swapped and LOW-active 
>  patch restore this expected behaviour
>  red cannot be switched afaik
> 
> v2: alphabetic order
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 531d905d924ff..2b760f90f38c8 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -91,19 +91,19 @@
>  
>  		blue {
>  			label = "bpi-r2:pio:blue";
> -			gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 240 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		green {
>  			label = "bpi-r2:pio:green";
> -			gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 241 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		red {
>  			label = "bpi-r2:pio:red";
> -			gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 239 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  	};
> 
>  

Reviewed-by: Sean Wang <sean.wang@mediatek.com>

WARNING: multiple messages have this Message-ID (diff)
From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [dts] [v2] fix green/blue pio-led on bananapi-r2
Date: Wed, 27 Jun 2018 13:54:18 +0800	[thread overview]
Message-ID: <1530078858.29697.32.camel@mtkswgap22> (raw)
In-Reply-To: <trinity-28694d63-092a-48be-aade-ba680b5c4e70-1529921159405@3c-app-gmx-bs16>

On Mon, 2018-06-25 at 12:05 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Mon, 25 Jun 2018 11:57:13 +0200
> Subject: [PATCH] [dts] [v2] fix green/blue pio-led
>  pio-leds (near GPIO-Header) are swapped and LOW-active 
>  patch restore this expected behaviour
>  red cannot be switched afaik
> 
> v2: alphabetic order
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 531d905d924ff..2b760f90f38c8 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -91,19 +91,19 @@
>  
>  		blue {
>  			label = "bpi-r2:pio:blue";
> -			gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 240 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		green {
>  			label = "bpi-r2:pio:green";
> -			gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 241 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  
>  		red {
>  			label = "bpi-r2:pio:red";
> -			gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
> +			gpios = <&pio 239 GPIO_ACTIVE_LOW>;
>  			default-state = "off";
>  		};
>  	};
> 
>  

Reviewed-by: Sean Wang <sean.wang@mediatek.com>

  reply	other threads:[~2018-06-27  5:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <trinity-ae29ad25-a4fb-47f3-8d68-f6e58c875a0e-1529682447976@3c-app-gmx-bs42>
2018-06-22 15:53 ` [PATCH] [dts] fix green/blue pio-led on bananapi-r2 Frank Wunderlich
2018-06-22 15:53   ` Frank Wunderlich
2018-06-25  9:17   ` Sean Wang
2018-06-25  9:17     ` Sean Wang
2018-06-25 10:05     ` [dts] [v2] " Frank Wunderlich
2018-06-27  5:54       ` Sean Wang [this message]
2018-06-27  5:54         ` Sean Wang
2018-07-16  9:16       ` Matthias Brugger
2018-07-16  9:16         ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530078858.29697.32.camel@mtkswgap22 \
    --to=sean.wang@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frank-w@public-files.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.