All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
@ 2018-06-27 17:50 ` thor.thayer at linux.intel.com
  0 siblings, 0 replies; 8+ messages in thread
From: thor.thayer @ 2018-06-27 17:50 UTC (permalink / raw)
  To: dinguyen
  Cc: mark.rutland, devicetree, Thor Thayer, catalin.marinas,
	will.deacon, robh+dt, linux-arm-kernel

From: Thor Thayer <thor.thayer@linux.intel.com>

Add the required clocks for the new Stratix10 clock bindings
to the SPI nodes.

Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 67dac595dc72..9e54282ee08c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -310,6 +310,7 @@
 			resets = <&rst SPIM0_RESET>;
 			reg-io-width = <4>;
 			num-cs = <4>;
+			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
 			status = "disabled";
 		};
 
@@ -322,6 +323,7 @@
 			resets = <&rst SPIM1_RESET>;
 			reg-io-width = <4>;
 			num-cs = <4>;
+			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
 			status = "disabled";
 		};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
@ 2018-06-27 17:50 ` thor.thayer at linux.intel.com
  0 siblings, 0 replies; 8+ messages in thread
From: thor.thayer at linux.intel.com @ 2018-06-27 17:50 UTC (permalink / raw)
  To: linux-arm-kernel

From: Thor Thayer <thor.thayer@linux.intel.com>

Add the required clocks for the new Stratix10 clock bindings
to the SPI nodes.

Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
index 67dac595dc72..9e54282ee08c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
@@ -310,6 +310,7 @@
 			resets = <&rst SPIM0_RESET>;
 			reg-io-width = <4>;
 			num-cs = <4>;
+			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
 			status = "disabled";
 		};
 
@@ -322,6 +323,7 @@
 			resets = <&rst SPIM1_RESET>;
 			reg-io-width = <4>;
 			num-cs = <4>;
+			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
 			status = "disabled";
 		};
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
  2018-06-27 17:50 ` thor.thayer at linux.intel.com
@ 2018-06-28 19:37   ` Dinh Nguyen
  -1 siblings, 0 replies; 8+ messages in thread
From: Dinh Nguyen @ 2018-06-28 19:37 UTC (permalink / raw)
  To: thor.thayer
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon, robh+dt,
	linux-arm-kernel

Hi Thor

On 06/27/2018 12:50 PM, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
> 
> Add the required clocks for the new Stratix10 clock bindings
> to the SPI nodes.
> 
> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> index 67dac595dc72..9e54282ee08c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> @@ -310,6 +310,7 @@
>  			resets = <&rst SPIM0_RESET>;
>  			reg-io-width = <4>;
>  			num-cs = <4>;
> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>  			status = "disabled";
>  		};
>  
> @@ -322,6 +323,7 @@
>  			resets = <&rst SPIM1_RESET>;
>  			reg-io-width = <4>;
>  			num-cs = <4>;
> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>  			status = "disabled";
>  		};
>  
> 

I thought you already sent a patch for this?

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html

Dinh

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
@ 2018-06-28 19:37   ` Dinh Nguyen
  0 siblings, 0 replies; 8+ messages in thread
From: Dinh Nguyen @ 2018-06-28 19:37 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Thor

On 06/27/2018 12:50 PM, thor.thayer at linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
> 
> Add the required clocks for the new Stratix10 clock bindings
> to the SPI nodes.
> 
> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> index 67dac595dc72..9e54282ee08c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
> @@ -310,6 +310,7 @@
>  			resets = <&rst SPIM0_RESET>;
>  			reg-io-width = <4>;
>  			num-cs = <4>;
> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>  			status = "disabled";
>  		};
>  
> @@ -322,6 +323,7 @@
>  			resets = <&rst SPIM1_RESET>;
>  			reg-io-width = <4>;
>  			num-cs = <4>;
> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>  			status = "disabled";
>  		};
>  
> 

I thought you already sent a patch for this?

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html

Dinh

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
  2018-06-28 19:37   ` Dinh Nguyen
@ 2018-06-28 20:23     ` Thor Thayer
  -1 siblings, 0 replies; 8+ messages in thread
From: Thor Thayer @ 2018-06-28 20:23 UTC (permalink / raw)
  To: Dinh Nguyen
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon, robh+dt,
	linux-arm-kernel

Hi Dinh,

On 06/28/2018 02:37 PM, Dinh Nguyen wrote:
> Hi Thor
> 
> On 06/27/2018 12:50 PM, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add the required clocks for the new Stratix10 clock bindings
>> to the SPI nodes.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>>   arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> index 67dac595dc72..9e54282ee08c 100644
>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> @@ -310,6 +310,7 @@
>>   			resets = <&rst SPIM0_RESET>;
>>   			reg-io-width = <4>;
>>   			num-cs = <4>;
>> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>   			status = "disabled";
>>   		};
>>   
>> @@ -322,6 +323,7 @@
>>   			resets = <&rst SPIM1_RESET>;
>>   			reg-io-width = <4>;
>>   			num-cs = <4>;
>> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>   			status = "disabled";
>>   		};
>>   
>>
> 
> I thought you already sent a patch for this?
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html
> 
> Dinh
> 
Good catch. I didn't see the clock addition in the

dinh_linux_for_next/socfpga_for_next_v4.19_fixes_v1
dinh_linux_for_next/socfpga_for_next_v4.19_dts_v1

branches so I assumed it hadn't been applied (since the num-cs change 
from the patchset is there).

This is a simpler patch since the STRATIX10_SPI_M_CLK isn't needed.

Thanks,

Thor

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
@ 2018-06-28 20:23     ` Thor Thayer
  0 siblings, 0 replies; 8+ messages in thread
From: Thor Thayer @ 2018-06-28 20:23 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Dinh,

On 06/28/2018 02:37 PM, Dinh Nguyen wrote:
> Hi Thor
> 
> On 06/27/2018 12:50 PM, thor.thayer at linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add the required clocks for the new Stratix10 clock bindings
>> to the SPI nodes.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>>   arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> index 67dac595dc72..9e54282ee08c 100644
>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> @@ -310,6 +310,7 @@
>>   			resets = <&rst SPIM0_RESET>;
>>   			reg-io-width = <4>;
>>   			num-cs = <4>;
>> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>   			status = "disabled";
>>   		};
>>   
>> @@ -322,6 +323,7 @@
>>   			resets = <&rst SPIM1_RESET>;
>>   			reg-io-width = <4>;
>>   			num-cs = <4>;
>> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>   			status = "disabled";
>>   		};
>>   
>>
> 
> I thought you already sent a patch for this?
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html
> 
> Dinh
> 
Good catch. I didn't see the clock addition in the

dinh_linux_for_next/socfpga_for_next_v4.19_fixes_v1
dinh_linux_for_next/socfpga_for_next_v4.19_dts_v1

branches so I assumed it hadn't been applied (since the num-cs change 
from the patchset is there).

This is a simpler patch since the STRATIX10_SPI_M_CLK isn't needed.

Thanks,

Thor

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
  2018-06-28 20:23     ` Thor Thayer
@ 2018-06-29 14:27       ` Dinh Nguyen
  -1 siblings, 0 replies; 8+ messages in thread
From: Dinh Nguyen @ 2018-06-29 14:27 UTC (permalink / raw)
  To: thor.thayer
  Cc: mark.rutland, devicetree, catalin.marinas, will.deacon, robh+dt,
	linux-arm-kernel



On 06/28/2018 03:23 PM, Thor Thayer wrote:
> Hi Dinh,
> 
> On 06/28/2018 02:37 PM, Dinh Nguyen wrote:
>> Hi Thor
>>
>> On 06/27/2018 12:50 PM, thor.thayer@linux.intel.com wrote:
>>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>>
>>> Add the required clocks for the new Stratix10 clock bindings
>>> to the SPI nodes.
>>>
>>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>>> ---
>>>   arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> index 67dac595dc72..9e54282ee08c 100644
>>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> @@ -310,6 +310,7 @@
>>>               resets = <&rst SPIM0_RESET>;
>>>               reg-io-width = <4>;
>>>               num-cs = <4>;
>>> +            clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>>               status = "disabled";
>>>           };
>>>   @@ -322,6 +323,7 @@
>>>               resets = <&rst SPIM1_RESET>;
>>>               reg-io-width = <4>;
>>>               num-cs = <4>;
>>> +            clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>>               status = "disabled";
>>>           };
>>>  
>>
>> I thought you already sent a patch for this?
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html
>>
>>
>> Dinh
>>
> Good catch. I didn't see the clock addition in the
> 
> dinh_linux_for_next/socfpga_for_next_v4.19_fixes_v1
> dinh_linux_for_next/socfpga_for_next_v4.19_dts_v1
> 
> branches so I assumed it hadn't been applied (since the num-cs change
> from the patchset is there).
> 
> This is a simpler patch since the STRATIX10_SPI_M_CLK isn't needed.
> 

Ok...will apply this patch.

Dinh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
@ 2018-06-29 14:27       ` Dinh Nguyen
  0 siblings, 0 replies; 8+ messages in thread
From: Dinh Nguyen @ 2018-06-29 14:27 UTC (permalink / raw)
  To: linux-arm-kernel



On 06/28/2018 03:23 PM, Thor Thayer wrote:
> Hi Dinh,
> 
> On 06/28/2018 02:37 PM, Dinh Nguyen wrote:
>> Hi Thor
>>
>> On 06/27/2018 12:50 PM, thor.thayer at linux.intel.com wrote:
>>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>>
>>> Add the required clocks for the new Stratix10 clock bindings
>>> to the SPI nodes.
>>>
>>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>>> ---
>>> ? arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>>> ? 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> index 67dac595dc72..9e54282ee08c 100644
>>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>>> @@ -310,6 +310,7 @@
>>> ????????????? resets = <&rst SPIM0_RESET>;
>>> ????????????? reg-io-width = <4>;
>>> ????????????? num-cs = <4>;
>>> +??????????? clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>> ????????????? status = "disabled";
>>> ????????? };
>>> ? @@ -322,6 +323,7 @@
>>> ????????????? resets = <&rst SPIM1_RESET>;
>>> ????????????? reg-io-width = <4>;
>>> ????????????? num-cs = <4>;
>>> +??????????? clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>> ????????????? status = "disabled";
>>> ????????? };
>>> ?
>>
>> I thought you already sent a patch for this?
>>
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html
>>
>>
>> Dinh
>>
> Good catch. I didn't see the clock addition in the
> 
> dinh_linux_for_next/socfpga_for_next_v4.19_fixes_v1
> dinh_linux_for_next/socfpga_for_next_v4.19_dts_v1
> 
> branches so I assumed it hadn't been applied (since the num-cs change
> from the patchset is there).
> 
> This is a simpler patch since the STRATIX10_SPI_M_CLK isn't needed.
> 

Ok...will apply this patch.

Dinh

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-06-29 14:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 17:50 [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10 thor.thayer
2018-06-27 17:50 ` thor.thayer at linux.intel.com
2018-06-28 19:37 ` Dinh Nguyen
2018-06-28 19:37   ` Dinh Nguyen
2018-06-28 20:23   ` Thor Thayer
2018-06-28 20:23     ` Thor Thayer
2018-06-29 14:27     ` Dinh Nguyen
2018-06-29 14:27       ` Dinh Nguyen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.