* [U-Boot] [PATCH] arm,imx6: add alternative PAD_CTL_DSE constants
@ 2018-06-27 10:21 Mark Jonas
2018-06-27 23:47 ` [U-Boot] [PATCH] arm, imx6: " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mark Jonas @ 2018-06-27 10:21 UTC (permalink / raw)
To: u-boot
Not all i.MX6 pads use the same drive strength table. So far only the
240 Ohm to 34 Ohm table was available. Because the constants used have
speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
according to the reference manual 52 Ohm is the correct value. This
patch adds the 260 Ohm to 37 Ohm table.
For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
uses the added table.
---
arch/arm/include/asm/mach-imx/iomux-v3.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
index bb93058..63f4b33 100644
--- a/arch/arm/include/asm/mach-imx/iomux-v3.h
+++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
@@ -163,6 +163,14 @@ typedef u64 iomux_v3_cfg_t;
#define PAD_CTL_DSE_40ohm (6 << 3)
#define PAD_CTL_DSE_34ohm (7 << 3)
+#define PAD_CTL_DSE_260ohm (1 << 3)
+#define PAD_CTL_DSE_130ohm (2 << 3)
+#define PAD_CTL_DSE_88ohm (3 << 3)
+#define PAD_CTL_DSE_65ohm (4 << 3)
+#define PAD_CTL_DSE_52ohm (5 << 3)
+#define PAD_CTL_DSE_43ohm (6 << 3)
+#define PAD_CTL_DSE_37ohm (7 << 3)
+
/* i.MX6SL/SLL */
#define PAD_CTL_LVE (1 << 1)
#define PAD_CTL_LVE_BIT (1 << 22)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] arm, imx6: add alternative PAD_CTL_DSE constants
2018-06-27 10:21 [U-Boot] [PATCH] arm,imx6: add alternative PAD_CTL_DSE constants Mark Jonas
@ 2018-06-27 23:47 ` Fabio Estevam
2018-06-28 8:07 ` [U-Boot] [PATCH v2] " Mark Jonas
2018-06-28 13:56 ` [U-Boot] [PATCH v3] " Mark Jonas
2 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-06-27 23:47 UTC (permalink / raw)
To: u-boot
Hi Mark,
On Wed, Jun 27, 2018 at 7:21 AM, Mark Jonas <mark.jonas@de.bosch.com> wrote:
> Not all i.MX6 pads use the same drive strength table. So far only the
> 240 Ohm to 34 Ohm table was available. Because the constants used have
> speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
> according to the reference manual 52 Ohm is the correct value. This
> patch adds the 260 Ohm to 37 Ohm table.
>
> For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
> uses the added table.
The change looks good, but you missed your Signed-off-by tag.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] arm, imx6: add alternative PAD_CTL_DSE constants
2018-06-27 10:21 [U-Boot] [PATCH] arm,imx6: add alternative PAD_CTL_DSE constants Mark Jonas
2018-06-27 23:47 ` [U-Boot] [PATCH] arm, imx6: " Fabio Estevam
@ 2018-06-28 8:07 ` Mark Jonas
2018-06-28 8:15 ` Stefano Babic
2018-06-28 13:56 ` [U-Boot] [PATCH v3] " Mark Jonas
2 siblings, 1 reply; 6+ messages in thread
From: Mark Jonas @ 2018-06-28 8:07 UTC (permalink / raw)
To: u-boot
Not all i.MX6 pads use the same drive strength table. So far only the
240 Ohm to 34 Ohm table was available. Because the constants used have
speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
according to the reference manual 52 Ohm is the correct value. This
patch adds the 260 Ohm to 37 Ohm table.
For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
uses the added table.
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
Changes in V2:
- Add missing Signed-off-by
---
arch/arm/include/asm/mach-imx/iomux-v3.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
index bb93058..63f4b33 100644
--- a/arch/arm/include/asm/mach-imx/iomux-v3.h
+++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
@@ -163,6 +163,14 @@ typedef u64 iomux_v3_cfg_t;
#define PAD_CTL_DSE_40ohm (6 << 3)
#define PAD_CTL_DSE_34ohm (7 << 3)
+#define PAD_CTL_DSE_260ohm (1 << 3)
+#define PAD_CTL_DSE_130ohm (2 << 3)
+#define PAD_CTL_DSE_88ohm (3 << 3)
+#define PAD_CTL_DSE_65ohm (4 << 3)
+#define PAD_CTL_DSE_52ohm (5 << 3)
+#define PAD_CTL_DSE_43ohm (6 << 3)
+#define PAD_CTL_DSE_37ohm (7 << 3)
+
/* i.MX6SL/SLL */
#define PAD_CTL_LVE (1 << 1)
#define PAD_CTL_LVE_BIT (1 << 22)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v2] arm, imx6: add alternative PAD_CTL_DSE constants
2018-06-28 8:07 ` [U-Boot] [PATCH v2] " Mark Jonas
@ 2018-06-28 8:15 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2018-06-28 8:15 UTC (permalink / raw)
To: u-boot
Hi Mark,
On 28/06/2018 10:07, Mark Jonas wrote:
> Not all i.MX6 pads use the same drive strength table. So far only the
> 240 Ohm to 34 Ohm table was available. Because the constants used have
> speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
> according to the reference manual 52 Ohm is the correct value. This
> patch adds the 260 Ohm to 37 Ohm table.
>
> For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
> uses the added table.
>
> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
> ---
> Changes in V2:
> - Add missing Signed-off-by
> ---
> arch/arm/include/asm/mach-imx/iomux-v3.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
> index bb93058..63f4b33 100644
> --- a/arch/arm/include/asm/mach-imx/iomux-v3.h
> +++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
> @@ -163,6 +163,14 @@ typedef u64 iomux_v3_cfg_t;
> #define PAD_CTL_DSE_40ohm (6 << 3)
> #define PAD_CTL_DSE_34ohm (7 << 3)
>
> +#define PAD_CTL_DSE_260ohm (1 << 3)
> +#define PAD_CTL_DSE_130ohm (2 << 3)
> +#define PAD_CTL_DSE_88ohm (3 << 3)
> +#define PAD_CTL_DSE_65ohm (4 << 3)
> +#define PAD_CTL_DSE_52ohm (5 << 3)
> +#define PAD_CTL_DSE_43ohm (6 << 3)
> +#define PAD_CTL_DSE_37ohm (7 << 3)
> +
> /* i.MX6SL/SLL */
> #define PAD_CTL_LVE (1 << 1)
> #define PAD_CTL_LVE_BIT (1 << 22)
>
Reviewed-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3] arm, imx6: add alternative PAD_CTL_DSE constants
2018-06-27 10:21 [U-Boot] [PATCH] arm,imx6: add alternative PAD_CTL_DSE constants Mark Jonas
2018-06-27 23:47 ` [U-Boot] [PATCH] arm, imx6: " Fabio Estevam
2018-06-28 8:07 ` [U-Boot] [PATCH v2] " Mark Jonas
@ 2018-06-28 13:56 ` Mark Jonas
2018-07-23 9:28 ` Stefano Babic
2 siblings, 1 reply; 6+ messages in thread
From: Mark Jonas @ 2018-06-28 13:56 UTC (permalink / raw)
To: u-boot
Not all i.MX6 pads use the same drive strength table. So far only the
240 Ohm to 34 Ohm table was available. Because the constants used have
speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
according to the reference manual 52 Ohm is the correct value. This
patch adds the 260 Ohm to 37 Ohm table.
For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
uses the added table.
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
Reviewed-by: Stefano Babic <sbabic@denx.de>
---
Changes in V3:
- Reviewed by Stefano Babic
Changes in V2:
- Add missing Signed-off-by
---
arch/arm/include/asm/mach-imx/iomux-v3.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
index bb93058..63f4b33 100644
--- a/arch/arm/include/asm/mach-imx/iomux-v3.h
+++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
@@ -163,6 +163,14 @@ typedef u64 iomux_v3_cfg_t;
#define PAD_CTL_DSE_40ohm (6 << 3)
#define PAD_CTL_DSE_34ohm (7 << 3)
+#define PAD_CTL_DSE_260ohm (1 << 3)
+#define PAD_CTL_DSE_130ohm (2 << 3)
+#define PAD_CTL_DSE_88ohm (3 << 3)
+#define PAD_CTL_DSE_65ohm (4 << 3)
+#define PAD_CTL_DSE_52ohm (5 << 3)
+#define PAD_CTL_DSE_43ohm (6 << 3)
+#define PAD_CTL_DSE_37ohm (7 << 3)
+
/* i.MX6SL/SLL */
#define PAD_CTL_LVE (1 << 1)
#define PAD_CTL_LVE_BIT (1 << 22)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH v3] arm, imx6: add alternative PAD_CTL_DSE constants
2018-06-28 13:56 ` [U-Boot] [PATCH v3] " Mark Jonas
@ 2018-07-23 9:28 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2018-07-23 9:28 UTC (permalink / raw)
To: u-boot
On 28/06/2018 15:56, Mark Jonas wrote:
> Not all i.MX6 pads use the same drive strength table. So far only the
> 240 Ohm to 34 Ohm table was available. Because the constants used have
> speaking names it can be confusing to use e.g. PAD_CTL_DSE_48ohm when
> according to the reference manual 52 Ohm is the correct value. This
> patch adds the 260 Ohm to 37 Ohm table.
>
> For example, the IOMUXC_SW_PAD_CTL_PAD_SD2_CLK register (SD-card clock)
> uses the added table.
>
> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
> Reviewed-by: Stefano Babic <sbabic@denx.de>
> ---
> Changes in V3:
> - Reviewed by Stefano Babic
>
> Changes in V2:
> - Add missing Signed-off-by
> ---
> arch/arm/include/asm/mach-imx/iomux-v3.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
> index bb93058..63f4b33 100644
> --- a/arch/arm/include/asm/mach-imx/iomux-v3.h
> +++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
> @@ -163,6 +163,14 @@ typedef u64 iomux_v3_cfg_t;
> #define PAD_CTL_DSE_40ohm (6 << 3)
> #define PAD_CTL_DSE_34ohm (7 << 3)
>
> +#define PAD_CTL_DSE_260ohm (1 << 3)
> +#define PAD_CTL_DSE_130ohm (2 << 3)
> +#define PAD_CTL_DSE_88ohm (3 << 3)
> +#define PAD_CTL_DSE_65ohm (4 << 3)
> +#define PAD_CTL_DSE_52ohm (5 << 3)
> +#define PAD_CTL_DSE_43ohm (6 << 3)
> +#define PAD_CTL_DSE_37ohm (7 << 3)
> +
> /* i.MX6SL/SLL */
> #define PAD_CTL_LVE (1 << 1)
> #define PAD_CTL_LVE_BIT (1 << 22)
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-23 9:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 10:21 [U-Boot] [PATCH] arm,imx6: add alternative PAD_CTL_DSE constants Mark Jonas
2018-06-27 23:47 ` [U-Boot] [PATCH] arm, imx6: " Fabio Estevam
2018-06-28 8:07 ` [U-Boot] [PATCH v2] " Mark Jonas
2018-06-28 8:15 ` Stefano Babic
2018-06-28 13:56 ` [U-Boot] [PATCH v3] " Mark Jonas
2018-07-23 9:28 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.