* [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion
@ 2018-06-28 22:56 ` Nick Dyer
0 siblings, 0 replies; 7+ messages in thread
From: Nick Dyer @ 2018-06-28 22:56 UTC (permalink / raw)
To: linux-arm-kernel
The RMI4 touchscreen driver applied inversion and axis swap in the
wrong order, violating the DT binding for those properties. This was fixed in
645a397, so correct the RDU1 DT to apply the inversion to the
correct axis.
Tested on Zii RDU1 00-5105-30 rev B
Signed-off-by: Nick Dyer <nick@shmanahar.org>
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index 68f5c1d5ecd0..b1d83fb08150 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -553,7 +553,7 @@
rmi4-f11 at 11 {
reg = <0x11>;
- touchscreen-inverted-y;
+ touchscreen-inverted-x;
touchscreen-swapped-x-y;
syna,sensor-type = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion
@ 2018-06-28 22:56 ` Nick Dyer
0 siblings, 0 replies; 7+ messages in thread
From: Nick Dyer @ 2018-06-28 22:56 UTC (permalink / raw)
To: Shawn Guo
Cc: Nikita Yushchenko, devicetree, Nick Dyer, Andrey Smirnov,
Sascha Hauer, linux-kernel, Chris Healy, Fabio Estevam,
linux-arm-kernel, Lucas Stach
The RMI4 touchscreen driver applied inversion and axis swap in the
wrong order, violating the DT binding for those properties. This was fixed in
645a397, so correct the RDU1 DT to apply the inversion to the
correct axis.
Tested on Zii RDU1 00-5105-30 rev B
Signed-off-by: Nick Dyer <nick@shmanahar.org>
---
arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
index 68f5c1d5ecd0..b1d83fb08150 100644
--- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
+++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
@@ -553,7 +553,7 @@
rmi4-f11@11 {
reg = <0x11>;
- touchscreen-inverted-y;
+ touchscreen-inverted-x;
touchscreen-swapped-x-y;
syna,sensor-type = <1>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion
2018-06-28 22:56 ` Nick Dyer
@ 2018-06-29 8:55 ` Lucas Stach
-1 siblings, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-06-29 8:55 UTC (permalink / raw)
To: Nick Dyer, Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, linux-kernel, devicetree,
Fabio Estevam, Andrey Smirnov, Nikita Yushchenko, Chris Healy
Am Donnerstag, den 28.06.2018, 23:56 +0100 schrieb Nick Dyer:
> The RMI4 touchscreen driver applied inversion and axis swap in the
> wrong order, violating the DT binding for those properties. This was fixed in
> 645a397, so correct the RDU1 DT to apply the inversion to the
> correct axis.
>
> Tested on Zii RDU1 00-5105-30 rev B
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index 68f5c1d5ecd0..b1d83fb08150 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -553,7 +553,7 @@
>
> > rmi4-f11@11 {
> > reg = <0x11>;
> > - touchscreen-inverted-y;
> > + touchscreen-inverted-x;
> > touchscreen-swapped-x-y;
> > syna,sensor-type = <1>;
> > };
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion
@ 2018-06-29 8:55 ` Lucas Stach
0 siblings, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-06-29 8:55 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, den 28.06.2018, 23:56 +0100 schrieb Nick Dyer:
> The RMI4 touchscreen driver applied inversion and axis swap in the
> wrong order, violating the DT binding for those properties. This was fixed in
> 645a397, so correct the RDU1 DT to apply the inversion to the
> correct axis.
>
> Tested on Zii RDU1 00-5105-30 rev B
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> ?arch/arm/boot/dts/imx51-zii-rdu1.dts | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index 68f5c1d5ecd0..b1d83fb08150 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -553,7 +553,7 @@
> ?
> > ? rmi4-f11 at 11 {
> > ? reg = <0x11>;
> > - touchscreen-inverted-y;
> > + touchscreen-inverted-x;
> > ? touchscreen-swapped-x-y;
> > ? syna,sensor-type = <1>;
> > ? };
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion
2018-06-28 22:56 ` Nick Dyer
@ 2018-07-03 6:12 ` Shawn Guo
-1 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-07-03 6:12 UTC (permalink / raw)
To: Nick Dyer
Cc: Nikita Yushchenko, devicetree, Andrey Smirnov, Sascha Hauer,
linux-kernel, Chris Healy, Fabio Estevam, linux-arm-kernel,
Lucas Stach
On Thu, Jun 28, 2018 at 11:56:26PM +0100, Nick Dyer wrote:
> The RMI4 touchscreen driver applied inversion and axis swap in the
> wrong order, violating the DT binding for those properties. This was fixed in
> 645a397, so correct the RDU1 DT to apply the inversion to the
> correct axis.
>
> Tested on Zii RDU1 00-5105-30 rev B
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1] ARM: dts: imx51-zii-rdu1: correct touchscreen axis inversion
@ 2018-07-03 6:12 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-07-03 6:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 28, 2018 at 11:56:26PM +0100, Nick Dyer wrote:
> The RMI4 touchscreen driver applied inversion and axis swap in the
> wrong order, violating the DT binding for those properties. This was fixed in
> 645a397, so correct the RDU1 DT to apply the inversion to the
> correct axis.
>
> Tested on Zii RDU1 00-5105-30 rev B
>
> Signed-off-by: Nick Dyer <nick@shmanahar.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread