* [PATCH] nvme-cli: print firmware activation notices support bit to id_ctrl
@ 2018-07-01 13:58 Minwoo Im
2018-07-02 16:41 ` Keith Busch
0 siblings, 1 reply; 2+ messages in thread
From: Minwoo Im @ 2018-07-01 13:58 UTC (permalink / raw)
It's now currently printing the OAES(Optional Asynchronous Events Supported)
field in identify controller data structure without [9] firmware activation
notices field in case of human-readable format.
Print it out by updating the reserved bit field.
Signed-off-by: Minwoo Im <minwoo.im.dev at gmail.com>
---
nvme-print.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/nvme-print.c b/nvme-print.c
index 20c2458..daf2929 100644
--- a/nvme-print.c
+++ b/nvme-print.c
@@ -94,12 +94,15 @@ static void show_nvme_id_ctrl_cmic(__u8 cmic)
static void show_nvme_id_ctrl_oaes(__le32 ctrl_oaes)
{
__u32 oaes = le32_to_cpu(ctrl_oaes);
- __u32 rsvd0 = (oaes & 0xFFFFFE00) >> 9;
+ __u32 rsvd0 = (oaes & 0xFFFFFC00) >> 10;
__u32 nace = (oaes & 0x100) >> 8;
+ __u32 fan = (oaes & 0x200) >> 9;
__u32 rsvd1 = oaes & 0xFF;
if (rsvd0)
- printf(" [31:9] : %#x\tReserved\n", rsvd0);
+ printf(" [31:10] : %#x\tReserved\n", rsvd0);
+ printf(" [9:9] : %#x\tFirmware Activation Notices %sSupported\n",
+ fan, fan ? "" : "Not ");
printf(" [8:8] : %#x\tNamespace Attribute Changed Event %sSupported\n",
nace, nace ? "" : "Not ");
if (rsvd1)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] nvme-cli: print firmware activation notices support bit to id_ctrl
2018-07-01 13:58 [PATCH] nvme-cli: print firmware activation notices support bit to id_ctrl Minwoo Im
@ 2018-07-02 16:41 ` Keith Busch
0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2018-07-02 16:41 UTC (permalink / raw)
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-02 16:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-01 13:58 [PATCH] nvme-cli: print firmware activation notices support bit to id_ctrl Minwoo Im
2018-07-02 16:41 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.