All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
	Peter Oh <peter.oh@bowerswilkins.com>,
	linux-wireless@vger.kernel.org
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>, "Felix Fietkau" <nbd@nbd.name>
Subject: Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ
Date: Wed, 04 Jul 2018 09:12:54 +0200	[thread overview]
Message-ID: <1530688374.3324.1.camel@sipsolutions.net> (raw)
In-Reply-To: <e6812d98-53b4-a593-fc76-69b6e5f7b0fd@candelatech.com>

On Tue, 2018-07-03 at 21:24 -0700, Ben Greear wrote:

> > ath10k appears to not do aggregation in the host, and I guess the data
> > isn't split over multiple queues so the firmware has to determine/buffer
> > it some other way. No idea how that would work.
> 
> This is my current understanding of ath10k..hope it helps.

[snip]

Thanks Ben. I guess we can't really know whether or not it would be
buggy with (QoS-)NDP, but it shouldn't be since all the frames are
expected (by firmware) to go through the same path anyhow and it's
responsible for putting them together into aggregates. And, unlike Intel
firmware/hardware, it can't necessarily assume that one HW queue
consists only of packets allowed for aggregation.

johannes

  reply	other threads:[~2018-07-04  7:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 12:47 [PATCH] mac80211: don't put null-data frames on the normal TXQ Johannes Berg
2018-07-03 14:31 ` Toke Høiland-Jørgensen
2018-07-03 14:32   ` Johannes Berg
2018-07-03 14:36     ` Toke Høiland-Jørgensen
2018-07-03 20:40 ` Peter Oh
2018-07-03 23:48   ` Johannes Berg
2018-07-04  4:24     ` Ben Greear
2018-07-04  7:12       ` Johannes Berg [this message]
2018-07-04  7:26     ` Toke Høiland-Jørgensen
2018-07-04  7:54       ` Johannes Berg
2018-07-04  8:25         ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530688374.3324.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=peter.oh@bowerswilkins.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.