All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Peter Oh" <peter.oh@bowerswilkins.com>,
	linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] mac80211: don't put null-data frames on the normal TXQ
Date: Wed, 04 Jul 2018 09:54:16 +0200	[thread overview]
Message-ID: <1530690856.3324.2.camel@sipsolutions.net> (raw)
In-Reply-To: <87zhz7ea1s.fsf@toke.dk>

On Wed, 2018-07-04 at 09:26 +0200, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
> 
> > I see no evidence of ath9k doing this correctly, so this might fix a
> > bug there, but I may have missed it.
> 
> ath9k does check for this, in ath_tx_sched_aggr() and in
> ath_tx_form_aggr(); it'll check for the IEEE80211_TX_CTL_AMPDU flag, and
> stop building the current aggregate if the flag is not set.

Ok, thanks. Nevertheless, I guess it's more efficient to not stop the
aggregate on encountering a (QoS-)NDP :-)

johannes

  reply	other threads:[~2018-07-04  7:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03 12:47 [PATCH] mac80211: don't put null-data frames on the normal TXQ Johannes Berg
2018-07-03 14:31 ` Toke Høiland-Jørgensen
2018-07-03 14:32   ` Johannes Berg
2018-07-03 14:36     ` Toke Høiland-Jørgensen
2018-07-03 20:40 ` Peter Oh
2018-07-03 23:48   ` Johannes Berg
2018-07-04  4:24     ` Ben Greear
2018-07-04  7:12       ` Johannes Berg
2018-07-04  7:26     ` Toke Høiland-Jørgensen
2018-07-04  7:54       ` Johannes Berg [this message]
2018-07-04  8:25         ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530690856.3324.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=peter.oh@bowerswilkins.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.