All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tyler Hicks <tyhicks@canonical.com>
To: John Johansen <john.johansen@canonical.com>
Cc: James Morris <jmorris@namei.org>, Serge Hallyn <serge@hallyn.com>,
	Seth Arnold <seth.arnold@canonical.com>,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] Fix AppArmor issues found through static analysis
Date: Fri,  6 Jul 2018 05:24:59 +0000	[thread overview]
Message-ID: <1530854701-7348-1-git-send-email-tyhicks@canonical.com> (raw)

This set fixes three issues, discovered by CoverityScan, that I don't
believe are serious in practice but are worth fixing to make the
AppArmor code more robust and prevent them from becoming more serious
issues in the future. The first patch fixes possible out of bounds
access issues when mapping a permissions mask to a string. The second
fixes an uninitialized struct that could have some of its contents
leaked to userspace during a permissions query.

I've tested the patches with the AppArmor regression test suite. The
test results are the same with and without these patches applied. There
are identical failures, in both situations, from the aa_policy_cache
test but that's likely due to some unrelated, recent changes in the
AppArmor userspace code.

Tyler


WARNING: multiple messages have this Message-ID (diff)
From: tyhicks@canonical.com (Tyler Hicks)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 0/2] Fix AppArmor issues found through static analysis
Date: Fri,  6 Jul 2018 05:24:59 +0000	[thread overview]
Message-ID: <1530854701-7348-1-git-send-email-tyhicks@canonical.com> (raw)

This set fixes three issues, discovered by CoverityScan, that I don't
believe are serious in practice but are worth fixing to make the
AppArmor code more robust and prevent them from becoming more serious
issues in the future. The first patch fixes possible out of bounds
access issues when mapping a permissions mask to a string. The second
fixes an uninitialized struct that could have some of its contents
leaked to userspace during a permissions query.

I've tested the patches with the AppArmor regression test suite. The
test results are the same with and without these patches applied. There
are identical failures, in both situations, from the aa_policy_cache
test but that's likely due to some unrelated, recent changes in the
AppArmor userspace code.

Tyler

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-07-06  5:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06  5:24 Tyler Hicks [this message]
2018-07-06  5:24 ` [PATCH 0/2] Fix AppArmor issues found through static analysis Tyler Hicks
2018-07-06  5:25 ` [PATCH 1/2] apparmor: Check buffer bounds when mapping permissions mask Tyler Hicks
2018-07-06  5:25   ` Tyler Hicks
2018-07-10 15:00   ` Serge E. Hallyn
2018-07-10 15:00     ` Serge E. Hallyn
2018-07-19 23:28   ` John Johansen
2018-07-19 23:28     ` John Johansen
2018-07-06  5:25 ` [PATCH 2/2] apparmor: Fully initialize aa_perms struct when answering userspace query Tyler Hicks
2018-07-06  5:25   ` Tyler Hicks
2018-07-10 15:03   ` Serge E. Hallyn
2018-07-10 15:03     ` Serge E. Hallyn
2018-07-19 23:28   ` John Johansen
2018-07-19 23:28     ` John Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530854701-7348-1-git-send-email-tyhicks@canonical.com \
    --to=tyhicks@canonical.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=seth.arnold@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.