* [PATCH v2] Revert "staging: mt7621-pinctrl: replace core_initcall_sync with builtin_platform_driver"
@ 2018-07-09 11:28 Sergio Paracuellos
0 siblings, 0 replies; only message in thread
From: Sergio Paracuellos @ 2018-07-09 11:28 UTC (permalink / raw)
To: gregkh; +Cc: neil, driverdev-devel
That patch causes the network interface on the device to stop working.
device_initcall() is called much later than core_initcall_sync() and
that seem to be a problem. Revert it to get a correct behaviour.
Reported-by: NeilBrown <neil@brown.name>
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Changes in v2:
- Add Reported-by to the PATCH.
drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
index c223ecb..b8566ed 100644
--- a/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
+++ b/drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c
@@ -423,4 +423,9 @@ static struct platform_driver rt2880_pinmux_driver = {
},
};
-builtin_platform_driver(rt2880_pinmux_driver);
+int __init rt2880_pinmux_init(void)
+{
+ return platform_driver_register(&rt2880_pinmux_driver);
+}
+
+core_initcall_sync(rt2880_pinmux_init);
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-07-09 11:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-09 11:28 [PATCH v2] Revert "staging: mt7621-pinctrl: replace core_initcall_sync with builtin_platform_driver" Sergio Paracuellos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.