From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v6 2/4] lib/igt_pm: Find HDA device when attempting to enable runtime PM
Date: Tue, 24 Jul 2018 13:27:16 +0100 [thread overview]
Message-ID: <153243523685.11002.15539745648907799152@skylake-alporthouse-com> (raw)
In-Reply-To: <20180724102931.25352-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2018-07-24 11:29:31)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> HDA audio device can be present at various PCI paths on different systems
> which the existing code did not account for.
>
> Furthermore the failure to enable runtime PM was silent leaving callers
> in the dark.
>
> Improve it by auto-locating the PCI path and logging a warning when
> something is not as expected.
>
> v2:
> * If there is no audio hw/driver there is no failure.
>
> v3:
> * Comment.
> * Skip non-symlinks.
> * Free path on failure and restore.
> * Simplify with asprintf. (Chris Wilson)
>
> v4:
> * Find snd_hda_intel instance tied with an Intel device.
>
> v5:
> * Fix memory leak and silence Valgrind warning.
>
> v6:
> * Fix error out logic.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
CI looks promising, as far my knowledge goes (and I am sorry to say
finding the child devices is beyond my sysfs ken), series is
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t v6 2/4] lib/igt_pm: Find HDA device when attempting to enable runtime PM
Date: Tue, 24 Jul 2018 13:27:16 +0100 [thread overview]
Message-ID: <153243523685.11002.15539745648907799152@skylake-alporthouse-com> (raw)
In-Reply-To: <20180724102931.25352-1-tvrtko.ursulin@linux.intel.com>
Quoting Tvrtko Ursulin (2018-07-24 11:29:31)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> HDA audio device can be present at various PCI paths on different systems
> which the existing code did not account for.
>
> Furthermore the failure to enable runtime PM was silent leaving callers
> in the dark.
>
> Improve it by auto-locating the PCI path and logging a warning when
> something is not as expected.
>
> v2:
> * If there is no audio hw/driver there is no failure.
>
> v3:
> * Comment.
> * Skip non-symlinks.
> * Free path on failure and restore.
> * Simplify with asprintf. (Chris Wilson)
>
> v4:
> * Find snd_hda_intel instance tied with an Intel device.
>
> v5:
> * Fix memory leak and silence Valgrind warning.
>
> v6:
> * Fix error out logic.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
CI looks promising, as far my knowledge goes (and I am sorry to say
finding the child devices is beyond my sysfs ken), series is
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-24 12:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:46 [PATCH i-g-t 1/4] lib/igt_pm: Make exit handlers signal safe Tvrtko Ursulin
2018-07-23 11:46 ` [igt-dev] " Tvrtko Ursulin
2018-07-23 11:46 ` [PATCH i-g-t 2/4] lib/igt_pm: Find HDA device when attempting to enable runtime PM Tvrtko Ursulin
2018-07-23 11:46 ` [Intel-gfx] " Tvrtko Ursulin
2018-07-23 12:46 ` [PATCH i-g-t v2 " Tvrtko Ursulin
2018-07-23 12:46 ` [Intel-gfx] " Tvrtko Ursulin
2018-07-23 12:54 ` [igt-dev] " Chris Wilson
2018-07-23 12:54 ` [Intel-gfx] " Chris Wilson
2018-07-23 15:31 ` [PATCH i-g-t v3 " Tvrtko Ursulin
2018-07-23 15:31 ` [igt-dev] " Tvrtko Ursulin
2018-07-24 9:59 ` [PATCH i-g-t v4 " Tvrtko Ursulin
2018-07-24 9:59 ` [igt-dev] " Tvrtko Ursulin
2018-07-24 10:08 ` [PATCH i-g-t v5 " Tvrtko Ursulin
2018-07-24 10:08 ` [igt-dev] " Tvrtko Ursulin
2018-07-24 10:29 ` [PATCH i-g-t v6 " Tvrtko Ursulin
2018-07-24 10:29 ` [Intel-gfx] " Tvrtko Ursulin
2018-07-24 12:27 ` Chris Wilson [this message]
2018-07-24 12:27 ` [Intel-gfx] [igt-dev] " Chris Wilson
2018-07-23 11:46 ` [PATCH i-g-t 3/4] lib/igt_pm: Export function to restore runtime PM status Tvrtko Ursulin
2018-07-23 11:46 ` [igt-dev] " Tvrtko Ursulin
2018-07-23 11:46 ` [PATCH i-g-t 4/4] tests/perf_pmu: Restore runtime PM status at rc6 test exit Tvrtko Ursulin
2018-07-23 11:46 ` [igt-dev] " Tvrtko Ursulin
2018-07-23 12:37 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe Patchwork
2018-07-23 13:12 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev2) Patchwork
2018-07-23 13:58 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe Patchwork
2018-07-23 15:20 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev2) Patchwork
2018-07-23 15:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev3) Patchwork
2018-07-23 16:35 ` Tvrtko Ursulin
2018-07-24 10:34 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev5) Patchwork
2018-07-24 10:50 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev6) Patchwork
2018-07-24 11:27 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev5) Patchwork
2018-07-24 12:07 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] lib/igt_pm: Make exit handlers signal safe (rev6) Patchwork
2018-07-26 17:08 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153243523685.11002.15539745648907799152@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.