* [PATCH] webkitgtk: fix compile failure on beaglebone
@ 2018-07-25 7:55 Hongxu Jia
2018-07-25 9:53 ` Burton, Ross
2018-07-26 2:32 ` ✗ patchtest: failure for webkitgtk: fix compile failure on beaglebone (rev2) Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Hongxu Jia @ 2018-07-25 7:55 UTC (permalink / raw)
To: openembedded-core
Since the following patch applied in upstream webkitgtk
...
commit 1a55d8c685b3e5b4dbeda202009e7527aa59eadd
Author: simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Nov 23 22:20:09 2017 +0000
FELighting cleanup and optimization
https://bugs.webkit.org/show_bug.cgi?id=179933
...
It missed to tweak `paintingData.lightVector' which caused
PaintingData' has no member named 'lightVector' on ARM_NEON
(beaglebone)
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
...gData-has-no-member-named-lightVector-on-.patch | 36 ++++++++++++++++++++++
meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 1 +
2 files changed, 37 insertions(+)
create mode 100644 meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch
diff --git a/meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch b/meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch
new file mode 100644
index 0000000..af90ad7
--- /dev/null
+++ b/meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch
@@ -0,0 +1,36 @@
+From a5d4e038268ae23486fecc1966fd2e16a7f40ce8 Mon Sep 17 00:00:00 2001
+From: Hongxu Jia <hongxu.jia@windriver.com>
+Date: Wed, 25 Jul 2018 00:23:48 -0700
+Subject: [PATCH] Fix PaintingData' has no member named 'lightVector' on
+ ARM_NEON
+
+* platform/graphics/cpu/arm/filters/FELightingNEON.h:
+(WebCore::FELighting::platformApplyNeon):
+
+Upstream-Status: Pending
+
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+---
+ Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
+index 42af922..b542a4c 100644
+--- a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
++++ b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
+@@ -144,9 +144,9 @@ inline void FELighting::platformApplyNeon(const LightingData& data, const LightS
+ neonData.flags |= FLAG_CONE_EXPONENT_IS_1;
+ } else {
+ ASSERT(m_lightSource->type() == LS_DISTANT);
+- floatArguments.lightX = paintingData.lightVector.x();
+- floatArguments.lightY = paintingData.lightVector.y();
+- floatArguments.lightZ = paintingData.lightVector.z();
++ floatArguments.lightX = paintingData.initialLightingData.lightVector.x();
++ floatArguments.lightY = paintingData.initialLightingData.lightVector.y();
++ floatArguments.lightZ = paintingData.initialLightingData.lightVector.z();
+ floatArguments.padding2 = 1;
+ }
+
+--
+2.10.2
+
diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
index 9d0f00a..a528c5d 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
@@ -21,6 +21,7 @@ SRC_URI = "http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \
file://0001-Fix-build-with-musl.patch \
file://detect-gstreamer-gl.patch \
file://0012-soup-Forward-declare-URL-class.patch \
+ file://0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch \
"
SRC_URI[md5sum] = "efb69a0cc3cc67ef2647efec22e44c69"
--
2.10.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] webkitgtk: fix compile failure on beaglebone
2018-07-25 7:55 [PATCH] webkitgtk: fix compile failure on beaglebone Hongxu Jia
@ 2018-07-25 9:53 ` Burton, Ross
2018-07-25 13:57 ` Hongxu Jia
2018-07-26 2:32 ` ✗ patchtest: failure for webkitgtk: fix compile failure on beaglebone (rev2) Patchwork
1 sibling, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2018-07-25 9:53 UTC (permalink / raw)
To: Hongxu Jia; +Cc: OE-core
On 25 July 2018 at 08:55, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> +Upstream-Status: Pending
You'll be submitting this upstream right?
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] webkitgtk: fix compile failure on beaglebone
2018-07-25 9:53 ` Burton, Ross
@ 2018-07-25 13:57 ` Hongxu Jia
2018-07-25 19:52 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Hongxu Jia @ 2018-07-25 13:57 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 2018年07月25日 17:53, Burton, Ross wrote:
> On 25 July 2018 at 08:55, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> +Upstream-Status: Pending
> You'll be submitting this upstream right?
Of course, I submitted upstream after oe-core
There patch review system is based on bugzilla
https://bugs.webkit.org/show_bug.cgi?id=187991
Patch status seems ` commit-queue-'
//Hongxu
> Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] webkitgtk: fix compile failure on beaglebone
2018-07-25 13:57 ` Hongxu Jia
@ 2018-07-25 19:52 ` Burton, Ross
2018-07-26 2:39 ` [PATCH V2] " Hongxu Jia
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2018-07-25 19:52 UTC (permalink / raw)
To: Hongxu Jia; +Cc: OE-core
U-S should be Submitted with a link to that bug then.
Ross
On 25 July 2018 at 14:57, Hongxu Jia <hongxu.jia@windriver.com> wrote:
> On 2018年07月25日 17:53, Burton, Ross wrote:
>>
>> On 25 July 2018 at 08:55, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>>>
>>> +Upstream-Status: Pending
>>
>> You'll be submitting this upstream right?
>
>
> Of course, I submitted upstream after oe-core
> There patch review system is based on bugzilla
>
> https://bugs.webkit.org/show_bug.cgi?id=187991
>
> Patch status seems ` commit-queue-'
>
> //Hongxu
>>
>> Ross
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ patchtest: failure for webkitgtk: fix compile failure on beaglebone (rev2)
2018-07-25 7:55 [PATCH] webkitgtk: fix compile failure on beaglebone Hongxu Jia
2018-07-25 9:53 ` Burton, Ross
@ 2018-07-26 2:32 ` Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-07-26 2:32 UTC (permalink / raw)
To: Hongxu Jia; +Cc: openembedded-core
== Series Details ==
Series: webkitgtk: fix compile failure on beaglebone (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/13187/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Upstream-Status is Submitted, but it is not mentioned where [test_upstream_status_presence_format]
Suggested fix Include where 0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch was submitted
Current Upstream-Status: Submitted
Standard format Upstream-Status: Submitted [where]
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2] webkitgtk: fix compile failure on beaglebone
2018-07-25 19:52 ` Burton, Ross
@ 2018-07-26 2:39 ` Hongxu Jia
0 siblings, 0 replies; 6+ messages in thread
From: Hongxu Jia @ 2018-07-26 2:39 UTC (permalink / raw)
To: openembedded-core, ross.burton
Since the following patch applied in upstream webkitgtk
...
commit 1a55d8c685b3e5b4dbeda202009e7527aa59eadd
Author: simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Thu Nov 23 22:20:09 2017 +0000
FELighting cleanup and optimization
https://bugs.webkit.org/show_bug.cgi?id=179933
...
It missed to tweak `paintingData.lightVector' which caused
PaintingData' has no member named 'lightVector' on ARM_NEON
(beaglebone)
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
...gData-has-no-member-named-lightVector-on-.patch | 37 ++++++++++++++++++++++
meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 1 +
2 files changed, 38 insertions(+)
create mode 100644 meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch
diff --git a/meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch b/meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch
new file mode 100644
index 0000000..25f4846
--- /dev/null
+++ b/meta/recipes-sato/webkit/webkitgtk/0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch
@@ -0,0 +1,37 @@
+From a5d4e038268ae23486fecc1966fd2e16a7f40ce8 Mon Sep 17 00:00:00 2001
+From: Hongxu Jia <hongxu.jia@windriver.com>
+Date: Wed, 25 Jul 2018 00:23:48 -0700
+Subject: [PATCH] Fix PaintingData' has no member named 'lightVector' on
+ ARM_NEON
+
+* platform/graphics/cpu/arm/filters/FELightingNEON.h:
+(WebCore::FELighting::platformApplyNeon):
+
+Upstream-Status: Submitted
+https://bugs.webkit.org/show_bug.cgi?id=187991
+
+Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
+---
+ Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
+index 42af922..b542a4c 100644
+--- a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
++++ b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
+@@ -144,9 +144,9 @@ inline void FELighting::platformApplyNeon(const LightingData& data, const LightS
+ neonData.flags |= FLAG_CONE_EXPONENT_IS_1;
+ } else {
+ ASSERT(m_lightSource->type() == LS_DISTANT);
+- floatArguments.lightX = paintingData.lightVector.x();
+- floatArguments.lightY = paintingData.lightVector.y();
+- floatArguments.lightZ = paintingData.lightVector.z();
++ floatArguments.lightX = paintingData.initialLightingData.lightVector.x();
++ floatArguments.lightY = paintingData.initialLightingData.lightVector.y();
++ floatArguments.lightZ = paintingData.initialLightingData.lightVector.z();
+ floatArguments.padding2 = 1;
+ }
+
+--
+2.10.2
+
diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
index 9d0f00a..a528c5d 100644
--- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
+++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
@@ -21,6 +21,7 @@ SRC_URI = "http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \
file://0001-Fix-build-with-musl.patch \
file://detect-gstreamer-gl.patch \
file://0012-soup-Forward-declare-URL-class.patch \
+ file://0001-Fix-PaintingData-has-no-member-named-lightVector-on-.patch \
"
SRC_URI[md5sum] = "efb69a0cc3cc67ef2647efec22e44c69"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-26 2:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 7:55 [PATCH] webkitgtk: fix compile failure on beaglebone Hongxu Jia
2018-07-25 9:53 ` Burton, Ross
2018-07-25 13:57 ` Hongxu Jia
2018-07-25 19:52 ` Burton, Ross
2018-07-26 2:39 ` [PATCH V2] " Hongxu Jia
2018-07-26 2:32 ` ✗ patchtest: failure for webkitgtk: fix compile failure on beaglebone (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.