* [PATCH] ath10k: Protect against buggy firmware.
@ 2018-07-30 16:43 ` greearb
0 siblings, 0 replies; 2+ messages in thread
From: greearb @ 2018-07-30 16:43 UTC (permalink / raw)
To: linux-wireless, ath10k, kvalo; +Cc: Ben Greear
From: Ben Greear <greearb@candelatech.com>
While testing some buggy wave-2 firmware, I was seeing full
kernel crashes. Adding this additional check keeps
the kernel from crashing.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 478cc67..8ab949d 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -2644,9 +2644,9 @@ static void ath10k_htt_fetch_peer_stats(struct ath10k *ar,
rcu_read_lock();
spin_lock_bh(&ar->data_lock);
peer = ath10k_peer_find_by_id(ar, peer_id);
- if (!peer) {
- ath10k_warn(ar, "Invalid peer id %d peer stats buffer\n",
- peer_id);
+ if (!peer || !peer->sta) {
+ ath10k_warn(ar, "Invalid peer id %d or peer stats buffer, peer: %p sta: %p\n",
+ peer_id, peer, peer ? peer->sta : NULL);
goto out;
}
--
2.4.11
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ath10k: Protect against buggy firmware.
@ 2018-07-30 16:43 ` greearb
0 siblings, 0 replies; 2+ messages in thread
From: greearb @ 2018-07-30 16:43 UTC (permalink / raw)
To: linux-wireless, ath10k, kvalo; +Cc: Ben Greear
From: Ben Greear <greearb@candelatech.com>
While testing some buggy wave-2 firmware, I was seeing full
kernel crashes. Adding this additional check keeps
the kernel from crashing.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 478cc67..8ab949d 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -2644,9 +2644,9 @@ static void ath10k_htt_fetch_peer_stats(struct ath10k *ar,
rcu_read_lock();
spin_lock_bh(&ar->data_lock);
peer = ath10k_peer_find_by_id(ar, peer_id);
- if (!peer) {
- ath10k_warn(ar, "Invalid peer id %d peer stats buffer\n",
- peer_id);
+ if (!peer || !peer->sta) {
+ ath10k_warn(ar, "Invalid peer id %d or peer stats buffer, peer: %p sta: %p\n",
+ peer_id, peer, peer ? peer->sta : NULL);
goto out;
}
--
2.4.11
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-30 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-30 16:43 [PATCH] ath10k: Protect against buggy firmware greearb
2018-07-30 16:43 ` greearb
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.