All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 1720969] [NEW] qemu/memory.c:206: pointless copies of large structs ?
@ 2017-10-03  8:28 dcb
  2018-07-30 18:47 ` [Qemu-devel] [Bug 1720969] " Tristan Burgess
  2018-08-21  6:25 ` Thomas Huth
  0 siblings, 2 replies; 3+ messages in thread
From: dcb @ 2017-10-03  8:28 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

[qemu/memory.c:206]: (performance) Function parameter 'a' should be passed by reference.
[qemu/memory.c:207]: (performance) Function parameter 'b' should be passed by reference.

Source code is

static bool memory_region_ioeventfd_equal(MemoryRegionIoeventfd a,
                                          MemoryRegionIoeventfd b)

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1720969

Title:
  qemu/memory.c:206:  pointless copies of large structs ?

Status in QEMU:
  New

Bug description:
  [qemu/memory.c:206]: (performance) Function parameter 'a' should be passed by reference.
  [qemu/memory.c:207]: (performance) Function parameter 'b' should be passed by reference.

  Source code is

  static bool memory_region_ioeventfd_equal(MemoryRegionIoeventfd a,
                                            MemoryRegionIoeventfd b)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1720969/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] [Bug 1720969] Re: qemu/memory.c:206: pointless copies of large structs ?
  2017-10-03  8:28 [Qemu-devel] [Bug 1720969] [NEW] qemu/memory.c:206: pointless copies of large structs ? dcb
@ 2018-07-30 18:47 ` Tristan Burgess
  2018-08-21  6:25 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Tristan Burgess @ 2018-07-30 18:47 UTC (permalink / raw)
  To: qemu-devel

Fix committed and sent upstream:
https://github.com/qemu/qemu/commit/73bb753d24a702b37913ce4b5ddb6dca40dab067

** Changed in: qemu
       Status: New => Fix Committed

** Changed in: qemu
     Assignee: (unassigned) => Tristan Burgess (tburgessdev)

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1720969

Title:
  qemu/memory.c:206:  pointless copies of large structs ?

Status in QEMU:
  Fix Committed

Bug description:
  [qemu/memory.c:206]: (performance) Function parameter 'a' should be passed by reference.
  [qemu/memory.c:207]: (performance) Function parameter 'b' should be passed by reference.

  Source code is

  static bool memory_region_ioeventfd_equal(MemoryRegionIoeventfd a,
                                            MemoryRegionIoeventfd b)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1720969/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] [Bug 1720969] Re: qemu/memory.c:206: pointless copies of large structs ?
  2017-10-03  8:28 [Qemu-devel] [Bug 1720969] [NEW] qemu/memory.c:206: pointless copies of large structs ? dcb
  2018-07-30 18:47 ` [Qemu-devel] [Bug 1720969] " Tristan Burgess
@ 2018-08-21  6:25 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2018-08-21  6:25 UTC (permalink / raw)
  To: qemu-devel

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1720969

Title:
  qemu/memory.c:206:  pointless copies of large structs ?

Status in QEMU:
  Fix Released

Bug description:
  [qemu/memory.c:206]: (performance) Function parameter 'a' should be passed by reference.
  [qemu/memory.c:207]: (performance) Function parameter 'b' should be passed by reference.

  Source code is

  static bool memory_region_ioeventfd_equal(MemoryRegionIoeventfd a,
                                            MemoryRegionIoeventfd b)

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1720969/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-21  6:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-03  8:28 [Qemu-devel] [Bug 1720969] [NEW] qemu/memory.c:206: pointless copies of large structs ? dcb
2018-07-30 18:47 ` [Qemu-devel] [Bug 1720969] " Tristan Burgess
2018-08-21  6:25 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.