From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: linux-arm-kernel@lists.infradead.org Cc: Sudeep Holla <sudeep.holla@arm.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Daniel Kachhap <amit.kachhap@arm.com> Subject: [PATCH] clk: scmi: Fix the rounding of clock rate Date: Tue, 31 Jul 2018 11:25:55 +0530 [thread overview] Message-ID: <1533016555-3731-1-git-send-email-amit.kachhap@arm.com> (raw) In-Reply-To: <153296797329.17365.14490424418553594815@swboyd.mtv.corp.google.com> This fix rounds the clock rate properly by using quotient and not remainder in the calculation. This issue was found while testing HDMI in the Juno platform. Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") Acked-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> --- drivers/clk/clk-scmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c index bb2a6f2..a985bf5 100644 --- a/drivers/clk/clk-scmi.c +++ b/drivers/clk/clk-scmi.c @@ -38,7 +38,6 @@ static unsigned long scmi_clk_recalc_rate(struct clk_hw *hw, static long scmi_clk_round_rate(struct clk_hw *hw, unsigned long rate, unsigned long *parent_rate) { - int step; u64 fmin, fmax, ftmp; struct scmi_clk *clk = to_scmi_clk(hw); @@ -60,9 +59,9 @@ static long scmi_clk_round_rate(struct clk_hw *hw, unsigned long rate, ftmp = rate - fmin; ftmp += clk->info->range.step_size - 1; /* to round up */ - step = do_div(ftmp, clk->info->range.step_size); + do_div(ftmp, clk->info->range.step_size); - return step * clk->info->range.step_size + fmin; + return ftmp * clk->info->range.step_size + fmin; } static int scmi_clk_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: amit.kachhap@arm.com (Amit Daniel Kachhap) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] clk: scmi: Fix the rounding of clock rate Date: Tue, 31 Jul 2018 11:25:55 +0530 [thread overview] Message-ID: <1533016555-3731-1-git-send-email-amit.kachhap@arm.com> (raw) In-Reply-To: <153296797329.17365.14490424418553594815@swboyd.mtv.corp.google.com> This fix rounds the clock rate properly by using quotient and not remainder in the calculation. This issue was found while testing HDMI in the Juno platform. Fixes: 6d6a1d82eaef7 ("clk: add support for clocks provided by SCMI") Acked-by: Sudeep Holla <sudeep.holla@arm.com> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> --- drivers/clk/clk-scmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c index bb2a6f2..a985bf5 100644 --- a/drivers/clk/clk-scmi.c +++ b/drivers/clk/clk-scmi.c @@ -38,7 +38,6 @@ static unsigned long scmi_clk_recalc_rate(struct clk_hw *hw, static long scmi_clk_round_rate(struct clk_hw *hw, unsigned long rate, unsigned long *parent_rate) { - int step; u64 fmin, fmax, ftmp; struct scmi_clk *clk = to_scmi_clk(hw); @@ -60,9 +59,9 @@ static long scmi_clk_round_rate(struct clk_hw *hw, unsigned long rate, ftmp = rate - fmin; ftmp += clk->info->range.step_size - 1; /* to round up */ - step = do_div(ftmp, clk->info->range.step_size); + do_div(ftmp, clk->info->range.step_size); - return step * clk->info->range.step_size + fmin; + return ftmp * clk->info->range.step_size + fmin; } static int scmi_clk_set_rate(struct clk_hw *hw, unsigned long rate, -- 2.7.4
next prev parent reply other threads:[~2018-07-31 5:56 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-27 14:01 [PATCH] clk: scmi: Fix the rounding of clock rate Amit Daniel Kachhap 2018-07-27 14:01 ` Amit Daniel Kachhap 2018-07-27 16:37 ` Stephen Boyd 2018-07-27 16:37 ` Stephen Boyd 2018-07-27 16:37 ` Stephen Boyd 2018-07-30 5:33 ` Amit Daniel Kachhap 2018-07-30 5:33 ` Amit Daniel Kachhap 2018-07-30 11:40 ` Sudeep Holla 2018-07-30 11:40 ` Sudeep Holla 2018-07-30 16:26 ` Stephen Boyd 2018-07-30 16:26 ` Stephen Boyd 2018-07-30 16:26 ` Stephen Boyd 2018-07-31 5:55 ` Amit Daniel Kachhap [this message] 2018-07-31 5:55 ` Amit Daniel Kachhap 2018-08-02 20:50 ` Stephen Boyd 2018-08-02 20:50 ` Stephen Boyd 2018-08-02 20:50 ` Stephen Boyd 2018-07-31 5:21 ` Amit Daniel Kachhap 2018-07-31 5:21 ` Amit Daniel Kachhap 2018-07-30 11:36 ` Sudeep Holla 2018-07-30 11:36 ` Sudeep Holla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1533016555-3731-1-git-send-email-amit.kachhap@arm.com \ --to=amit.kachhap@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ --cc=sudeep.holla@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.