* [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+
@ 2018-08-01 10:05 Chris Wilson
2018-08-01 10:13 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Chris Wilson @ 2018-08-01 10:05 UTC (permalink / raw)
To: intel-gfx
We haven't had a full run yet on on gen10+ so it's hard to tell if the
userspace tests are confirming the same as live_objects/live_coherency
selftests is hinting.
---
drivers/gpu/drm/i915/i915_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index e443fe44da3a..adf80563d0a1 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -590,6 +590,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
GEN9_FEATURES, \
GEN(10), \
.ddb_size = 1024, \
+ .has_coherent_ggtt = false, \
GLK_COLORS
static const struct intel_device_info intel_cannonlake_info = {
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for RFT drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 10:05 [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+ Chris Wilson
@ 2018-08-01 10:13 ` Patchwork
2018-08-01 10:34 ` ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-08-01 10:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT drm/i95: Mark GGTT as incoherent for gen10+
URL : https://patchwork.freedesktop.org/series/47533/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e2c513ef2e97 RFT drm/i95: Mark GGTT as incoherent for gen10+
-:21: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 0 checks, 7 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for RFT drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 10:05 [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+ Chris Wilson
2018-08-01 10:13 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-08-01 10:34 ` Patchwork
2018-08-01 10:40 ` Chris Wilson
2018-08-01 10:47 ` [PATCH] " Chris Wilson
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2018-08-01 10:34 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT drm/i95: Mark GGTT as incoherent for gen10+
URL : https://patchwork.freedesktop.org/series/47533/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4600 -> Patchwork_9830 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47533/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9830 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@debugfs_test@read_all_entries:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107396)
igt@drv_selftest@live_guc:
fi-skl-guc: NOTRUN -> DMESG-WARN (fdo#107175, fdo#107258)
igt@drv_selftest@live_hangcheck:
{fi-icl-u}: NOTRUN -> INCOMPLETE (fdo#107399)
igt@drv_selftest@live_workarounds:
fi-cnl-psr: PASS -> DMESG-FAIL (fdo#107292)
igt@gem_workarounds@basic-read:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107338)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107382) +4
{igt@kms_psr@primary_page_flip}:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107383) +3
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-kbl-guc: DMESG-FAIL (fdo#106947) -> PASS
fi-skl-6260u: DMESG-FAIL (fdo#106560, fdo#107174) -> PASS
igt@drv_selftest@live_objects:
fi-cnl-psr: DMESG-FAIL (fdo#107398) -> PASS
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: DMESG-FAIL (fdo#107292) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: DMESG-FAIL (fdo#102614, fdo#106103) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-skl-6700k2: FAIL (fdo#103191) -> PASS
==== Warnings ====
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-FAIL (fdo#107372) -> DMESG-WARN (fdo#107372)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107338 https://bugs.freedesktop.org/show_bug.cgi?id=107338
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107382 https://bugs.freedesktop.org/show_bug.cgi?id=107382
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
fdo#107396 https://bugs.freedesktop.org/show_bug.cgi?id=107396
fdo#107398 https://bugs.freedesktop.org/show_bug.cgi?id=107398
fdo#107399 https://bugs.freedesktop.org/show_bug.cgi?id=107399
== Participating hosts (48 -> 46) ==
Additional (3): fi-skl-guc fi-glk-j4005 fi-icl-u
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-byt-clapper fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4600 -> Patchwork_9830
CI_DRM_4600: 308427119c70d0aaa90433b05969a0317165b122 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9830: e2c513ef2e973180adfe170fce902392dc8b7b2a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e2c513ef2e97 RFT drm/i95: Mark GGTT as incoherent for gen10+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9830/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ✓ Fi.CI.BAT: success for RFT drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 10:34 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-08-01 10:40 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2018-08-01 10:40 UTC (permalink / raw)
To: Patchwork; +Cc: intel-gfx
Quoting Patchwork (2018-08-01 11:34:58)
> igt@drv_selftest@live_objects:
> fi-cnl-psr: DMESG-FAIL (fdo#107398) -> PASS
Well the bad news is that it did indeed fix the iomap incoherency we
have in CI on both cnl and icl.
Sigh.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 10:05 [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+ Chris Wilson
2018-08-01 10:13 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-08-01 10:34 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-08-01 10:47 ` Chris Wilson
2018-08-01 13:08 ` Mika Kuoppala
2018-08-01 11:18 ` ✗ Fi.CI.BAT: failure for RFT drm/i95: Mark GGTT as incoherent for gen10+ (rev2) Patchwork
2018-08-01 11:24 ` ✓ Fi.CI.IGT: success for RFT drm/i95: Mark GGTT as incoherent for gen10+ Patchwork
4 siblings, 1 reply; 9+ messages in thread
From: Chris Wilson @ 2018-08-01 10:47 UTC (permalink / raw)
To: intel-gfx
The evidence suggests that we need to start treating writes via GGTT as
incoherent for gen10+, that is that they are internally buffered and not
immediately visible via a read along a different physical path.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107398
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107400
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/i915_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index e443fe44da3a..adf80563d0a1 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -590,6 +590,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
GEN9_FEATURES, \
GEN(10), \
.ddb_size = 1024, \
+ .has_coherent_ggtt = false, \
GLK_COLORS
static const struct intel_device_info intel_cannonlake_info = {
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for RFT drm/i95: Mark GGTT as incoherent for gen10+ (rev2)
2018-08-01 10:05 [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+ Chris Wilson
` (2 preceding siblings ...)
2018-08-01 10:47 ` [PATCH] " Chris Wilson
@ 2018-08-01 11:18 ` Patchwork
2018-08-01 11:24 ` ✓ Fi.CI.IGT: success for RFT drm/i95: Mark GGTT as incoherent for gen10+ Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-08-01 11:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT drm/i95: Mark GGTT as incoherent for gen10+ (rev2)
URL : https://patchwork.freedesktop.org/series/47533/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4600 -> Patchwork_9831 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9831 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9831, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47533/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9831:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_sanitycheck:
fi-bxt-j4205: PASS -> DMESG-FAIL
==== Warnings ====
igt@drv_selftest@live_requests:
fi-bxt-j4205: PASS -> SKIP +12
== Known issues ==
Here are the changes found in Patchwork_9831 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@debugfs_test@read_all_entries:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107396)
igt@drv_selftest@live_guc:
fi-skl-guc: NOTRUN -> DMESG-WARN (fdo#107258, fdo#107175)
igt@drv_selftest@live_hangcheck:
{fi-bdw-samus}: PASS -> DMESG-FAIL (fdo#106560)
{fi-icl-u}: NOTRUN -> INCOMPLETE (fdo#107399)
igt@drv_selftest@live_workarounds:
fi-cnl-psr: PASS -> DMESG-FAIL (fdo#107292)
igt@gem_workarounds@basic-read:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107338)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
{fi-icl-u}: NOTRUN -> DMESG-WARN (fdo#107382) +4
{igt@kms_psr@primary_page_flip}:
{fi-icl-u}: NOTRUN -> FAIL (fdo#107383) +3
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-kbl-guc: DMESG-FAIL (fdo#106947) -> PASS
fi-skl-6260u: DMESG-FAIL (fdo#106560, fdo#107174) -> PASS
igt@drv_selftest@live_objects:
fi-cnl-psr: DMESG-FAIL (fdo#107398) -> PASS
igt@drv_selftest@live_workarounds:
{fi-cfl-8109u}: DMESG-FAIL (fdo#107292) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: DMESG-FAIL (fdo#102614, fdo#106103) -> PASS
igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
fi-skl-6700k2: FAIL (fdo#103191) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107338 https://bugs.freedesktop.org/show_bug.cgi?id=107338
fdo#107382 https://bugs.freedesktop.org/show_bug.cgi?id=107382
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
fdo#107396 https://bugs.freedesktop.org/show_bug.cgi?id=107396
fdo#107398 https://bugs.freedesktop.org/show_bug.cgi?id=107398
fdo#107399 https://bugs.freedesktop.org/show_bug.cgi?id=107399
== Participating hosts (48 -> 45) ==
Additional (3): fi-skl-guc fi-glk-j4005 fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-ctg-p8600 fi-gdg-551 fi-byt-clapper
== Build changes ==
* Linux: CI_DRM_4600 -> Patchwork_9831
CI_DRM_4600: 308427119c70d0aaa90433b05969a0317165b122 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9831: f8ece241ebf1c3ba89cdf93d8395fc6606c980cb @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f8ece241ebf1 drm/i95: Mark GGTT as incoherent for gen10+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9831/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for RFT drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 10:05 [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+ Chris Wilson
` (3 preceding siblings ...)
2018-08-01 11:18 ` ✗ Fi.CI.BAT: failure for RFT drm/i95: Mark GGTT as incoherent for gen10+ (rev2) Patchwork
@ 2018-08-01 11:24 ` Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-08-01 11:24 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: RFT drm/i95: Mark GGTT as incoherent for gen10+
URL : https://patchwork.freedesktop.org/series/47533/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4600_full -> Patchwork_9830_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_9830_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-glk: FAIL (fdo#106886) -> PASS
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
shard-glk: FAIL (fdo#105312) -> PASS
igt@kms_flip@dpms-vs-vblank-race:
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4600 -> Patchwork_9830
CI_DRM_4600: 308427119c70d0aaa90433b05969a0317165b122 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9830: e2c513ef2e973180adfe170fce902392dc8b7b2a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9830/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 10:47 ` [PATCH] " Chris Wilson
@ 2018-08-01 13:08 ` Mika Kuoppala
2018-08-01 13:18 ` Chris Wilson
0 siblings, 1 reply; 9+ messages in thread
From: Mika Kuoppala @ 2018-08-01 13:08 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> The evidence suggests that we need to start treating writes via GGTT as
> incoherent for gen10+, that is that they are internally buffered and not
> immediately visible via a read along a different physical path.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107398
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107400
Looks like it. And we don't have better explanations at this point.
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index e443fe44da3a..adf80563d0a1 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -590,6 +590,7 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
> GEN9_FEATURES, \
> GEN(10), \
> .ddb_size = 1024, \
> + .has_coherent_ggtt = false, \
> GLK_COLORS
>
> static const struct intel_device_info intel_cannonlake_info = {
> --
> 2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i95: Mark GGTT as incoherent for gen10+
2018-08-01 13:08 ` Mika Kuoppala
@ 2018-08-01 13:18 ` Chris Wilson
0 siblings, 0 replies; 9+ messages in thread
From: Chris Wilson @ 2018-08-01 13:18 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2018-08-01 14:08:33)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > The evidence suggests that we need to start treating writes via GGTT as
> > incoherent for gen10+, that is that they are internally buffered and not
> > immediately visible via a read along a different physical path.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107398
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107400
>
> Looks like it. And we don't have better explanations at this point.
>
> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Applied, err on the side of safety. We can try setting it to true later
and see how it fares then.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-08-01 13:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 10:05 [PATCH] RFT drm/i95: Mark GGTT as incoherent for gen10+ Chris Wilson
2018-08-01 10:13 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-08-01 10:34 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-01 10:40 ` Chris Wilson
2018-08-01 10:47 ` [PATCH] " Chris Wilson
2018-08-01 13:08 ` Mika Kuoppala
2018-08-01 13:18 ` Chris Wilson
2018-08-01 11:18 ` ✗ Fi.CI.BAT: failure for RFT drm/i95: Mark GGTT as incoherent for gen10+ (rev2) Patchwork
2018-08-01 11:24 ` ✓ Fi.CI.IGT: success for RFT drm/i95: Mark GGTT as incoherent for gen10+ Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.