* [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
@ 2018-08-01 10:29 Laurent Vivier
2018-08-01 10:50 ` no-reply
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Laurent Vivier @ 2018-08-01 10:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier, Tom A, Thomas Huth
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
scripts/qemu-binfmt-conf.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index b0dc8a714a..b5a16742a1 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -4,7 +4,7 @@
qemu_target_list="i386 i486 alpha arm armeb sparc32plus ppc ppc64 ppc64le m68k \
mips mipsel mipsn32 mipsn32el mips64 mips64el \
sh4 sh4eb s390x aarch64 aarch64_be hppa riscv32 riscv64 xtensa xtensaeb \
-microblaze microblazeel or1k"
+microblaze microblazeel or1k x86_64"
i386_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x03\x00'
i386_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
@@ -14,6 +14,10 @@ i486_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x06\
i486_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
i486_family=i386
+x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'
+x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
+x86_64_family=i386
+
alpha_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x26\x90'
alpha_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
alpha_family=alpha
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
2018-08-01 10:29 [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target Laurent Vivier
@ 2018-08-01 10:50 ` no-reply
2018-08-01 10:51 ` Richard Henderson
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2018-08-01 10:50 UTC (permalink / raw)
To: laurent; +Cc: famz, qemu-devel, agentlecomputer, thuth, riku.voipio
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180801102944.23457-1-laurent@vivier.eu
Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e57da6bfe4 qemu-binfmt-conf.sh: add x86_64 target
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-binfmt-conf.sh: add x86_64 target...
WARNING: line over 80 characters
#26: FILE: scripts/qemu-binfmt-conf.sh:17:
+x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'
ERROR: line over 90 characters
#27: FILE: scripts/qemu-binfmt-conf.sh:18:
+x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
total: 1 errors, 1 warnings, 18 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
2018-08-01 10:29 [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target Laurent Vivier
2018-08-01 10:50 ` no-reply
@ 2018-08-01 10:51 ` Richard Henderson
2018-08-01 10:56 ` no-reply
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Richard Henderson @ 2018-08-01 10:51 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Tom A, Thomas Huth, Riku Voipio
On 08/01/2018 06:29 AM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> scripts/qemu-binfmt-conf.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
2018-08-01 10:29 [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target Laurent Vivier
2018-08-01 10:50 ` no-reply
2018-08-01 10:51 ` Richard Henderson
@ 2018-08-01 10:56 ` no-reply
2018-08-01 13:14 ` Thomas Huth
2018-08-01 18:10 ` no-reply
4 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2018-08-01 10:56 UTC (permalink / raw)
To: laurent; +Cc: famz, qemu-devel, agentlecomputer, thuth, riku.voipio
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180801102944.23457-1-laurent@vivier.eu
Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20180801102944.23457-1-laurent@vivier.eu -> patchew/20180801102944.23457-1-laurent@vivier.eu
Switched to a new branch 'test'
927e645782 qemu-binfmt-conf.sh: add x86_64 target
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-binfmt-conf.sh: add x86_64 target...
WARNING: line over 80 characters
#27: FILE: scripts/qemu-binfmt-conf.sh:17:
+x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'
ERROR: line over 90 characters
#28: FILE: scripts/qemu-binfmt-conf.sh:18:
+x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
total: 1 errors, 1 warnings, 18 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
2018-08-01 10:29 [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target Laurent Vivier
` (2 preceding siblings ...)
2018-08-01 10:56 ` no-reply
@ 2018-08-01 13:14 ` Thomas Huth
2018-08-01 18:10 ` no-reply
4 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2018-08-01 13:14 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Riku Voipio, Tom A
On 08/01/2018 12:29 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> scripts/qemu-binfmt-conf.sh | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
> index b0dc8a714a..b5a16742a1 100755
> --- a/scripts/qemu-binfmt-conf.sh
> +++ b/scripts/qemu-binfmt-conf.sh
> @@ -4,7 +4,7 @@
> qemu_target_list="i386 i486 alpha arm armeb sparc32plus ppc ppc64 ppc64le m68k \
> mips mipsel mipsn32 mipsn32el mips64 mips64el \
> sh4 sh4eb s390x aarch64 aarch64_be hppa riscv32 riscv64 xtensa xtensaeb \
> -microblaze microblazeel or1k"
> +microblaze microblazeel or1k x86_64"
>
> i386_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x03\x00'
> i386_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
> @@ -14,6 +14,10 @@ i486_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x06\
> i486_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
> i486_family=i386
>
> +x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'
> +x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
> +x86_64_family=i386
\x02 == 64-bit ... \x3e == EM_X86_64 ... looks good!
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
2018-08-01 10:29 [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target Laurent Vivier
` (3 preceding siblings ...)
2018-08-01 13:14 ` Thomas Huth
@ 2018-08-01 18:10 ` no-reply
4 siblings, 0 replies; 6+ messages in thread
From: no-reply @ 2018-08-01 18:10 UTC (permalink / raw)
To: laurent; +Cc: famz, qemu-devel, agentlecomputer, thuth, riku.voipio
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180801102944.23457-1-laurent@vivier.eu
Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
50e6cc3a12 qemu-binfmt-conf.sh: add x86_64 target
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-binfmt-conf.sh: add x86_64 target...
WARNING: line over 80 characters
#28: FILE: scripts/qemu-binfmt-conf.sh:17:
+x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'
ERROR: line over 90 characters
#29: FILE: scripts/qemu-binfmt-conf.sh:18:
+x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
total: 1 errors, 1 warnings, 18 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-01 18:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 10:29 [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target Laurent Vivier
2018-08-01 10:50 ` no-reply
2018-08-01 10:51 ` Richard Henderson
2018-08-01 10:56 ` no-reply
2018-08-01 13:14 ` Thomas Huth
2018-08-01 18:10 ` no-reply
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.