* [PATCH] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP flag
@ 2018-08-02 6:35 ` Keerthy
0 siblings, 0 replies; 4+ messages in thread
From: Keerthy @ 2018-08-02 6:35 UTC (permalink / raw)
To: daniel.lezcano, tglx
Cc: linux-kernel, linux-omap, baolin.wang, d-gerlach, tony,
grygorii.strashko, j-keerthy, t-kristo
With the introduction of below commit:
commit 39232ed5a1793f67b11430c43ed8a9ed6e96c6eb
time: Introduce one suspend clocksource to compensate the suspend time
The suspend/resume fails on AM437x platforms as the source is not
a non-stop while trying to compensate time using this.
Hence remove the CLOCK_SOURCE_SUSPEND_NONSTOP flag.
Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/clocksource/timer-ti-32k.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
index 880a861..7368e8e 100644
--- a/drivers/clocksource/timer-ti-32k.c
+++ b/drivers/clocksource/timer-ti-32k.c
@@ -78,8 +78,7 @@ static u64 notrace ti_32k_read_cycles(struct clocksource *cs)
.rating = 250,
.read = ti_32k_read_cycles,
.mask = CLOCKSOURCE_MASK(32),
- .flags = CLOCK_SOURCE_IS_CONTINUOUS |
- CLOCK_SOURCE_SUSPEND_NONSTOP,
+ .flags = CLOCK_SOURCE_IS_CONTINUOUS,
},
};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [tip:timers/core] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP flag
2018-08-02 6:35 ` Keerthy
(?)
@ 2018-08-02 11:39 ` tip-bot for Keerthy
-1 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Keerthy @ 2018-08-02 11:39 UTC (permalink / raw)
To: linux-tip-commits
Cc: j-keerthy, hpa, linux-omap, t-kristo, daniel.lezcano, d-gerlach,
grygorii.strashko, tglx, tony, linux-kernel, baolin.wang, mingo
Commit-ID: c77aee71bbc67c4b0e56f4ce10406b85d4c929c1
Gitweb: https://git.kernel.org/tip/c77aee71bbc67c4b0e56f4ce10406b85d4c929c1
Author: Keerthy <j-keerthy@ti.com>
AuthorDate: Thu, 2 Aug 2018 12:05:16 +0530
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 2 Aug 2018 13:35:08 +0200
clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP flag
Since commit 39232ed5a179 ("time: Introduce one suspend clocksource to
compensate the suspend time") suspend/resume fails on AM437x platforms as
the clocksource actually stops in suspend.
Hence remove the CLOCK_SOURCE_SUSPEND_NONSTOP flag.
Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: <daniel.lezcano@linaro.org>
Cc: <linux-omap@vger.kernel.org>
Cc: <baolin.wang@linaro.org>
Cc: <d-gerlach@ti.com>
Cc: <tony@atomide.com>
Cc: <t-kristo@ti.com>
Link: https://lkml.kernel.org/r/1533191716-20476-1-git-send-email-j-keerthy@ti.com
---
drivers/clocksource/timer-ti-32k.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
index 880a861ab3c8..29e2e1a78a43 100644
--- a/drivers/clocksource/timer-ti-32k.c
+++ b/drivers/clocksource/timer-ti-32k.c
@@ -78,8 +78,7 @@ static struct ti_32k ti_32k_timer = {
.rating = 250,
.read = ti_32k_read_cycles,
.mask = CLOCKSOURCE_MASK(32),
- .flags = CLOCK_SOURCE_IS_CONTINUOUS |
- CLOCK_SOURCE_SUSPEND_NONSTOP,
+ .flags = CLOCK_SOURCE_IS_CONTINUOUS,
},
};
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clocksource: ti-32k: Remove CLOCK_SOURCE_SUSPEND_NONSTOP flag
2018-08-02 6:35 ` Keerthy
(?)
(?)
@ 2018-08-06 8:16 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2018-08-06 8:16 UTC (permalink / raw)
To: Keerthy
Cc: daniel.lezcano, tglx, linux-kernel, linux-omap, baolin.wang,
d-gerlach, grygorii.strashko, t-kristo
Keerthy,
* Keerthy <j-keerthy@ti.com> [180802 06:39]:
> With the introduction of below commit:
>
> commit 39232ed5a1793f67b11430c43ed8a9ed6e96c6eb
>
> time: Introduce one suspend clocksource to compensate the suspend time
>
> The suspend/resume fails on AM437x platforms as the source is not
> a non-stop while trying to compensate time using this.
>
> Hence remove the CLOCK_SOURCE_SUSPEND_NONSTOP flag.
The 32k timer only stops on am4, on omap3 to omap5 and dra7 it's always
on. So the NONSTOP flag should be removed only for am4.
Care to do an incremental patch clearing NONSTOP based on compatible
property?
Regards,
Tony
> Suggested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/clocksource/timer-ti-32k.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/clocksource/timer-ti-32k.c b/drivers/clocksource/timer-ti-32k.c
> index 880a861..7368e8e 100644
> --- a/drivers/clocksource/timer-ti-32k.c
> +++ b/drivers/clocksource/timer-ti-32k.c
> @@ -78,8 +78,7 @@ static u64 notrace ti_32k_read_cycles(struct clocksource *cs)
> .rating = 250,
> .read = ti_32k_read_cycles,
> .mask = CLOCKSOURCE_MASK(32),
> - .flags = CLOCK_SOURCE_IS_CONTINUOUS |
> - CLOCK_SOURCE_SUSPEND_NONSTOP,
> + .flags = CLOCK_SOURCE_IS_CONTINUOUS,
> },
> };
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread