All of lore.kernel.org
 help / color / mirror / Atom feed
From: CK Hu <ck.hu@mediatek.com>
To: Stu Hsieh <stu.hsieh@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@linux.ie>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>
Subject: Re: [PATCH v2 04/15] drm/mediatek: add connection from RDMA2 to DSI0
Date: Fri, 3 Aug 2018 13:01:21 +0800	[thread overview]
Message-ID: <1533272481.31144.3.camel@mtksdaap41> (raw)
In-Reply-To: <1533265868-28110-5-git-send-email-stu.hsieh@mediatek.com>

Hi, Stu:

On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote:
> This patch add connection from RDMA2 to DSI0
> 
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index 31189fad8d4e..3239f22785fd 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -125,6 +125,7 @@
>  #define DPI1_SEL_IN_RDMA1		(0x1 << 8)
>  #define DPI1_SEL_IN_RDMA2		(0x3 << 8)
>  #define DSI0_SEL_IN_RDMA1		0x1
> +#define DSI0_SEL_IN_RDMA2		0x4
>  #define DSI1_SEL_IN_RDMA1		0x1
>  #define DSI1_SEL_IN_RDMA2		0x4
>  #define DSI2_SEL_IN_RDMA1		(0x1 << 16)
> @@ -309,6 +310,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur,
>  	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) {
>  		*addr = DISP_REG_CONFIG_DPI_SEL_IN;
>  		value = DPI1_SEL_IN_RDMA2;
> +	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DSI0) {
> +		*addr = DISP_REG_CONFIG_DSIE_SEL_IN;
> +		value = DSI0_SEL_IN_RDMA2;
>  	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DSI1) {
>  		*addr = DISP_REG_CONFIG_DSIE_SEL_IN;
>  		value = DSI1_SEL_IN_RDMA2;



WARNING: multiple messages have this Message-ID (diff)
From: CK Hu <ck.hu@mediatek.com>
To: Stu Hsieh <stu.hsieh@mediatek.com>
Cc: srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 04/15] drm/mediatek: add connection from RDMA2 to DSI0
Date: Fri, 3 Aug 2018 13:01:21 +0800	[thread overview]
Message-ID: <1533272481.31144.3.camel@mtksdaap41> (raw)
In-Reply-To: <1533265868-28110-5-git-send-email-stu.hsieh@mediatek.com>

Hi, Stu:

On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote:
> This patch add connection from RDMA2 to DSI0
> 
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index 31189fad8d4e..3239f22785fd 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -125,6 +125,7 @@
>  #define DPI1_SEL_IN_RDMA1		(0x1 << 8)
>  #define DPI1_SEL_IN_RDMA2		(0x3 << 8)
>  #define DSI0_SEL_IN_RDMA1		0x1
> +#define DSI0_SEL_IN_RDMA2		0x4
>  #define DSI1_SEL_IN_RDMA1		0x1
>  #define DSI1_SEL_IN_RDMA2		0x4
>  #define DSI2_SEL_IN_RDMA1		(0x1 << 16)
> @@ -309,6 +310,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur,
>  	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) {
>  		*addr = DISP_REG_CONFIG_DPI_SEL_IN;
>  		value = DPI1_SEL_IN_RDMA2;
> +	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DSI0) {
> +		*addr = DISP_REG_CONFIG_DSIE_SEL_IN;
> +		value = DSI0_SEL_IN_RDMA2;
>  	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DSI1) {
>  		*addr = DISP_REG_CONFIG_DSIE_SEL_IN;
>  		value = DSI1_SEL_IN_RDMA2;


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/15] drm/mediatek: add connection from RDMA2 to DSI0
Date: Fri, 3 Aug 2018 13:01:21 +0800	[thread overview]
Message-ID: <1533272481.31144.3.camel@mtksdaap41> (raw)
In-Reply-To: <1533265868-28110-5-git-send-email-stu.hsieh@mediatek.com>

Hi, Stu:

On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote:
> This patch add connection from RDMA2 to DSI0
> 
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>

Reviewed-by: CK Hu <ck.hu@mediatek.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> index 31189fad8d4e..3239f22785fd 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c
> @@ -125,6 +125,7 @@
>  #define DPI1_SEL_IN_RDMA1		(0x1 << 8)
>  #define DPI1_SEL_IN_RDMA2		(0x3 << 8)
>  #define DSI0_SEL_IN_RDMA1		0x1
> +#define DSI0_SEL_IN_RDMA2		0x4
>  #define DSI1_SEL_IN_RDMA1		0x1
>  #define DSI1_SEL_IN_RDMA2		0x4
>  #define DSI2_SEL_IN_RDMA1		(0x1 << 16)
> @@ -309,6 +310,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur,
>  	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) {
>  		*addr = DISP_REG_CONFIG_DPI_SEL_IN;
>  		value = DPI1_SEL_IN_RDMA2;
> +	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DSI0) {
> +		*addr = DISP_REG_CONFIG_DSIE_SEL_IN;
> +		value = DSI0_SEL_IN_RDMA2;
>  	} else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DSI1) {
>  		*addr = DISP_REG_CONFIG_DSIE_SEL_IN;
>  		value = DSI1_SEL_IN_RDMA2;

  reply	other threads:[~2018-08-03  5:01 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-03  3:10 [PATCH v2 00/15] Add RDMA memory mode support for mediatek SOC MT2712 Stu Hsieh
2018-08-03  3:10 ` Stu Hsieh
2018-08-03  3:10 ` Stu Hsieh
2018-08-03  3:10 ` [PATCH v2 01/15] drm/mediatek: add connection from RDMA0 to DPI1 Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  4:57   ` CK Hu
2018-08-03  4:57     ` CK Hu
2018-08-03  4:57     ` CK Hu
2018-08-03  3:10 ` [PATCH v2 02/15] drm/mediatek: add connection from RDMA0 to DSI1 Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  4:58   ` CK Hu
2018-08-03  4:58     ` CK Hu
2018-08-03  4:58     ` CK Hu
2018-08-03  3:10 ` [PATCH v2 03/15] drm/mediatek: add connection from RDMA1 to DSI0 Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  5:00   ` CK Hu
2018-08-03  5:00     ` CK Hu
2018-08-03  5:00     ` CK Hu
2018-08-03  3:10 ` [PATCH v2 04/15] drm/mediatek: add connection from RDMA2 " Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  5:01   ` CK Hu [this message]
2018-08-03  5:01     ` CK Hu
2018-08-03  5:01     ` CK Hu
2018-08-03  3:10 ` [PATCH v2 05/15] drm/mediatek: add RDMA memory mode for crtc created Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10 ` [PATCH v2 06/15] drm/mediatek: add memory mode for RDMA Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:10   ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 07/15] drm/mediatek: add layer config to set RDMA for plane setting Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 08/15] drm/mediatek: add RGB color format support for RDMA Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 09/15] drm/mediatek: add YUYV/UYVY " Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 10/15] drm/mediatek: add function to get layer number for component Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  5:08   ` CK Hu
2018-08-03  5:08     ` CK Hu
2018-08-03  5:08     ` CK Hu
2018-08-03  3:11 ` [PATCH v2 11/15] drm/mediatek: add callback function to return OVL layer number Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  5:11   ` CK Hu
2018-08-03  5:11     ` CK Hu
2018-08-03  5:11     ` CK Hu
2018-08-06 11:54     ` Stu Hsieh
2018-08-06 11:54       ` Stu Hsieh
2018-08-06 11:54       ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 12/15] drm/mediatek: add callback function to return RDMA " Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  5:13   ` CK Hu
2018-08-03  5:13     ` CK Hu
2018-08-03  5:13     ` CK Hu
2018-08-06 11:53     ` Stu Hsieh
2018-08-06 11:53       ` Stu Hsieh
2018-08-06 11:53       ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 13/15] drm/mediatek: use layer_nr function to get layer number to init plane Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  5:33   ` CK Hu
2018-08-03  5:33     ` CK Hu
2018-08-03  5:33     ` CK Hu
2018-08-06 11:55     ` Stu Hsieh
2018-08-06 11:55       ` Stu Hsieh
2018-08-06 11:55       ` Stu Hsieh
2018-08-03  3:11 ` [PATCH v2 14/15] drm/mediatek: update some variable name from ovl to comp Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  5:34   ` CK Hu
2018-08-03  5:34     ` CK Hu
2018-08-03  5:34     ` CK Hu
2018-08-03  3:11 ` [PATCH v2 15/15] drm/mediatek: fix connection from RDMA2 to DSI1 Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  3:11   ` Stu Hsieh
2018-08-03  5:36   ` CK Hu
2018-08-03  5:36     ` CK Hu
2018-08-03  5:36     ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1533272481.31144.3.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=srv_heupstream@mediatek.com \
    --cc=stu.hsieh@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.