* [PATCH] drm/i915/selftests: Be loud if we run out of time
@ 2018-08-08 8:57 Chris Wilson
2018-08-08 9:30 ` ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2018-08-08 8:57 UTC (permalink / raw)
To: intel-gfx
On flushing the tests, we do so with a timeout to prevent waiting
indefinitely. However, if we miss an interrupt, the timeout provides a
safety net that still completes successfully (as we check the completion
condition after reaching the timeout and see all is well). This safety
net can unfortunately mask some bugs, so let's add a warning here so we
don't just ignore it.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/selftests/igt_flush_test.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/igt_flush_test.c b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
index af66e3d4e23a..da620ed7cc36 100644
--- a/drivers/gpu/drm/i915/selftests/igt_flush_test.c
+++ b/drivers/gpu/drm/i915/selftests/igt_flush_test.c
@@ -19,7 +19,8 @@ int igt_flush_test(struct drm_i915_private *i915, unsigned int flags)
i915_gem_set_wedged(i915);
}
- if (i915_gem_wait_for_idle(i915, flags, HZ / 5) == -ETIME) {
+ switch (i915_gem_wait_for_idle(i915, flags, HZ / 5)) {
+ case -ETIME:
pr_err("%pS timed out, cancelling all further testing.\n",
__builtin_return_address(0));
@@ -27,6 +28,12 @@ int igt_flush_test(struct drm_i915_private *i915, unsigned int flags)
GEM_TRACE_DUMP();
i915_gem_set_wedged(i915);
+ break;
+
+ case 0:
+ pr_err("%pS missed idle-completion interrupt\n",
+ __builtin_return_address(0));
+ break;
}
return i915_terminally_wedged(&i915->gpu_error) ? -EIO : 0;
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/selftests: Be loud if we run out of time
2018-08-08 8:57 [PATCH] drm/i915/selftests: Be loud if we run out of time Chris Wilson
@ 2018-08-08 9:30 ` Patchwork
2018-08-08 9:33 ` Chris Wilson
0 siblings, 1 reply; 4+ messages in thread
From: Patchwork @ 2018-08-08 9:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Be loud if we run out of time
URL : https://patchwork.freedesktop.org/series/47864/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4632 -> Patchwork_9879 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9879 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9879, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47864/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9879:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@live_hangcheck:
fi-snb-2520m: PASS -> DMESG-WARN
{fi-bdw-samus}: PASS -> DMESG-WARN
{fi-kbl-8809g}: PASS -> DMESG-WARN
fi-hsw-peppy: PASS -> DMESG-WARN
fi-cnl-psr: PASS -> DMESG-WARN
fi-kbl-7500u: PASS -> DMESG-WARN
fi-hsw-4770r: PASS -> DMESG-WARN
fi-kbl-7560u: PASS -> DMESG-WARN
fi-bdw-5557u: PASS -> DMESG-WARN
fi-skl-6700hq: PASS -> DMESG-WARN
fi-skl-gvtdvm: PASS -> DMESG-WARN
fi-skl-6700k2: PASS -> DMESG-WARN
fi-elk-e7500: PASS -> DMESG-WARN
fi-byt-j1900: PASS -> DMESG-WARN
fi-blb-e6850: PASS -> DMESG-WARN
fi-cfl-guc: PASS -> DMESG-FAIL
fi-skl-6600u: PASS -> DMESG-WARN
fi-pnv-d510: PASS -> DMESG-WARN
{fi-bsw-kefka}: PASS -> DMESG-WARN
fi-cfl-8700k: PASS -> DMESG-WARN
fi-kbl-r: PASS -> DMESG-WARN
fi-byt-n2820: PASS -> DMESG-WARN
{fi-byt-clapper}: PASS -> DMESG-WARN
{fi-cfl-8109u}: PASS -> DMESG-WARN
fi-kbl-guc: PASS -> DMESG-WARN
fi-cfl-s3: PASS -> DMESG-WARN
fi-bwr-2160: PASS -> DMESG-WARN
fi-snb-2600: PASS -> DMESG-WARN
fi-skl-6770hq: PASS -> DMESG-WARN
fi-whl-u: PASS -> DMESG-WARN
fi-ivb-3520m: PASS -> DMESG-WARN
fi-hsw-4770: PASS -> DMESG-WARN
fi-bxt-dsi: PASS -> DMESG-WARN
fi-bxt-j4205: PASS -> DMESG-WARN
{fi-skl-iommu}: PASS -> DMESG-WARN
fi-glk-j4005: PASS -> DMESG-WARN
fi-ivb-3770: PASS -> DMESG-WARN
fi-ilk-650: PASS -> DMESG-WARN
fi-bsw-n3050: PASS -> DMESG-WARN
fi-bdw-gvtdvm: PASS -> DMESG-WARN
fi-kbl-x1275: PASS -> DMESG-WARN
fi-kbl-7567u: PASS -> DMESG-WARN
fi-glk-dsi: PASS -> DMESG-WARN
==== Warnings ====
igt@drv_selftest@live_guc:
fi-skl-6260u: PASS -> SKIP +1
igt@drv_selftest@live_hangcheck:
fi-skl-guc: DMESG-FAIL (fdo#107174) -> DMESG-WARN
== Known issues ==
Here are the changes found in Patchwork_9879 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-skl-6260u: PASS -> DMESG-FAIL (fdo#106560)
igt@drv_selftest@live_workarounds:
fi-kbl-x1275: PASS -> DMESG-FAIL (fdo#107292)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
{fi-byt-clapper}: PASS -> FAIL (fdo#103191, fdo#107362)
==== Possible fixes ====
igt@drv_selftest@live_workarounds:
fi-bdw-5557u: DMESG-FAIL (fdo#107292) -> PASS
fi-cnl-psr: DMESG-FAIL (fdo#107292) -> PASS
==== Warnings ====
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-FAIL (fdo#107372) -> DMESG-WARN (fdo#107372)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
== Participating hosts (52 -> 46) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551
== Build changes ==
* Linux: CI_DRM_4632 -> Patchwork_9879
CI_DRM_4632: 648e2ff1094eabf43613f41d4d719c1a1f555dbb @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4587: 5d78c73d871525ec9caecd88ad7d9abe36637314 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9879: d440b9ccec4523c3ebc9d99e3db2e7b0c0131fed @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d440b9ccec45 drm/i915/selftests: Be loud if we run out of time
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9879/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915/selftests: Be loud if we run out of time
2018-08-08 9:30 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-08-08 9:33 ` Chris Wilson
2018-08-08 9:49 ` Chris Wilson
0 siblings, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2018-08-08 9:33 UTC (permalink / raw)
To: Patchwork; +Cc: intel-gfx
Quoting Patchwork (2018-08-08 10:30:10)
> == Series Details ==
>
> Series: drm/i915/selftests: Be loud if we run out of time
> URL : https://patchwork.freedesktop.org/series/47864/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4632 -> Patchwork_9879 =
>
> == Summary - FAILURE ==
>
> Serious unknown changes coming with Patchwork_9879 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_9879, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://patchwork.freedesktop.org/api/1.0/series/47864/revisions/1/mbox/
>
> == Possible new issues ==
>
> Here are the unknown changes that may have been introduced in Patchwork_9879:
>
> === IGT changes ===
>
> ==== Possible regressions ====
>
> igt@drv_selftest@live_hangcheck:
> fi-snb-2520m: PASS -> DMESG-WARN
> {fi-bdw-samus}: PASS -> DMESG-WARN
> {fi-kbl-8809g}: PASS -> DMESG-WARN
> fi-hsw-peppy: PASS -> DMESG-WARN
> fi-cnl-psr: PASS -> DMESG-WARN
> fi-kbl-7500u: PASS -> DMESG-WARN
> fi-hsw-4770r: PASS -> DMESG-WARN
> fi-kbl-7560u: PASS -> DMESG-WARN
> fi-bdw-5557u: PASS -> DMESG-WARN
> fi-skl-6700hq: PASS -> DMESG-WARN
> fi-skl-gvtdvm: PASS -> DMESG-WARN
> fi-skl-6700k2: PASS -> DMESG-WARN
> fi-elk-e7500: PASS -> DMESG-WARN
> fi-byt-j1900: PASS -> DMESG-WARN
> fi-blb-e6850: PASS -> DMESG-WARN
> fi-cfl-guc: PASS -> DMESG-FAIL
> fi-skl-6600u: PASS -> DMESG-WARN
> fi-pnv-d510: PASS -> DMESG-WARN
> {fi-bsw-kefka}: PASS -> DMESG-WARN
> fi-cfl-8700k: PASS -> DMESG-WARN
> fi-kbl-r: PASS -> DMESG-WARN
> fi-byt-n2820: PASS -> DMESG-WARN
> {fi-byt-clapper}: PASS -> DMESG-WARN
> {fi-cfl-8109u}: PASS -> DMESG-WARN
> fi-kbl-guc: PASS -> DMESG-WARN
> fi-cfl-s3: PASS -> DMESG-WARN
> fi-bwr-2160: PASS -> DMESG-WARN
> fi-snb-2600: PASS -> DMESG-WARN
> fi-skl-6770hq: PASS -> DMESG-WARN
> fi-whl-u: PASS -> DMESG-WARN
> fi-ivb-3520m: PASS -> DMESG-WARN
> fi-hsw-4770: PASS -> DMESG-WARN
> fi-bxt-dsi: PASS -> DMESG-WARN
> fi-bxt-j4205: PASS -> DMESG-WARN
> {fi-skl-iommu}: PASS -> DMESG-WARN
> fi-glk-j4005: PASS -> DMESG-WARN
> fi-ivb-3770: PASS -> DMESG-WARN
> fi-ilk-650: PASS -> DMESG-WARN
> fi-bsw-n3050: PASS -> DMESG-WARN
> fi-bdw-gvtdvm: PASS -> DMESG-WARN
> fi-kbl-x1275: PASS -> DMESG-WARN
> fi-kbl-7567u: PASS -> DMESG-WARN
> fi-glk-dsi: PASS -> DMESG-WARN
Uh oh, that's worse than I thought.
Something in the test setup is disabling interrupts? Maybe.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915/selftests: Be loud if we run out of time
2018-08-08 9:33 ` Chris Wilson
@ 2018-08-08 9:49 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2018-08-08 9:49 UTC (permalink / raw)
To: Patchwork; +Cc: intel-gfx
Quoting Chris Wilson (2018-08-08 10:33:56)
> Quoting Patchwork (2018-08-08 10:30:10)
> > == Series Details ==
> >
> > Series: drm/i915/selftests: Be loud if we run out of time
> > URL : https://patchwork.freedesktop.org/series/47864/
> > State : failure
> >
> > == Summary ==
> >
> > = CI Bug Log - changes from CI_DRM_4632 -> Patchwork_9879 =
> >
> > == Summary - FAILURE ==
> >
> > Serious unknown changes coming with Patchwork_9879 absolutely need to be
> > verified manually.
> >
> > If you think the reported changes have nothing to do with the changes
> > introduced in Patchwork_9879, please notify your bug team to allow them
> > to document this new failure mode, which will reduce false positives in CI.
> >
> > External URL: https://patchwork.freedesktop.org/api/1.0/series/47864/revisions/1/mbox/
> >
> > == Possible new issues ==
> >
> > Here are the unknown changes that may have been introduced in Patchwork_9879:
> >
> > === IGT changes ===
> >
> > ==== Possible regressions ====
> >
> > igt@drv_selftest@live_hangcheck:
> > fi-snb-2520m: PASS -> DMESG-WARN
> > {fi-bdw-samus}: PASS -> DMESG-WARN
> > {fi-kbl-8809g}: PASS -> DMESG-WARN
> > fi-hsw-peppy: PASS -> DMESG-WARN
> > fi-cnl-psr: PASS -> DMESG-WARN
> > fi-kbl-7500u: PASS -> DMESG-WARN
> > fi-hsw-4770r: PASS -> DMESG-WARN
> > fi-kbl-7560u: PASS -> DMESG-WARN
> > fi-bdw-5557u: PASS -> DMESG-WARN
> > fi-skl-6700hq: PASS -> DMESG-WARN
> > fi-skl-gvtdvm: PASS -> DMESG-WARN
> > fi-skl-6700k2: PASS -> DMESG-WARN
> > fi-elk-e7500: PASS -> DMESG-WARN
> > fi-byt-j1900: PASS -> DMESG-WARN
> > fi-blb-e6850: PASS -> DMESG-WARN
> > fi-cfl-guc: PASS -> DMESG-FAIL
> > fi-skl-6600u: PASS -> DMESG-WARN
> > fi-pnv-d510: PASS -> DMESG-WARN
> > {fi-bsw-kefka}: PASS -> DMESG-WARN
> > fi-cfl-8700k: PASS -> DMESG-WARN
> > fi-kbl-r: PASS -> DMESG-WARN
> > fi-byt-n2820: PASS -> DMESG-WARN
> > {fi-byt-clapper}: PASS -> DMESG-WARN
> > {fi-cfl-8109u}: PASS -> DMESG-WARN
> > fi-kbl-guc: PASS -> DMESG-WARN
> > fi-cfl-s3: PASS -> DMESG-WARN
> > fi-bwr-2160: PASS -> DMESG-WARN
> > fi-snb-2600: PASS -> DMESG-WARN
> > fi-skl-6770hq: PASS -> DMESG-WARN
> > fi-whl-u: PASS -> DMESG-WARN
> > fi-ivb-3520m: PASS -> DMESG-WARN
> > fi-hsw-4770: PASS -> DMESG-WARN
> > fi-bxt-dsi: PASS -> DMESG-WARN
> > fi-bxt-j4205: PASS -> DMESG-WARN
> > {fi-skl-iommu}: PASS -> DMESG-WARN
> > fi-glk-j4005: PASS -> DMESG-WARN
> > fi-ivb-3770: PASS -> DMESG-WARN
> > fi-ilk-650: PASS -> DMESG-WARN
> > fi-bsw-n3050: PASS -> DMESG-WARN
> > fi-bdw-gvtdvm: PASS -> DMESG-WARN
> > fi-kbl-x1275: PASS -> DMESG-WARN
> > fi-kbl-7567u: PASS -> DMESG-WARN
> > fi-glk-dsi: PASS -> DMESG-WARN
>
> Uh oh, that's worse than I thought.
>
> Something in the test setup is disabling interrupts? Maybe.
Simpler. The wait_for_idle is an int error return not the long timeout
return. Silly me,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-08 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08 8:57 [PATCH] drm/i915/selftests: Be loud if we run out of time Chris Wilson
2018-08-08 9:30 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-08-08 9:33 ` Chris Wilson
2018-08-08 9:49 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.