* [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal
@ 2018-08-16 14:09 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2018-08-16 14:09 UTC (permalink / raw)
To: thierry.reding
Cc: dri-devel, linux-kernel, seanpaul, briannorris, hl, nickey.yang,
Heiko Stuebner
There is no need to check innolux->base.dev when trying to remove
the panel, as that variable is always set directly before the panel
gets added and will still be available on panel_remove.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index 72edb334d997..ca4ae45dd307 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -506,8 +506,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
static void innolux_panel_del(struct innolux_panel *innolux)
{
- if (innolux->base.dev)
- drm_panel_remove(&innolux->base);
+ drm_panel_remove(&innolux->base);
}
static int innolux_panel_probe(struct mipi_dsi_device *dsi)
--
2.17.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal
@ 2018-08-16 14:09 ` Heiko Stuebner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2018-08-16 14:09 UTC (permalink / raw)
To: thierry.reding
Cc: hl, briannorris, linux-kernel, dri-devel, nickey.yang, seanpaul
There is no need to check innolux->base.dev when trying to remove
the panel, as that variable is always set directly before the panel
gets added and will still be available on panel_remove.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
index 72edb334d997..ca4ae45dd307 100644
--- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
+++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
@@ -506,8 +506,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
static void innolux_panel_del(struct innolux_panel *innolux)
{
- if (innolux->base.dev)
- drm_panel_remove(&innolux->base);
+ drm_panel_remove(&innolux->base);
}
static int innolux_panel_probe(struct mipi_dsi_device *dsi)
--
2.17.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal
2018-08-16 14:09 ` Heiko Stuebner
@ 2018-08-16 14:40 ` Philipp Zabel
-1 siblings, 0 replies; 5+ messages in thread
From: Philipp Zabel @ 2018-08-16 14:40 UTC (permalink / raw)
To: Heiko Stuebner, thierry.reding
Cc: hl, briannorris, linux-kernel, dri-devel, nickey.yang, seanpaul
On Thu, 2018-08-16 at 16:09 +0200, Heiko Stuebner wrote:
> There is no need to check innolux->base.dev when trying to remove
> the panel, as that variable is always set directly before the panel
> gets added and will still be available on panel_remove.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index 72edb334d997..ca4ae45dd307 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -506,8 +506,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
>
> static void innolux_panel_del(struct innolux_panel *innolux)
> {
> - if (innolux->base.dev)
> - drm_panel_remove(&innolux->base);
> + drm_panel_remove(&innolux->base);
> }
>
> static int innolux_panel_probe(struct mipi_dsi_device *dsi)
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal
@ 2018-08-16 14:40 ` Philipp Zabel
0 siblings, 0 replies; 5+ messages in thread
From: Philipp Zabel @ 2018-08-16 14:40 UTC (permalink / raw)
To: Heiko Stuebner, thierry.reding
Cc: hl, briannorris, linux-kernel, dri-devel, nickey.yang, seanpaul
On Thu, 2018-08-16 at 16:09 +0200, Heiko Stuebner wrote:
> There is no need to check innolux->base.dev when trying to remove
> the panel, as that variable is always set directly before the panel
> gets added and will still be available on panel_remove.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index 72edb334d997..ca4ae45dd307 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -506,8 +506,7 @@ static int innolux_panel_add(struct mipi_dsi_device *dsi,
>
> static void innolux_panel_del(struct innolux_panel *innolux)
> {
> - if (innolux->base.dev)
> - drm_panel_remove(&innolux->base);
> + drm_panel_remove(&innolux->base);
> }
>
> static int innolux_panel_probe(struct mipi_dsi_device *dsi)
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal
2018-08-16 14:09 ` Heiko Stuebner
(?)
(?)
@ 2018-09-27 12:05 ` Thierry Reding
-1 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2018-09-27 12:05 UTC (permalink / raw)
To: Heiko Stuebner
Cc: dri-devel, linux-kernel, seanpaul, briannorris, hl, nickey.yang
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
On Thu, Aug 16, 2018 at 04:09:20PM +0200, Heiko Stuebner wrote:
> There is no need to check innolux->base.dev when trying to remove
> the panel, as that variable is always set directly before the panel
> gets added and will still be available on panel_remove.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-27 12:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-16 14:09 [PATCH] drm/panel: p079zca: unconditionally remove the panel on removal Heiko Stuebner
2018-08-16 14:09 ` Heiko Stuebner
2018-08-16 14:40 ` Philipp Zabel
2018-08-16 14:40 ` Philipp Zabel
2018-09-27 12:05 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.