* [Fuego] [PATCH 1/5] Functional.curl: change server URL @ 2018-08-27 6:12 Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path Qiu Tingting ` (3 more replies) 0 siblings, 4 replies; 13+ messages in thread From: Qiu Tingting @ 2018-08-27 6:12 UTC (permalink / raw) To: fuego When internet is unable to access, use jenkins URL to test.The IP of jenkins can be specified in board. Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> --- engine/tests/Functional.curl/fuego_test.sh | 56 ++++++++++++++++++++++++++---- 1 file changed, 50 insertions(+), 6 deletions(-) diff --git a/engine/tests/Functional.curl/fuego_test.sh b/engine/tests/Functional.curl/fuego_test.sh index 582544e..69bd68c 100755 --- a/engine/tests/Functional.curl/fuego_test.sh +++ b/engine/tests/Functional.curl/fuego_test.sh @@ -4,12 +4,56 @@ function test_pre_check { } function test_run { - report "if curl -o test.html www.baidu.com > /dev/null; then echo 'TEST-1 OK'; else echo 'TEST-1 FAILED'; fi;\ - if curl -i -r 0-1024 http://www.sina.com.cn -o sina_part1.html > /dev/null; then echo 'TEST-2 OK'; else echo 'TEST-2 FAILED'; fi;\ - if curl -v www.baidu.com > /dev/null; then echo 'TEST-3 OK'; else echo 'TEST-3 FAILED'; fi;\ - if curl -V > /dev/null; then echo 'TEST-4 OK'; else echo 'TEST-4 FAILED'; fi;\ - if curl -y 30 www.baidu.com > /dev/null; then echo 'TEST-5 OK'; else echo 'TEST-5 FAILED'; fi;\ - if curl -q www.baidu.com > /dev/null;then echo Enter && echo 'TEST-6 OK'; else echo 'TEST-6 FAILED'; fi" + report "if curl -o test.html www.baidu.com > /dev/null; then\ + echo 'TEST-1 OK';\ + else\ + if curl -o test.html $SRV_IP/fuego > /dev/null; then\ + echo 'TEST-1 OK';\ + else\ + echo 'TEST-1 FAILED';\ + fi;\ + fi;\ + if curl -i -r 0-1024 http://www.sina.com.cn -o sina_part1.html > /dev/null; then\ + echo 'TEST-2 OK';\ + else\ + if curl -i -r 0-1024 $SRV_IP/fuego -o fuego.html > /dev/null; then\ + echo 'TEST-2 OK';\ + else\ + echo 'TEST-2 FAILED';\ + fi;\ + fi;\ + if curl -v www.baidu.com > /dev/null; then\ + echo 'TEST-3 OK';\ + else\ + if curl -v $SRV_IP/fuego > /dev/null; then\ + echo 'TEST-3 OK';\ + else\ + echo 'TEST-3 FAILED';\ + fi;\ + fi;\ + if curl -V > /dev/null; then\ + echo 'TEST-4 OK';\ + else\ + echo 'TEST-4 FAILED';\ + fi;\ + if curl -y 30 www.baidu.com > /dev/null; then\ + echo 'TEST-5 OK';\ + else\ + if curl -y 30 $SRV_IP/fuego > /dev/null; then\ + echo 'TEST-5 OK';\ + else\ + echo 'TEST-5 FAILED';\ + fi;\ + fi;\ + if curl -q www.baidu.com > /dev/null;then\ + echo Enter && echo 'TEST-6 OK';\ + else\ + if curl -q $SRV_IP/fuego > /dev/null;then\ + echo Enter && echo 'TEST-6 OK';\ + else\ + echo 'TEST-6 FAILED';\ + fi;\ + fi" } function test_processing { -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path 2018-08-27 6:12 [Fuego] [PATCH 1/5] Functional.curl: change server URL Qiu Tingting @ 2018-08-27 6:12 ` Qiu Tingting 2018-11-09 4:13 ` Tim.Bird 2018-08-27 6:12 ` [Fuego] [PATCH 3/5] Functional.giflib: add config.guess and config.sub Qiu Tingting ` (2 subsequent siblings) 3 siblings, 1 reply; 13+ messages in thread From: Qiu Tingting @ 2018-08-27 6:12 UTC (permalink / raw) To: fuego detail: 1. delete check of useradd 2. run useradd with absolute path 3. modify realpath Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> --- engine/tests/Functional.glibc/fuego_test.sh | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/engine/tests/Functional.glibc/fuego_test.sh b/engine/tests/Functional.glibc/fuego_test.sh index 57ce600..f065b0d 100755 --- a/engine/tests/Functional.glibc/fuego_test.sh +++ b/engine/tests/Functional.glibc/fuego_test.sh @@ -2,13 +2,6 @@ tarball=glibc_tests.tar.gz NEED_ROOT=1 -function test_pre_check { - is_on_target_path useradd PROGRAM_USERADD - assert_define PROGRAM_USERADD - is_on_target_path userdel PROGRAM_USERDEL - assert_define PROGRAM_USERDEL -} - function test_build { sed -i -e '1i\#define _XOPEN_SOURCE' libnss_test/libnss_compat.c patch -p1 -N -s < $TEST_HOME/glibc-test-dl-return-code-fix.patch @@ -29,13 +22,13 @@ function test_build { if ./anl localhost; then echo 'TEST-9 OK'; else echo 'TEST-9 FAIL'; fi; if ./nsl; then echo 'TEST-10 OK'; else echo 'TEST-10 FAIL'; fi; - useradd fuego_test_special; + /usr/sbin/useradd fuego_test_special; passwd fuego_test_special << EOF hello hello EOF if ./nss_compat fuego_test_special hello; then echo 'TEST-11 OK'; else echo 'TEST-11 FAIL'; fi; - userdel fuego_test_special; rm /home/test/ -rf; + /usr/sbin/userdel fuego_test_special; rm /home/test/ -rf; cp /etc/nsswitch.conf nsswitch.conf.bk; sed 's/^hosts.*$/hosts: files/g' nsswitch.conf.bk > /etc/nsswitch.conf; @@ -47,7 +40,7 @@ EOF if ./nss localhost; then echo 'TEST-13 OK'; else echo 'TEST-13 FAIL'; fi; cp nsswitch.conf.bk /etc/nsswitch.conf; - if [ -f $(realpath /lib/libBrokenLocale.so.1) ] + if [ -f \$(realpath /lib/libBrokenLocale.so.1) ] then echo 'TEST-14 OK'; else echo 'TEST-14 FAIL'; fi; " > run-tests.sh -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path 2018-08-27 6:12 ` [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path Qiu Tingting @ 2018-11-09 4:13 ` Tim.Bird 2018-11-09 7:05 ` Qiu, Tingting 0 siblings, 1 reply; 13+ messages in thread From: Tim.Bird @ 2018-11-09 4:13 UTC (permalink / raw) To: qiutt, fuego > -----Original Message----- > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > detail: 1. delete check of useradd > 2. run useradd with absolute path > 3. modify realpath > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > --- > engine/tests/Functional.glibc/fuego_test.sh | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/engine/tests/Functional.glibc/fuego_test.sh > b/engine/tests/Functional.glibc/fuego_test.sh > index 57ce600..f065b0d 100755 > --- a/engine/tests/Functional.glibc/fuego_test.sh > +++ b/engine/tests/Functional.glibc/fuego_test.sh > @@ -2,13 +2,6 @@ tarball=glibc_tests.tar.gz > > NEED_ROOT=1 > > -function test_pre_check { > - is_on_target_path useradd PROGRAM_USERADD > - assert_define PROGRAM_USERADD > - is_on_target_path userdel PROGRAM_USERDEL > - assert_define PROGRAM_USERDEL This doesn't make any sense to me. useradd and userdel are still being used on the target board during the test, so they are still dependencies, whether we use an absolute path to access them or not. This dependency should stay. > -} > - > function test_build { > sed -i -e '1i\#define _XOPEN_SOURCE' libnss_test/libnss_compat.c > patch -p1 -N -s < $TEST_HOME/glibc-test-dl-return-code-fix.patch > @@ -29,13 +22,13 @@ function test_build { > if ./anl localhost; then echo 'TEST-9 OK'; else echo 'TEST-9 FAIL'; fi; > if ./nsl; then echo 'TEST-10 OK'; else echo 'TEST-10 FAIL'; fi; > > - useradd fuego_test_special; > + /usr/sbin/useradd fuego_test_special; > passwd fuego_test_special << EOF > hello > hello > EOF > if ./nss_compat fuego_test_special hello; then echo 'TEST-11 OK'; else > echo 'TEST-11 FAIL'; fi; > - userdel fuego_test_special; rm /home/test/ -rf; > + /usr/sbin/userdel fuego_test_special; rm /home/test/ -rf; What is the purpose of using an absolute path here? > > cp /etc/nsswitch.conf nsswitch.conf.bk; > sed 's/^hosts.*$/hosts: files/g' nsswitch.conf.bk > /etc/nsswitch.conf; > @@ -47,7 +40,7 @@ EOF > if ./nss localhost; then echo 'TEST-13 OK'; else echo 'TEST-13 FAIL'; fi; > cp nsswitch.conf.bk /etc/nsswitch.conf; > > - if [ -f $(realpath /lib/libBrokenLocale.so.1) ] > + if [ -f \$(realpath /lib/libBrokenLocale.so.1) ] This seems like an important fix. I added it in a new commit, with a reported-by for you. > then echo 'TEST-14 OK'; else echo 'TEST-14 FAIL'; fi; > " > run-tests.sh > > -- > 2.7.4 The rest of the patch was not applied. Thank you for the submission. If you have an explanation for removing the dependency or using absolute paths, please let me know and we can discuss it. -- Tim ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path 2018-11-09 4:13 ` Tim.Bird @ 2018-11-09 7:05 ` Qiu, Tingting 0 siblings, 0 replies; 13+ messages in thread From: Qiu, Tingting @ 2018-11-09 7:05 UTC (permalink / raw) To: Tim.Bird; +Cc: fuego Hi,Tim Thanks for your reply. > > - userdel fuego_test_special; rm /home/test/ -rf; > > + /usr/sbin/userdel fuego_test_special; rm /home/test/ -rf; > What is the purpose of using an absolute path here? When I run this case with fuego, this command is not been found. When use non-interactive non-login mode to run scripts with fuego, sbin(/usr/sbin) is not added to the PATH on my board. So maybe an absolute path is better. Regards, Qiu Tingting > -----Original Message----- > From: Tim.Bird@sony.com [mailto:Tim.Bird@sony.com] > Sent: Friday, November 09, 2018 1:14 PM > To: Qiu, Tingting/仇 婷婷; fuego@lists.linuxfoundation.org > Subject: RE: [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and > absolute path > > > > > -----Original Message----- > > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > > > detail: 1. delete check of useradd > > 2. run useradd with absolute path > > 3. modify realpath > > > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > > --- > > engine/tests/Functional.glibc/fuego_test.sh | 13 +++---------- > > 1 file changed, 3 insertions(+), 10 deletions(-) > > > > diff --git a/engine/tests/Functional.glibc/fuego_test.sh > > b/engine/tests/Functional.glibc/fuego_test.sh > > index 57ce600..f065b0d 100755 > > --- a/engine/tests/Functional.glibc/fuego_test.sh > > +++ b/engine/tests/Functional.glibc/fuego_test.sh > > @@ -2,13 +2,6 @@ tarball=glibc_tests.tar.gz > > > > NEED_ROOT=1 > > > > -function test_pre_check { > > - is_on_target_path useradd PROGRAM_USERADD > > - assert_define PROGRAM_USERADD > > - is_on_target_path userdel PROGRAM_USERDEL > > - assert_define PROGRAM_USERDEL > > This doesn't make any sense to me. useradd and userdel are > still being used on the target board during the test, so they > are still dependencies, whether we use an absolute path > to access them or not. > > This dependency should stay. > > > > -} > > - > > function test_build { > > sed -i -e '1i\#define _XOPEN_SOURCE' libnss_test/libnss_compat.c > > patch -p1 -N -s < $TEST_HOME/glibc-test-dl-return-code-fix.patch > > @@ -29,13 +22,13 @@ function test_build { > > if ./anl localhost; then echo 'TEST-9 OK'; else echo 'TEST-9 FAIL'; > fi; > > if ./nsl; then echo 'TEST-10 OK'; else echo 'TEST-10 FAIL'; > fi; > > > > - useradd fuego_test_special; > > + /usr/sbin/useradd fuego_test_special; > > passwd fuego_test_special << EOF > > hello > > hello > > EOF > > if ./nss_compat fuego_test_special hello; then echo 'TEST-11 OK'; > else > > echo 'TEST-11 FAIL'; fi; > > - userdel fuego_test_special; rm /home/test/ -rf; > > + /usr/sbin/userdel fuego_test_special; rm /home/test/ -rf; > What is the purpose of using an absolute path here? > > > > > cp /etc/nsswitch.conf nsswitch.conf.bk; > > sed 's/^hosts.*$/hosts: files/g' nsswitch.conf.bk > > /etc/nsswitch.conf; > > @@ -47,7 +40,7 @@ EOF > > if ./nss localhost; then echo 'TEST-13 OK'; else echo 'TEST-13 FAIL'; > fi; > > cp nsswitch.conf.bk /etc/nsswitch.conf; > > > > - if [ -f $(realpath /lib/libBrokenLocale.so.1) ] > > + if [ -f \$(realpath /lib/libBrokenLocale.so.1) ] > This seems like an important fix. > > I added it in a new commit, with a reported-by for you. > > > > then echo 'TEST-14 OK'; else echo 'TEST-14 FAIL'; > fi; > > " > run-tests.sh > > > > -- > > 2.7.4 > > The rest of the patch was not applied. > > Thank you for the submission. If you have an explanation for removing > the dependency or using absolute paths, please let me know and we > can discuss it. > -- Tim > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 3/5] Functional.giflib: add config.guess and config.sub 2018-08-27 6:12 [Fuego] [PATCH 1/5] Functional.curl: change server URL Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path Qiu Tingting @ 2018-08-27 6:12 ` Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build Qiu Tingting 3 siblings, 0 replies; 13+ messages in thread From: Qiu Tingting @ 2018-08-27 6:12 UTC (permalink / raw) To: fuego Add config.guess and config.sub to fix build error. Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> --- engine/tests/Functional.giflib/fuego_test.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/engine/tests/Functional.giflib/fuego_test.sh b/engine/tests/Functional.giflib/fuego_test.sh index 987f099..dcdbc9f 100755 --- a/engine/tests/Functional.giflib/fuego_test.sh +++ b/engine/tests/Functional.giflib/fuego_test.sh @@ -1,6 +1,7 @@ tarball=giflib-4.1.6.tar.bz2 function test_build { + cp /usr/share/misc/config.{guess,sub} . ./configure $CONFIGURE_FLAGS make } -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path 2018-08-27 6:12 [Fuego] [PATCH 1/5] Functional.curl: change server URL Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 3/5] Functional.giflib: add config.guess and config.sub Qiu Tingting @ 2018-08-27 6:12 ` Qiu Tingting 2018-11-09 4:34 ` Tim.Bird 2018-08-27 6:12 ` [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build Qiu Tingting 3 siblings, 1 reply; 13+ messages in thread From: Qiu Tingting @ 2018-08-27 6:12 UTC (permalink / raw) To: fuego Add absolute path to fix the problem of not finding cmd(e.g. arp). Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> --- engine/tests/Functional.net-tools/fuego_test.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/engine/tests/Functional.net-tools/fuego_test.sh b/engine/tests/Functional.net-tools/fuego_test.sh index 06225fc..6f75799 100755 --- a/engine/tests/Functional.net-tools/fuego_test.sh +++ b/engine/tests/Functional.net-tools/fuego_test.sh @@ -1,11 +1,11 @@ function test_run { - report "if arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ - if hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ - if ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \ - if ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \ - if iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \ - if netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \ - if route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" + report "if /sbin/arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ + if /bin/hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ + if /sbin/ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \ + if /sbin/ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \ + if /sbin/iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \ + if /bin/netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \ + if /sbin/route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" } function test_processing { -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path 2018-08-27 6:12 ` [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path Qiu Tingting @ 2018-11-09 4:34 ` Tim.Bird 2018-11-09 6:10 ` Qiu, Tingting 0 siblings, 1 reply; 13+ messages in thread From: Tim.Bird @ 2018-11-09 4:34 UTC (permalink / raw) To: qiutt, fuego > -----Original Message----- > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > Add absolute path to fix the problem of not finding cmd(e.g. arp). > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > --- > engine/tests/Functional.net-tools/fuego_test.sh | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/engine/tests/Functional.net-tools/fuego_test.sh > b/engine/tests/Functional.net-tools/fuego_test.sh > index 06225fc..6f75799 100755 > --- a/engine/tests/Functional.net-tools/fuego_test.sh > +++ b/engine/tests/Functional.net-tools/fuego_test.sh > @@ -1,11 +1,11 @@ > function test_run { > - report "if arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ > - if hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ > - if ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \ > - if ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \ > - if iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \ > - if netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \ > - if route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > + report "if /sbin/arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; \ The 'arp' on my minnowboard is in /usr/sbin. > + if /bin/hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ > + if /sbin/ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \ > + if /sbin/ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \ > + if /sbin/iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \ > + if /bin/netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \ > + if /sbin/route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > } > > function test_processing { > -- > 2.7.4 Hmm. Do you have a board that doesn't have /sbin in the path of the user used to perform tests? Or is this something to do with a different PATH in the profile for a non-interactive user? Can you fix this in your board setup or configuration (on the board itself), rather than here? I have a board here with arp in /usr/sbin, and not /sbin, so this would cause this test to fail on my machine. So, sorry, but this is not applied. -- Tim ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path 2018-11-09 4:34 ` Tim.Bird @ 2018-11-09 6:10 ` Qiu, Tingting 2018-11-09 6:16 ` Daniel Sangorrin 0 siblings, 1 reply; 13+ messages in thread From: Qiu, Tingting @ 2018-11-09 6:10 UTC (permalink / raw) To: Tim.Bird; +Cc: fuego Hi,Tim > Hmm. Do you have a board that doesn't have /sbin in the path > of the user used to perform tests? Or is this something to do > with a different PATH in the profile for a non-interactive user? I have a board here with arp in /sbin, and not /usr/sbin. > > Can you fix this in your board setup or configuration (on the board > itself), rather than here? OK, I will change my board to fix this. Thanks for your reply. Regards, Qiu Tingting > -----Original Message----- > From: Tim.Bird@sony.com [mailto:Tim.Bird@sony.com] > Sent: Friday, November 09, 2018 1:34 PM > To: Qiu, Tingting/仇 婷婷; fuego@lists.linuxfoundation.org > Subject: RE: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path > > > > -----Original Message----- > > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > > > Add absolute path to fix the problem of not finding cmd(e.g. arp). > > > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > > --- > > engine/tests/Functional.net-tools/fuego_test.sh | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/engine/tests/Functional.net-tools/fuego_test.sh > > b/engine/tests/Functional.net-tools/fuego_test.sh > > index 06225fc..6f75799 100755 > > --- a/engine/tests/Functional.net-tools/fuego_test.sh > > +++ b/engine/tests/Functional.net-tools/fuego_test.sh > > @@ -1,11 +1,11 @@ > > function test_run { > > - report "if arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; > \ > > - if hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ > > - if ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \ > > - if ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \ > > - if iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \ > > - if netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \ > > - if route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > > + report "if /sbin/arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; > fi; \ > The 'arp' on my minnowboard is in /usr/sbin. > > > + if /bin/hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; > \ > > + if /sbin/ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; > \ > > + if /sbin/ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; > \ > > + if /sbin/iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; > \ > > + if /bin/netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; > \ > > + if /sbin/route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > > } > > > > function test_processing { > > -- > > 2.7.4 > > Hmm. Do you have a board that doesn't have /sbin in the path > of the user used to perform tests? Or is this something to do > with a different PATH in the profile for a non-interactive user? > > Can you fix this in your board setup or configuration (on the board > itself), rather than here? > > I have a board here with arp in /usr/sbin, and not /sbin, so this > would cause this test to fail on my machine. > > So, sorry, but this is not applied. > -- Tim > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path 2018-11-09 6:10 ` Qiu, Tingting @ 2018-11-09 6:16 ` Daniel Sangorrin 2018-11-09 7:13 ` Qiu, Tingting 0 siblings, 1 reply; 13+ messages in thread From: Daniel Sangorrin @ 2018-11-09 6:16 UTC (permalink / raw) To: 'Qiu, Tingting', Tim.Bird; +Cc: fuego > -----Original Message----- > From: fuego-bounces@lists.linuxfoundation.org > <fuego-bounces@lists.linuxfoundation.org> On Behalf Of Qiu, Tingting > Sent: Friday, November 9, 2018 3:10 PM > To: Tim.Bird@sony.com > Cc: fuego@lists.linuxfoundation.org > Subject: Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path > > Hi,Tim > > > Hmm. Do you have a board that doesn't have /sbin in the path > > of the user used to perform tests? Or is this something to do > > with a different PATH in the profile for a non-interactive user? > I have a board here with arp in /sbin, and not /usr/sbin. > > > > > Can you fix this in your board setup or configuration (on the board > > itself), rather than here? > OK, I will change my board to fix this. > Thanks for your reply. Another option is to use http://fuegotest.org/wiki/function_is_on_target Thanks, Daniel > Regards, > Qiu Tingting > > > -----Original Message----- > > From: Tim.Bird@sony.com [mailto:Tim.Bird@sony.com] > > Sent: Friday, November 09, 2018 1:34 PM > > To: Qiu, Tingting/仇 婷婷; fuego@lists.linuxfoundation.org > > Subject: RE: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path > > > > > > > -----Original Message----- > > > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > > > > > Add absolute path to fix the problem of not finding cmd(e.g. arp). > > > > > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > > > --- > > > engine/tests/Functional.net-tools/fuego_test.sh | 14 +++++++------- > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > diff --git a/engine/tests/Functional.net-tools/fuego_test.sh > > > b/engine/tests/Functional.net-tools/fuego_test.sh > > > index 06225fc..6f75799 100755 > > > --- a/engine/tests/Functional.net-tools/fuego_test.sh > > > +++ b/engine/tests/Functional.net-tools/fuego_test.sh > > > @@ -1,11 +1,11 @@ > > > function test_run { > > > - report "if arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; fi; > > \ > > > - if hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; \ > > > - if ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; \ > > > - if ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; \ > > > - if iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; \ > > > - if netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; \ > > > - if route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > > > + report "if /sbin/arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; > > fi; \ > > The 'arp' on my minnowboard is in /usr/sbin. > > > > > + if /bin/hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; > > \ > > > + if /sbin/ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; > > \ > > > + if /sbin/ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; > > \ > > > + if /sbin/iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; > > \ > > > + if /bin/netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; > > \ > > > + if /sbin/route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > > > } > > > > > > function test_processing { > > > -- > > > 2.7.4 > > > > Hmm. Do you have a board that doesn't have /sbin in the path > > of the user used to perform tests? Or is this something to do > > with a different PATH in the profile for a non-interactive user? > > > > Can you fix this in your board setup or configuration (on the board > > itself), rather than here? > > > > I have a board here with arp in /usr/sbin, and not /sbin, so this > > would cause this test to fail on my machine. > > > > So, sorry, but this is not applied. > > -- Tim > > > > > > > > _______________________________________________ > Fuego mailing list > Fuego@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/fuego ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path 2018-11-09 6:16 ` Daniel Sangorrin @ 2018-11-09 7:13 ` Qiu, Tingting 0 siblings, 0 replies; 13+ messages in thread From: Qiu, Tingting @ 2018-11-09 7:13 UTC (permalink / raw) To: Daniel Sangorrin, Tim.Bird; +Cc: fuego Hi,Daniel > -----Original Message----- > From: Daniel Sangorrin [mailto:daniel.sangorrin@toshiba.co.jp] > Sent: Friday, November 09, 2018 3:17 PM > To: Qiu, Tingting/仇 婷婷; Tim.Bird@sony.com > Cc: fuego@lists.linuxfoundation.org > Subject: RE: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path > > > -----Original Message----- > > From: fuego-bounces@lists.linuxfoundation.org > > <fuego-bounces@lists.linuxfoundation.org> On Behalf Of Qiu, Tingting > > Sent: Friday, November 9, 2018 3:10 PM > > To: Tim.Bird@sony.com > > Cc: fuego@lists.linuxfoundation.org > > Subject: Re: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path > > > > Hi,Tim > > > > > Hmm. Do you have a board that doesn't have /sbin in the path > > > of the user used to perform tests? Or is this something to do > > > with a different PATH in the profile for a non-interactive user? > > I have a board here with arp in /sbin, and not /usr/sbin. > > > > > > > > Can you fix this in your board setup or configuration (on the board > > > itself), rather than here? > > OK, I will change my board to fix this. > > Thanks for your reply. > > Another option is to use > http://fuegotest.org/wiki/function_is_on_target Thanks. It is a good idea. I will try it. Regards, Qiu Tingting > > Thanks, > Daniel > > > Regards, > > Qiu Tingting > > > > > -----Original Message----- > > > From: Tim.Bird@sony.com [mailto:Tim.Bird@sony.com] > > > Sent: Friday, November 09, 2018 1:34 PM > > > To: Qiu, Tingting/仇 婷婷; fuego@lists.linuxfoundation.org > > > Subject: RE: [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path > > > > > > > > > > -----Original Message----- > > > > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > > > > > > > Add absolute path to fix the problem of not finding cmd(e.g. arp). > > > > > > > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > > > > --- > > > > engine/tests/Functional.net-tools/fuego_test.sh | 14 +++++++------- > > > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/engine/tests/Functional.net-tools/fuego_test.sh > > > > b/engine/tests/Functional.net-tools/fuego_test.sh > > > > index 06225fc..6f75799 100755 > > > > --- a/engine/tests/Functional.net-tools/fuego_test.sh > > > > +++ b/engine/tests/Functional.net-tools/fuego_test.sh > > > > @@ -1,11 +1,11 @@ > > > > function test_run { > > > > - report "if arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; > fi; > > > \ > > > > - if hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; fi; > \ > > > > - if ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; fi; > \ > > > > - if ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; fi; > \ > > > > - if iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; fi; > \ > > > > - if netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; fi; > \ > > > > - if route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; fi" > > > > + report "if /sbin/arp; then echo 'TEST-1 OK'; else echo 'TEST-1 FAIL'; > > > fi; \ > > > The 'arp' on my minnowboard is in /usr/sbin. > > > > > > > + if /bin/hostname; then echo 'TEST-2 OK'; else echo 'TEST-2 FAIL'; > fi; > > > \ > > > > + if /sbin/ifconfig; then echo 'TEST-3 OK'; else echo 'TEST-3 FAIL'; > fi; > > > \ > > > > + if /sbin/ipmaddr; then echo 'TEST-4 OK'; else echo 'TEST-4 FAIL'; > fi; > > > \ > > > > + if /sbin/iptunnel; then echo 'TEST-5 OK'; else echo 'TEST-5 FAIL'; > fi; > > > \ > > > > + if /bin/netstat; then echo 'TEST-6 OK'; else echo 'TEST-6 FAIL'; > fi; > > > \ > > > > + if /sbin/route; then echo 'TEST-7 OK'; else echo 'TEST-7 FAIL'; > fi" > > > > } > > > > > > > > function test_processing { > > > > -- > > > > 2.7.4 > > > > > > Hmm. Do you have a board that doesn't have /sbin in the path > > > of the user used to perform tests? Or is this something to do > > > with a different PATH in the profile for a non-interactive user? > > > > > > Can you fix this in your board setup or configuration (on the board > > > itself), rather than here? > > > > > > I have a board here with arp in /usr/sbin, and not /sbin, so this > > > would cause this test to fail on my machine. > > > > > > So, sorry, but this is not applied. > > > -- Tim > > > > > > > > > > > > > > _______________________________________________ > > Fuego mailing list > > Fuego@lists.linuxfoundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/fuego > > ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build 2018-08-27 6:12 [Fuego] [PATCH 1/5] Functional.curl: change server URL Qiu Tingting ` (2 preceding siblings ...) 2018-08-27 6:12 ` [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path Qiu Tingting @ 2018-08-27 6:12 ` Qiu Tingting 2018-11-09 4:27 ` Tim.Bird 3 siblings, 1 reply; 13+ messages in thread From: Qiu Tingting @ 2018-08-27 6:12 UTC (permalink / raw) To: fuego detail: 1.modify system-acdir option to fix the problem of non-existent dir 2.delete 'automake -a' to fix build error 3.add lib check of libneon.so.27 and libproxy.so.1 Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> --- engine/tests/Functional.neon/fuego_test.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/engine/tests/Functional.neon/fuego_test.sh b/engine/tests/Functional.neon/fuego_test.sh index 75e67b7..ddbb5d6 100755 --- a/engine/tests/Functional.neon/fuego_test.sh +++ b/engine/tests/Functional.neon/fuego_test.sh @@ -1,8 +1,10 @@ tarball=neon-test.tar.bz2 function test_pre_check { - is_on_target libneon.so LIB_NEON /lib:/usr/lib:/usr/local/lib + is_on_target libneon.so.27 LIB_NEON /lib:/usr/lib:/usr/local/lib assert_define LIB_NEON + is_on_target libproxy.so.1 LIB_PROXY /lib:/usr/lib:/usr/local/lib + assert_define LIB_PROXY } function test_build { @@ -11,11 +13,11 @@ function test_build { patch -p0 < pkgconfig.patch cd ./neon-0.30.1 libtoolize --automake - aclocal --system-acdir=${SDKROOT}usr/share/aclocal + aclocal --system-acdir=${SDKROOT}/usr/share/aclocal autoreconf --verbose --install --force --exclude=autopoint -I macros autoconf autoheader - automake -a +# automake -a ./configure --host=$PREFIX --with-libxml2 -with-expat --enable-shared --without-gssapi --with-ssl=gnutls CPPFLAGS="-DHAVE_GNUTLS_CERTIFICATE_SET_RETRIEVE_FUNCTION=1" make cd ./test -- 2.7.4 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build 2018-08-27 6:12 ` [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build Qiu Tingting @ 2018-11-09 4:27 ` Tim.Bird 2018-11-09 6:33 ` Qiu, Tingting 0 siblings, 1 reply; 13+ messages in thread From: Tim.Bird @ 2018-11-09 4:27 UTC (permalink / raw) To: qiutt, fuego > -----Original Message----- > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > detail: 1.modify system-acdir option to fix the problem of non-existent dir > 2.delete 'automake -a' to fix build error > 3.add lib check of libneon.so.27 and libproxy.so.1 I wish there was a bit more explanation of why libproxy.so.1 is needed here. > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > --- > engine/tests/Functional.neon/fuego_test.sh | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/engine/tests/Functional.neon/fuego_test.sh > b/engine/tests/Functional.neon/fuego_test.sh > index 75e67b7..ddbb5d6 100755 > --- a/engine/tests/Functional.neon/fuego_test.sh > +++ b/engine/tests/Functional.neon/fuego_test.sh > @@ -1,8 +1,10 @@ > tarball=neon-test.tar.bz2 > > function test_pre_check { > - is_on_target libneon.so LIB_NEON /lib:/usr/lib:/usr/local/lib > + is_on_target libneon.so.27 LIB_NEON /lib:/usr/lib:/usr/local/lib > assert_define LIB_NEON > + is_on_target libproxy.so.1 LIB_PROXY /lib:/usr/lib:/usr/local/lib > + assert_define LIB_PROXY Why is this needed. > } > > function test_build { > @@ -11,11 +13,11 @@ function test_build { > patch -p0 < pkgconfig.patch > cd ./neon-0.30.1 > libtoolize --automake > - aclocal --system-acdir=${SDKROOT}usr/share/aclocal > + aclocal --system-acdir=${SDKROOT}/usr/share/aclocal > autoreconf --verbose --install --force --exclude=autopoint -I macros > autoconf > autoheader > - automake -a > +# automake -a > ./configure --host=$PREFIX --with-libxml2 -with-expat --enable- > shared --without-gssapi --with-ssl=gnutls CPPFLAGS="- > DHAVE_GNUTLS_CERTIFICATE_SET_RETRIEVE_FUNCTION=1" > make > cd ./test > -- > 2.7.4 I don't understand all of what you've done here. But this test never worked for me before. If these changes make the test work for you, then I guess I will accept them. Having the test work for someone is better than having it work for no one. Applied. Thanks, -- Tim ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build 2018-11-09 4:27 ` Tim.Bird @ 2018-11-09 6:33 ` Qiu, Tingting 0 siblings, 0 replies; 13+ messages in thread From: Qiu, Tingting @ 2018-11-09 6:33 UTC (permalink / raw) To: Tim.Bird; +Cc: fuego Hi,Tim > -----Original Message----- > From: Tim.Bird@sony.com [mailto:Tim.Bird@sony.com] > Sent: Friday, November 09, 2018 1:28 PM > To: Qiu, Tingting/仇 婷婷; fuego@lists.linuxfoundation.org > Subject: RE: [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build > > > > > -----Original Message----- > > From: Qiu Tingting on Sunday, August 26, 2018 11:13 PM > > > > detail: 1.modify system-acdir option to fix the problem of non-existent dir > > 2.delete 'automake -a' to fix build error > > 3.add lib check of libneon.so.27 and libproxy.so.1 > I wish there was a bit more explanation of why libproxy.so.1 is needed here. If there is no libproxy.so.1 on board, this test cannot be run. So I think the lib check is needed. log: error while loading shared libraries: libproxy.so.1: cannot open shared object file: No such file or directory Regards, Qiu Tingting > > > > > Signed-off-by: Qiu Tingting <qiutt@cn.fujitsu.com> > > --- > > engine/tests/Functional.neon/fuego_test.sh | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/engine/tests/Functional.neon/fuego_test.sh > > b/engine/tests/Functional.neon/fuego_test.sh > > index 75e67b7..ddbb5d6 100755 > > --- a/engine/tests/Functional.neon/fuego_test.sh > > +++ b/engine/tests/Functional.neon/fuego_test.sh > > @@ -1,8 +1,10 @@ > > tarball=neon-test.tar.bz2 > > > > function test_pre_check { > > - is_on_target libneon.so LIB_NEON /lib:/usr/lib:/usr/local/lib > > + is_on_target libneon.so.27 LIB_NEON /lib:/usr/lib:/usr/local/lib > > assert_define LIB_NEON > > + is_on_target libproxy.so.1 LIB_PROXY /lib:/usr/lib:/usr/local/lib > > + assert_define LIB_PROXY > Why is this needed. > > > } > > > > function test_build { > > @@ -11,11 +13,11 @@ function test_build { > > patch -p0 < pkgconfig.patch > > cd ./neon-0.30.1 > > libtoolize --automake > > - aclocal --system-acdir=${SDKROOT}usr/share/aclocal > > + aclocal --system-acdir=${SDKROOT}/usr/share/aclocal > > autoreconf --verbose --install --force --exclude=autopoint -I macros > > autoconf > > autoheader > > - automake -a > > +# automake -a > > ./configure --host=$PREFIX --with-libxml2 -with-expat --enable- > > shared --without-gssapi --with-ssl=gnutls CPPFLAGS="- > > DHAVE_GNUTLS_CERTIFICATE_SET_RETRIEVE_FUNCTION=1" > > make > > cd ./test > > -- > > 2.7.4 > > I don't understand all of what you've done here. But this test never worked > for me before. If these changes make the test work for you, then I guess > I will accept them. Having the test work for someone is better than having > it work for no one. > > Applied. > > Thanks, > -- Tim > > ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-11-09 7:13 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-08-27 6:12 [Fuego] [PATCH 1/5] Functional.curl: change server URL Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 2/5] Functional.glibc: modify realpath and absolute path Qiu Tingting 2018-11-09 4:13 ` Tim.Bird 2018-11-09 7:05 ` Qiu, Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 3/5] Functional.giflib: add config.guess and config.sub Qiu Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 4/5] Functional.net-tools: add absolute path Qiu Tingting 2018-11-09 4:34 ` Tim.Bird 2018-11-09 6:10 ` Qiu, Tingting 2018-11-09 6:16 ` Daniel Sangorrin 2018-11-09 7:13 ` Qiu, Tingting 2018-08-27 6:12 ` [Fuego] [PATCH 5/5] Functional.neon: change pre-check and build Qiu Tingting 2018-11-09 4:27 ` Tim.Bird 2018-11-09 6:33 ` Qiu, Tingting
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.