All of lore.kernel.org
 help / color / mirror / Atom feed
From: Megha Dey <megha.dey@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Eric Biggers <ebiggers@kernel.org>,
	Tim Chen <tim.c.chen@linux.intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	syzbot <syzbot+d5455bac3ba1ee9114e5@syzkaller.appspotmail.com>,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
	<linux-crypto@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Re: KASAN: use-after-free Read in sha512_ctx_mgr_resubmit
Date: Mon, 27 Aug 2018 16:08:56 -0700	[thread overview]
Message-ID: <1535411336.3516.2.camel@megha-Z97X-UD7-TH> (raw)
In-Reply-To: <20180822062036.mdq4q5o5zdzuxh7s@gondor.apana.org.au>

On Wed, 2018-08-22 at 14:20 +0800, Herbert Xu wrote:
> On Tue, Aug 21, 2018 at 02:43:56PM +0200, Ard Biesheuvel wrote:
> >
> > I agree. The code is obviously broken in a way that would have been
> > noticed if it were in wide use, and it is too complicated for mere
> > mortals to fix or maintain. I suggest we simply remove it for now, and
> > if anyone wants to reintroduce it, we can review the code *and* the
> > justification for the approach from scratch (in which case we should
> > consider factoring out the algo agnostics plumbing in a way that
> > allows it to be reused by other architectures as well)
> 
> I agree too.  Could one of you guys send me a patch to remove
> them?
> 

Hi,

We are working on a fix to solve these corner cases.

-Megha
> Thanks,

  reply	other threads:[~2018-08-27 23:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 16:00 KASAN: use-after-free Read in sha512_ctx_mgr_resubmit syzbot
2018-08-20  7:31 ` Eric Biggers
2018-08-21 12:43   ` Ard Biesheuvel
2018-08-21 12:43     ` Ard Biesheuvel
2018-08-22  6:20     ` Herbert Xu
2018-08-22  6:20       ` Herbert Xu
2018-08-27 23:08       ` Megha Dey [this message]
2018-08-27 23:08         ` Megha Dey
2018-08-27 23:01         ` Ard Biesheuvel
2018-08-27 23:01           ` Ard Biesheuvel
2018-08-28 22:17           ` Megha Dey
2018-08-28 22:17             ` Megha Dey
2018-10-05 22:33 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1535411336.3516.2.camel@megha-Z97X-UD7-TH \
    --to=megha.dey@linux.intel.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzbot+d5455bac3ba1ee9114e5@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.