* [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
@ 2018-09-03 13:39 Fabio Estevam
2018-09-07 11:14 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2018-09-03 13:39 UTC (permalink / raw)
To: stable; +Cc: shawnguo, rasmus.villemoes, gregkh, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
This reverts commit df06ca1f565077596512fa2ab91df502e48e4f00.
This commit causes reboot to fail on imx6 wandboard, so let's
revert it.
Cc: <stable@vger.kernel.org> #4.17
Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 19c924d..3a30843 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -294,7 +294,6 @@ CONFIG_USB_STORAGE=y
CONFIG_USB_CHIPIDEA=y
CONFIG_USB_CHIPIDEA_UDC=y
CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_CHIPIDEA_ULPI=y
CONFIG_USB_SERIAL=m
CONFIG_USB_SERIAL_GENERIC=y
CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -331,7 +330,6 @@ CONFIG_USB_GADGETFS=m
CONFIG_USB_FUNCTIONFS=m
CONFIG_USB_MASS_STORAGE=m
CONFIG_USB_G_SERIAL=m
-CONFIG_USB_ULPI_BUS=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_PLTFM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
2018-09-03 13:39 [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support" Fabio Estevam
@ 2018-09-07 11:14 ` Greg KH
2018-09-07 11:45 ` Rasmus Villemoes
2018-09-07 17:21 ` Fabio Estevam
0 siblings, 2 replies; 7+ messages in thread
From: Greg KH @ 2018-09-07 11:14 UTC (permalink / raw)
To: Fabio Estevam; +Cc: stable, shawnguo, rasmus.villemoes, Fabio Estevam
On Mon, Sep 03, 2018 at 10:39:04AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> This reverts commit df06ca1f565077596512fa2ab91df502e48e4f00.
>
> This commit causes reboot to fail on imx6 wandboard, so let's
> revert it.
>
> Cc: <stable@vger.kernel.org> #4.17
> Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Why is this a stable-tree-only patch? What is wrong with those trees
that having this in Linus's tree (and 4.18) is ok, but stable trees are
not ok?
I don't like being out-of-sync at all, and need a very good reason why.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
2018-09-07 11:14 ` Greg KH
@ 2018-09-07 11:45 ` Rasmus Villemoes
2018-09-07 17:21 ` Fabio Estevam
1 sibling, 0 replies; 7+ messages in thread
From: Rasmus Villemoes @ 2018-09-07 11:45 UTC (permalink / raw)
To: Greg KH, Fabio Estevam; +Cc: stable, shawnguo, Fabio Estevam
On 2018-09-07 13:14, Greg KH wrote:
> On Mon, Sep 03, 2018 at 10:39:04AM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> This reverts commit df06ca1f565077596512fa2ab91df502e48e4f00.
>>
>> This commit causes reboot to fail on imx6 wandboard, so let's
>> revert it.
>>
>> Cc: <stable@vger.kernel.org> #4.17
>> Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> Why is this a stable-tree-only patch? What is wrong with those trees
> that having this in Linus's tree (and 4.18) is ok, but stable trees are
> not ok?
So, I'm only going to talk about 4.14.y, because that's where we are,
and where I saw the breakage.
Please see
<lkml.kernel.org/r/d8dd8d02-b8ed-91fd-bcc0-87dedc5998ae@prevas.dk>. To
recap, mainline was also broken between 157bcc0609 (introduced in
4.18-rc4) and a930d8bd94d (in 4.18-rc7).
Another option is to also add a930d8bd94d to 4.14.y. I think it
cherry-picks cleanly. I haven't tested precisely that, but as I wrote
above I have tested with the "business part" of a930d8bd94d applied.
Unfortunately I'm busy with other boards and tasks currently, so can't
offer more than this.
Rasmus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
2018-09-07 11:14 ` Greg KH
2018-09-07 11:45 ` Rasmus Villemoes
@ 2018-09-07 17:21 ` Fabio Estevam
1 sibling, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-09-07 17:21 UTC (permalink / raw)
To: Greg KH; +Cc: stable, Shawn Guo, Rasmus Villemoes, Fabio Estevam, Peter Chen
Hi Greg,
On Fri, Sep 7, 2018 at 8:14 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Sep 03, 2018 at 10:39:04AM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> This reverts commit df06ca1f565077596512fa2ab91df502e48e4f00.
>>03e6275ae381 ("usb: chipidea: Fix ULPI on imx51")
>> This commit causes reboot to fail on imx6 wandboard, so let's
>> revert it.
>>
>> Cc: <stable@vger.kernel.org> #4.17
>> Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>
> Why is this a stable-tree-only patch? What is wrong with those trees
> that having this in Linus's tree (and 4.18) is ok, but stable trees are
> not ok?
In Linus' tree we have a930d8bd94d8 ("usb: chipidea: Always build ULPI code "),
which removes CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS.
Since it fixes 03e6275ae381 ("usb: chipidea: Fix ULPI on imx51") then
we would also need to have this one in the stable tree.
And its equivalent fix for imx53: be9cae2479f4 ("usb: chipidea: imx:
Fix ULPI on imx53")
So in order to fix the reboot regression in stable as reported by
Rasmus I see two options:
1. Backport these three commits to stable:
a930d8bd94d8 ("usb: chipidea: Always build ULPI code ")
03e6275ae381 ("usb: chipidea: Fix ULPI on imx51")
be9cae2479f4 ("usb: chipidea: imx: Fix ULPI on imx53")
2. Just revert the defconfig change as originally proposed.
If everyone agrees that option 1 is preferred I can prepare these
patches for 4.4/4.9/4.14/4.17.
Please let me know if option 1 is the way to go.
Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
@ 2018-09-03 13:39 Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-09-03 13:39 UTC (permalink / raw)
To: stable; +Cc: shawnguo, rasmus.villemoes, gregkh, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
This reverts commit 0d0af17ae83d6feb29d676c72423461419df5110.
This commit causes reboot to fail on imx6 wandboard, so let's
revert it.
Cc: <stable@vger.kernel.org> #4.4
Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index b3490c1..4187f69 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -261,7 +261,6 @@ CONFIG_USB_STORAGE=y
CONFIG_USB_CHIPIDEA=y
CONFIG_USB_CHIPIDEA_UDC=y
CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_CHIPIDEA_ULPI=y
CONFIG_USB_SERIAL=m
CONFIG_USB_SERIAL_GENERIC=y
CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -288,7 +287,6 @@ CONFIG_USB_G_NCM=m
CONFIG_USB_GADGETFS=m
CONFIG_USB_MASS_STORAGE=m
CONFIG_USB_G_SERIAL=m
-CONFIG_USB_ULPI_BUS=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_PLTFM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
@ 2018-09-03 13:39 Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-09-03 13:39 UTC (permalink / raw)
To: stable; +Cc: shawnguo, rasmus.villemoes, gregkh, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
This reverts commit 721476147fd2571309b6aa6daa695b39170602ef.
This commit causes reboot to fail on imx6 wandboard, so let's
revert it.
Cc: <stable@vger.kernel.org> #4.9
Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 6b7d4f5..8ec4dbb 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -271,7 +271,6 @@ CONFIG_USB_STORAGE=y
CONFIG_USB_CHIPIDEA=y
CONFIG_USB_CHIPIDEA_UDC=y
CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_CHIPIDEA_ULPI=y
CONFIG_USB_SERIAL=m
CONFIG_USB_SERIAL_GENERIC=y
CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -308,7 +307,6 @@ CONFIG_USB_GADGETFS=m
CONFIG_USB_FUNCTIONFS=m
CONFIG_USB_MASS_STORAGE=m
CONFIG_USB_G_SERIAL=m
-CONFIG_USB_ULPI_BUS=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_PLTFM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support"
@ 2018-09-03 13:39 Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2018-09-03 13:39 UTC (permalink / raw)
To: stable; +Cc: shawnguo, rasmus.villemoes, gregkh, Fabio Estevam
From: Fabio Estevam <fabio.estevam@nxp.com>
This reverts commit 2059e527a659cf16d6bb709f1c8509f7a7623fc4.
This commit causes reboot to fail on imx6 wandboard, so let's
revert it.
Cc: <stable@vger.kernel.org> #4.14
Reported-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/configs/imx_v6_v7_defconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 21ac9f0..32acac9 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -289,7 +289,6 @@ CONFIG_USB_STORAGE=y
CONFIG_USB_CHIPIDEA=y
CONFIG_USB_CHIPIDEA_UDC=y
CONFIG_USB_CHIPIDEA_HOST=y
-CONFIG_USB_CHIPIDEA_ULPI=y
CONFIG_USB_SERIAL=m
CONFIG_USB_SERIAL_GENERIC=y
CONFIG_USB_SERIAL_FTDI_SIO=m
@@ -326,7 +325,6 @@ CONFIG_USB_GADGETFS=m
CONFIG_USB_FUNCTIONFS=m
CONFIG_USB_MASS_STORAGE=m
CONFIG_USB_G_SERIAL=m
-CONFIG_USB_ULPI_BUS=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
CONFIG_MMC_SDHCI_PLTFM=y
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-09-07 22:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-03 13:39 [PATCH] Revert "ARM: imx_v6_v7_defconfig: Select ULPI support" Fabio Estevam
2018-09-07 11:14 ` Greg KH
2018-09-07 11:45 ` Rasmus Villemoes
2018-09-07 17:21 ` Fabio Estevam
2018-09-03 13:39 Fabio Estevam
2018-09-03 13:39 Fabio Estevam
2018-09-03 13:39 Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.