All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] drm/i915: optimzie eDP 1.4 config
  2018-09-04 14:55 [PATCH] drm/i915: optimzie eDP 1.4 config Lee, Shawn C
@ 2018-09-04 14:28 ` Chris Wilson
  2018-09-05  9:58   ` Jani Nikula
  2018-09-05  9:58   ` Jani Nikula
  2018-09-04 15:12 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-09-04 21:05 ` ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 2 replies; 6+ messages in thread
From: Chris Wilson @ 2018-09-04 14:28 UTC (permalink / raw)
  To: Lee, Shawn C, intel-gfx; +Cc: Lee

Quoting Lee, Shawn C (2018-09-04 15:55:41)
> eDP 1.4 introduce a new link rates flexibility and selection.
> It provided system specific link rate optimization and power
> efficiency. We should keep eDP 1.3 and older version to use
> max link rate approach to avoid any side effect. And eDP 1.4
> used the optimization link rate and lane count setting.
> 
> Cc: Matt Atwood <matthew.s.atwood@intel.com>
> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 436c22de33b6..903d640fe712 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1953,8 +1953,10 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
>                  * configuration, and typically these values correspond to the
>                  * native resolution of the panel.
>                  */

Having just finished a comment explaining why we override the limits for
eDP, the following logic is confusing without at least a mention above.

> -               limits.min_lane_count = limits.max_lane_count;
> -               limits.min_clock = limits.max_clock;
> +               if (intel_dp->edp_dpcd[0] <= DP_EDP_13) {
> +                       limits.min_lane_count = limits.max_lane_count;
> +                       limits.min_clock = limits.max_clock;
> +               }
>         }
>  
>         intel_dp_adjust_compliance_config(intel_dp, pipe_config, &limits);
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] drm/i915: optimzie eDP 1.4 config
@ 2018-09-04 14:55 Lee, Shawn C
  2018-09-04 14:28 ` Chris Wilson
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Lee, Shawn C @ 2018-09-04 14:55 UTC (permalink / raw)
  To: intel-gfx; +Cc: Lee

eDP 1.4 introduce a new link rates flexibility and selection.
It provided system specific link rate optimization and power
efficiency. We should keep eDP 1.3 and older version to use
max link rate approach to avoid any side effect. And eDP 1.4
used the optimization link rate and lane count setting.

Cc: Matt Atwood <matthew.s.atwood@intel.com>
Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 436c22de33b6..903d640fe712 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1953,8 +1953,10 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
 		 * configuration, and typically these values correspond to the
 		 * native resolution of the panel.
 		 */
-		limits.min_lane_count = limits.max_lane_count;
-		limits.min_clock = limits.max_clock;
+		if (intel_dp->edp_dpcd[0] <= DP_EDP_13) {
+			limits.min_lane_count = limits.max_lane_count;
+			limits.min_clock = limits.max_clock;
+		}
 	}
 
 	intel_dp_adjust_compliance_config(intel_dp, pipe_config, &limits);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: optimzie eDP 1.4 config
  2018-09-04 14:55 [PATCH] drm/i915: optimzie eDP 1.4 config Lee, Shawn C
  2018-09-04 14:28 ` Chris Wilson
@ 2018-09-04 15:12 ` Patchwork
  2018-09-04 21:05 ` ✓ Fi.CI.IGT: " Patchwork
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-04 15:12 UTC (permalink / raw)
  To: Lee, Shawn C; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: optimzie eDP 1.4 config
URL   : https://patchwork.freedesktop.org/series/49131/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4766 -> Patchwork_10082 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49131/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_10082 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362)

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         PASS -> FAIL (fdo#104008)

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362


== Participating hosts (49 -> 44) ==

  Additional (1): fi-hsw-4770r 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-pnv-d510 


== Build changes ==

    * Linux: CI_DRM_4766 -> Patchwork_10082

  CI_DRM_4766: 0d35b9d0b3a74c41ac1ffe1a34aa9c98d2a3a0b9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4625: 67fbe2967889484f1248d851c068e1021f2dc332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10082: 2602078fba7029858fdc79ab45b750805f759ac2 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

2602078fba70 drm/i915: optimzie eDP 1.4 config

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10082/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: optimzie eDP 1.4 config
  2018-09-04 14:55 [PATCH] drm/i915: optimzie eDP 1.4 config Lee, Shawn C
  2018-09-04 14:28 ` Chris Wilson
  2018-09-04 15:12 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-04 21:05 ` Patchwork
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-04 21:05 UTC (permalink / raw)
  To: Lee, Shawn C; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: optimzie eDP 1.4 config
URL   : https://patchwork.freedesktop.org/series/49131/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4766_full -> Patchwork_10082_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_10082_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10082_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10082_full:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
      shard-snb:          PASS -> SKIP +3

    
== Known issues ==

  Here are the changes found in Patchwork_10082_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-hsw:          INCOMPLETE (fdo#103540, fdo#106886) -> PASS

    igt@gem_exec_await@wide-contexts:
      shard-glk:          FAIL (fdo#105900) -> PASS
      shard-apl:          FAIL (fdo#106680, fdo#105900) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363, fdo#102887) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu:
      shard-glk:          FAIL (fdo#103167) -> PASS +1

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4766 -> Patchwork_10082

  CI_DRM_4766: 0d35b9d0b3a74c41ac1ffe1a34aa9c98d2a3a0b9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4625: 67fbe2967889484f1248d851c068e1021f2dc332 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10082: 2602078fba7029858fdc79ab45b750805f759ac2 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10082/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: optimzie eDP 1.4 config
  2018-09-04 14:28 ` Chris Wilson
@ 2018-09-05  9:58   ` Jani Nikula
  2018-09-05  9:58   ` Jani Nikula
  1 sibling, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2018-09-05  9:58 UTC (permalink / raw)
  To: Chris Wilson, Lee, Shawn C, intel-gfx; +Cc: Lee

On Tue, 04 Sep 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Lee, Shawn C (2018-09-04 15:55:41)
>> eDP 1.4 introduce a new link rates flexibility and selection.
>> It provided system specific link rate optimization and power
>> efficiency. We should keep eDP 1.3 and older version to use
>> max link rate approach to avoid any side effect. And eDP 1.4
>> used the optimization link rate and lane count setting.
>> 
>> Cc: Matt Atwood <matthew.s.atwood@intel.com>
>> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_dp.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 436c22de33b6..903d640fe712 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -1953,8 +1953,10 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
>>                  * configuration, and typically these values correspond to the
>>                  * native resolution of the panel.
>>                  */
>
> Having just finished a comment explaining why we override the limits for
> eDP, the following logic is confusing without at least a mention above.

I think the proper approach with the appropriate explanations is [1]. I
think it's harmful to start optimizing on eDP 1.4 without also
optimizing for fast and narrow link per spec at the same time.

BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/20180905095321.13843-1-jani.nikula@intel.com



>
>> -               limits.min_lane_count = limits.max_lane_count;
>> -               limits.min_clock = limits.max_clock;
>> +               if (intel_dp->edp_dpcd[0] <= DP_EDP_13) {
>> +                       limits.min_lane_count = limits.max_lane_count;
>> +                       limits.min_clock = limits.max_clock;
>> +               }
>>         }
>>  
>>         intel_dp_adjust_compliance_config(intel_dp, pipe_config, &limits);
>> -- 
>> 2.7.4
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: optimzie eDP 1.4 config
  2018-09-04 14:28 ` Chris Wilson
  2018-09-05  9:58   ` Jani Nikula
@ 2018-09-05  9:58   ` Jani Nikula
  1 sibling, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2018-09-05  9:58 UTC (permalink / raw)
  To: Chris Wilson, Lee, Shawn C, intel-gfx

On Tue, 04 Sep 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Lee, Shawn C (2018-09-04 15:55:41)
>> eDP 1.4 introduce a new link rates flexibility and selection.
>> It provided system specific link rate optimization and power
>> efficiency. We should keep eDP 1.3 and older version to use
>> max link rate approach to avoid any side effect. And eDP 1.4
>> used the optimization link rate and lane count setting.
>> 
>> Cc: Matt Atwood <matthew.s.atwood@intel.com>
>> Signed-off-by: Lee, Shawn C <shawn.c.lee@intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_dp.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 436c22de33b6..903d640fe712 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -1953,8 +1953,10 @@ intel_dp_compute_link_config(struct intel_encoder *encoder,
>>                  * configuration, and typically these values correspond to the
>>                  * native resolution of the panel.
>>                  */
>
> Having just finished a comment explaining why we override the limits for
> eDP, the following logic is confusing without at least a mention above.

I think the proper approach with the appropriate explanations is [1]. I
think it's harmful to start optimizing on eDP 1.4 without also
optimizing for fast and narrow link per spec at the same time.

BR,
Jani.


[1] http://patchwork.freedesktop.org/patch/msgid/20180905095321.13843-1-jani.nikula@intel.com



>
>> -               limits.min_lane_count = limits.max_lane_count;
>> -               limits.min_clock = limits.max_clock;
>> +               if (intel_dp->edp_dpcd[0] <= DP_EDP_13) {
>> +                       limits.min_lane_count = limits.max_lane_count;
>> +                       limits.min_clock = limits.max_clock;
>> +               }
>>         }
>>  
>>         intel_dp_adjust_compliance_config(intel_dp, pipe_config, &limits);
>> -- 
>> 2.7.4
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-05  9:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-04 14:55 [PATCH] drm/i915: optimzie eDP 1.4 config Lee, Shawn C
2018-09-04 14:28 ` Chris Wilson
2018-09-05  9:58   ` Jani Nikula
2018-09-05  9:58   ` Jani Nikula
2018-09-04 15:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-04 21:05 ` ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.