* [PATCH -next] mmc: tegra: Fix copy-paste error in tegra_sdhci_init_pinctrl_info()
@ 2018-09-05 11:12 Wei Yongjun
2018-09-06 6:31 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-09-05 11:12 UTC (permalink / raw)
To: kernel-janitors
The error code get against a wrong variable. This patch fix it.
Fixes: 5783a9529891 ("mmc: tegra: Reconfigure pad voltages during voltage switching")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mmc/host/sdhci-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index e80716c..c789158 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
- PTR_ERR(tegra_host->pinctrl_state_3v3));
+ PTR_ERR(tegra_host->pinctrl_state_1v8));
return -1;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mmc: tegra: Fix copy-paste error in tegra_sdhci_init_pinctrl_info()
2018-09-05 11:12 [PATCH -next] mmc: tegra: Fix copy-paste error in tegra_sdhci_init_pinctrl_info() Wei Yongjun
@ 2018-09-06 6:31 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2018-09-06 6:31 UTC (permalink / raw)
To: kernel-janitors
On 5 September 2018 at 13:12, Wei Yongjun <weiyongjun1@huawei.com> wrote:
> The error code get against a wrong variable. This patch fix it.
>
> Fixes: 5783a9529891 ("mmc: tegra: Reconfigure pad voltages during voltage switching")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks for the patch, however I have already queued a patch in my next
branch fixing this problem.
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index e80716c..c789158 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -724,7 +724,7 @@ static int tegra_sdhci_init_pinctrl_info(struct device *dev,
> pinctrl_lookup_state(tegra_host->pinctrl_sdmmc, "sdmmc-1v8");
> if (IS_ERR(tegra_host->pinctrl_state_1v8)) {
> dev_warn(dev, "Missing 1.8V pad state, err: %ld\n",
> - PTR_ERR(tegra_host->pinctrl_state_3v3));
> + PTR_ERR(tegra_host->pinctrl_state_1v8));
> return -1;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-06 6:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 11:12 [PATCH -next] mmc: tegra: Fix copy-paste error in tegra_sdhci_init_pinctrl_info() Wei Yongjun
2018-09-06 6:31 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.