* [PATCH] mac80211: fix TX status reporting for ieee80211s
@ 2018-08-31 7:12 Yuan-Chi Pang
2018-09-03 8:33 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Yuan-Chi Pang @ 2018-08-31 7:12 UTC (permalink / raw)
To: johannes; +Cc: davem, linux-wireless, netdev, linux-kernel, Yuan-Chi Pang
ieee80211s_update_metric works only if wireless
driver passes tx_status of data frame to mac80211
Make API and caller of ieee80211s_update_metric to be
similar to rate_control_tx_status
Signed-off-by: Yuan-Chi Pang <fu3mo6goo@gmail.com>
---
net/mac80211/mesh.h | 2 +-
net/mac80211/mesh_hwmp.c | 8 ++------
net/mac80211/status.c | 4 +++-
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index ee56f18..3c6095a 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -217,7 +217,7 @@ void mesh_rmc_free(struct ieee80211_sub_if_data *sdata);
int mesh_rmc_init(struct ieee80211_sub_if_data *sdata);
void ieee80211s_init(void);
void ieee80211s_update_metric(struct ieee80211_local *local,
- struct sta_info *sta, struct sk_buff *skb);
+ struct sta_info *sta, struct ieee80211_tx_status *st);
void ieee80211_mesh_init_sdata(struct ieee80211_sub_if_data *sdata);
void ieee80211_mesh_teardown_sdata(struct ieee80211_sub_if_data *sdata);
int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata);
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index daf9db3..4286673 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -295,15 +295,11 @@ int mesh_path_error_tx(struct ieee80211_sub_if_data *sdata,
}
void ieee80211s_update_metric(struct ieee80211_local *local,
- struct sta_info *sta, struct sk_buff *skb)
+ struct sta_info *sta, struct ieee80211_tx_status *st)
{
- struct ieee80211_tx_info *txinfo = IEEE80211_SKB_CB(skb);
- struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
+ struct ieee80211_tx_info *txinfo = st->info;
int failed;
- if (!ieee80211_is_data(hdr->frame_control))
- return;
-
failed = !(txinfo->flags & IEEE80211_TX_STAT_ACK);
/* moving average, scaled to 100.
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index 9a6d720..dfcd419 100644
--- a/net/mac80211/status.c
+++ b/net/mac80211/status.c
@@ -811,7 +811,7 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,
rate_control_tx_status(local, sband, status);
if (ieee80211_vif_is_mesh(&sta->sdata->vif))
- ieee80211s_update_metric(local, sta, skb);
+ ieee80211s_update_metric(local, sta, status);
if (!(info->flags & IEEE80211_TX_CTL_INJECTED) && acked)
ieee80211_frame_acked(sta, skb);
@@ -972,6 +972,8 @@ void ieee80211_tx_status_ext(struct ieee80211_hw *hw,
}
rate_control_tx_status(local, sband, status);
+ if (ieee80211_vif_is_mesh(&sta->sdata->vif))
+ ieee80211s_update_metric(local, sta, status);
}
if (acked || noack_success) {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mac80211: fix TX status reporting for ieee80211s
2018-08-31 7:12 [PATCH] mac80211: fix TX status reporting for ieee80211s Yuan-Chi Pang
@ 2018-09-03 8:33 ` Johannes Berg
2018-09-06 8:57 ` Yuan-Chi Pang
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2018-09-03 8:33 UTC (permalink / raw)
To: Yuan-Chi Pang; +Cc: davem, linux-wireless, netdev, linux-kernel
On Fri, 2018-08-31 at 15:12 +0800, Yuan-Chi Pang wrote:
> void ieee80211s_init(void);
> void ieee80211s_update_metric(struct ieee80211_local *local,
> - struct sta_info *sta, struct sk_buff *skb);
> + struct sta_info *sta, struct ieee80211_tx_status *st);
please keep things indented properly
> void ieee80211s_update_metric(struct ieee80211_local *local,
> - struct sta_info *sta, struct sk_buff *skb)
> + struct sta_info *sta, struct ieee80211_tx_status *st)
and maybe fix the indentation here while you're changing it
> {
> - struct ieee80211_tx_info *txinfo = IEEE80211_SKB_CB(skb);
> - struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
> + struct ieee80211_tx_info *txinfo = st->info;
> int failed;
>
> - if (!ieee80211_is_data(hdr->frame_control))
> - return;
Why are you removing this condition? You didn't say anything about that.
I sort of see why (you no longer even have the skb/hdr), but you should
indicate why this is OK.
> rate_control_tx_status(local, sband, status);
> + if (ieee80211_vif_is_mesh(&sta->sdata->vif))
> + ieee80211s_update_metric(local, sta, status)
This is the only "real" change I guess, some more description about it
would be good.
I can sort of reverse engineer it from your commit log, but you should
be more explicit.
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mac80211: fix TX status reporting for ieee80211s
2018-09-03 8:33 ` Johannes Berg
@ 2018-09-06 8:57 ` Yuan-Chi Pang
2018-09-06 9:45 ` Yuan-Chi Pang
0 siblings, 1 reply; 5+ messages in thread
From: Yuan-Chi Pang @ 2018-09-06 8:57 UTC (permalink / raw)
Cc: fu3mo6goo, Johannes Berg, David S. Miller, linux-wireless,
netdev, linux-kernel
TX status reporting to ieee80211s is through ieee80211s_update_metric.
There are two problems about ieee80211s_update_metric:
1. The purpose is to estimate the fail probability
to a specific link. No need to restrict to data frame.
2. Current implementation does not work if wireless driver does not
pass tx_status with skb.
Fix this by removing ieee80211_is_data condition, passing
ieee80211_tx_status directly to ieee80211s_update_metric, and
putting it in both __ieee80211_tx_status and ieee80211_tx_status_ext.
Signed-off-by: Yuan-Chi Pang <fu3mo6goo@gmail.com>
---
net/mac80211/mesh.h | 2 +-
net/mac80211/mesh_hwmp.c | 8 ++------
net/mac80211/status.c | 4 +++-
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index ee56f18..7ffe56a 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -217,7 +217,7 @@ void mesh_rmc_free(struct ieee80211_sub_if_data *sdata);
int mesh_rmc_init(struct ieee80211_sub_if_data *sdata);
void ieee80211s_init(void);
void ieee80211s_update_metric(struct ieee80211_local *local,
- struct sta_info *sta, struct sk_buff *skb);
+ struct sta_info *sta, struct ieee80211_tx_status *st);
void ieee80211_mesh_init_sdata(struct ieee80211_sub_if_data *sdata);
void ieee80211_mesh_teardown_sdata(struct ieee80211_sub_if_data *sdata);
int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata);
diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
index daf9db3..4286673 100644
--- a/net/mac80211/mesh_hwmp.c
+++ b/net/mac80211/mesh_hwmp.c
@@ -295,15 +295,11 @@ int mesh_path_error_tx(struct ieee80211_sub_if_data *sdata,
}
void ieee80211s_update_metric(struct ieee80211_local *local,
- struct sta_info *sta, struct sk_buff *skb)
+ struct sta_info *sta, struct ieee80211_tx_status *st)
{
- struct ieee80211_tx_info *txinfo = IEEE80211_SKB_CB(skb);
- struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
+ struct ieee80211_tx_info *txinfo = st->info;
int failed;
- if (!ieee80211_is_data(hdr->frame_control))
- return;
-
failed = !(txinfo->flags & IEEE80211_TX_STAT_ACK);
/* moving average, scaled to 100.
diff --git a/net/mac80211/status.c b/net/mac80211/status.c
index 9a6d720..dfcd419 100644
--- a/net/mac80211/status.c
+++ b/net/mac80211/status.c
@@ -811,7 +811,7 @@ static void __ieee80211_tx_status(struct ieee80211_hw *hw,
rate_control_tx_status(local, sband, status);
if (ieee80211_vif_is_mesh(&sta->sdata->vif))
- ieee80211s_update_metric(local, sta, skb);
+ ieee80211s_update_metric(local, sta, status);
if (!(info->flags & IEEE80211_TX_CTL_INJECTED) && acked)
ieee80211_frame_acked(sta, skb);
@@ -972,6 +972,8 @@ void ieee80211_tx_status_ext(struct ieee80211_hw *hw,
}
rate_control_tx_status(local, sband, status);
+ if (ieee80211_vif_is_mesh(&sta->sdata->vif))
+ ieee80211s_update_metric(local, sta, status);
}
if (acked || noack_success) {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mac80211: fix TX status reporting for ieee80211s
2018-09-06 8:57 ` Yuan-Chi Pang
@ 2018-09-06 9:45 ` Yuan-Chi Pang
2018-09-06 9:47 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Yuan-Chi Pang @ 2018-09-06 9:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: David S. Miller, linux-wireless, netdev, linux-kernel
On Thu, 2018-09-06 at 16:57 +0800, Yuan-Chi Pang wrote:
> TX status reporting to ieee80211s is through
> ieee80211s_update_metric.
> There are two problems about ieee80211s_update_metric:
>
> 1. The purpose is to estimate the fail probability
> to a specific link. No need to restrict to data frame.
>
> 2. Current implementation does not work if wireless driver does not
> pass tx_status with skb.
>
> Fix this by removing ieee80211_is_data condition, passing
> ieee80211_tx_status directly to ieee80211s_update_metric, and
> putting it in both __ieee80211_tx_status and ieee80211_tx_status_ext.
>
> Signed-off-by: Yuan-Chi Pang <fu3mo6goo@gmail.com>
> ---
> net/mac80211/mesh.h | 2 +-
> net/mac80211/mesh_hwmp.c | 8 ++------
> net/mac80211/status.c | 4 +++-
> 3 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
> index ee56f18..7ffe56a 100644
> --- a/net/mac80211/mesh.h
> +++ b/net/mac80211/mesh.h
> @@ -217,7 +217,7 @@ void mesh_rmc_free(struct ieee80211_sub_if_data
> *sdata);
> int mesh_rmc_init(struct ieee80211_sub_if_data *sdata);
> void ieee80211s_init(void);
> void ieee80211s_update_metric(struct ieee80211_local *local,
> - struct sta_info *sta, struct sk_buff
> *skb);
> + struct sta_info *sta, struct
> ieee80211_tx_status *st);
> void ieee80211_mesh_init_sdata(struct ieee80211_sub_if_data *sdata);
> void ieee80211_mesh_teardown_sdata(struct ieee80211_sub_if_data
> *sdata);
> int ieee80211_start_mesh(struct ieee80211_sub_if_data *sdata);
I received the comment of my previous submission that I should fix
indentation. But if I use the same indentation as before, I got "line
over 80 characters" warning by checkpatch. What should I do?
> diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> index daf9db3..4286673 100644
> --- a/net/mac80211/mesh_hwmp.c
> +++ b/net/mac80211/mesh_hwmp.c
> @@ -295,15 +295,11 @@ int mesh_path_error_tx(struct
> ieee80211_sub_if_data *sdata,
> }
>
> void ieee80211s_update_metric(struct ieee80211_local *local,
> - struct sta_info *sta, struct sk_buff *skb)
> + struct sta_info *sta, struct ieee80211_tx_status
> *st)
> {
> - struct ieee80211_tx_info *txinfo = IEEE80211_SKB_CB(skb);
> - struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb-
> >data;
> + struct ieee80211_tx_info *txinfo = st->info;
> int failed;
>
> - if (!ieee80211_is_data(hdr->frame_control))
> - return;
> -
> failed = !(txinfo->flags & IEEE80211_TX_STAT_ACK);
>
> /* moving average, scaled to 100.
> diff --git a/net/mac80211/status.c b/net/mac80211/status.c
> index 9a6d720..dfcd419 100644
> --- a/net/mac80211/status.c
> +++ b/net/mac80211/status.c
> @@ -811,7 +811,7 @@ static void __ieee80211_tx_status(struct
> ieee80211_hw *hw,
>
> rate_control_tx_status(local, sband, status);
> if (ieee80211_vif_is_mesh(&sta->sdata->vif))
> - ieee80211s_update_metric(local, sta, skb);
> + ieee80211s_update_metric(local, sta,
> status);
>
> if (!(info->flags & IEEE80211_TX_CTL_INJECTED) &&
> acked)
> ieee80211_frame_acked(sta, skb);
> @@ -972,6 +972,8 @@ void ieee80211_tx_status_ext(struct ieee80211_hw
> *hw,
> }
>
> rate_control_tx_status(local, sband, status);
> + if (ieee80211_vif_is_mesh(&sta->sdata->vif))
> + ieee80211s_update_metric(local, sta,
> status);
> }
>
> if (acked || noack_success) {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mac80211: fix TX status reporting for ieee80211s
2018-09-06 9:45 ` Yuan-Chi Pang
@ 2018-09-06 9:47 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2018-09-06 9:47 UTC (permalink / raw)
To: Yuan-Chi Pang; +Cc: David S. Miller, linux-wireless, netdev, linux-kernel
On Thu, 2018-09-06 at 17:45 +0800, Yuan-Chi Pang wrote:
>
> I received the comment of my previous submission that I should fix
> indentation. But if I use the same indentation as before, I got "line
> over 80 characters" warning by checkpatch. What should I do?
>
> > diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c
> > index daf9db3..4286673 100644
> > --- a/net/mac80211/mesh_hwmp.c
> > +++ b/net/mac80211/mesh_hwmp.c
> > @@ -295,15 +295,11 @@ int mesh_path_error_tx(struct
> > ieee80211_sub_if_data *sdata,
> > }
> >
> > void ieee80211s_update_metric(struct ieee80211_local *local,
> > - struct sta_info *sta, struct sk_buff *skb)
> > + struct sta_info *sta, struct ieee80211_tx_status
> > *st)
Here? Seems easy - add a linebreak between sta and status?
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-06 14:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-31 7:12 [PATCH] mac80211: fix TX status reporting for ieee80211s Yuan-Chi Pang
2018-09-03 8:33 ` Johannes Berg
2018-09-06 8:57 ` Yuan-Chi Pang
2018-09-06 9:45 ` Yuan-Chi Pang
2018-09-06 9:47 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.