* [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native
@ 2018-09-07 17:25 Yevgeny Popovych
2018-09-12 6:57 ` Richard Leitner
2018-09-17 14:20 ` André Draszik
0 siblings, 2 replies; 5+ messages in thread
From: Yevgeny Popovych @ 2018-09-07 17:25 UTC (permalink / raw)
To: openembedded-devel
This will allow other native recipes RDEPEND on virtual/java-native.
Change-Id: I85fcd012d09441867fa5f359463cbe8fff702fbe
Signed-off-by: Yevgeny Popovych <yevgenyp@pointgrab.com>
---
recipes-core/cacao/cacao_1.6.1.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-core/cacao/cacao_1.6.1.bb b/recipes-core/cacao/cacao_1.6.1.bb
index 1074ff5..ead0e2f 100644
--- a/recipes-core/cacao/cacao_1.6.1.bb
+++ b/recipes-core/cacao/cacao_1.6.1.bb
@@ -6,6 +6,7 @@ SECTION = "interpreters"
DEPENDS_class-native = "zlib-native libtool-native ecj-initial-native fastjar-native classpath-initial-native classpath-native bdwgc-native virtual/java-initial-native"
PROVIDES_class-native = "virtual/java-native"
+RPROVIDES_${PN}_class-native = "virtual/java-native"
DEPENDS = "zlib libtool classpath virtual/javac-native bdwgc"
RPROVIDES_${PN} = "java2-runtime"
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native
2018-09-07 17:25 [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native Yevgeny Popovych
@ 2018-09-12 6:57 ` Richard Leitner
2018-09-17 14:20 ` André Draszik
1 sibling, 0 replies; 5+ messages in thread
From: Richard Leitner @ 2018-09-12 6:57 UTC (permalink / raw)
To: openembedded-devel, Richard Leitner
Hi,
this is a note to let you know that I've just added this patch to the
master-next branch of the meta-java repository at
git://git.yoctoproject.org/meta-java
As soon as it has gone through some more testing it will likely be
merged to the master branch.
If you have any questions, please let me know.
regards;Richard.L
On 9/7/18 7:25 PM, Yevgeny Popovych wrote:
> This will allow other native recipes RDEPEND on virtual/java-native.
>
> Signed-off-by: Yevgeny Popovych <yevgenyp@pointgrab.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native
2018-09-07 17:25 [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native Yevgeny Popovych
2018-09-12 6:57 ` Richard Leitner
@ 2018-09-17 14:20 ` André Draszik
2018-09-18 15:19 ` Richard Leitner
1 sibling, 1 reply; 5+ messages in thread
From: André Draszik @ 2018-09-17 14:20 UTC (permalink / raw)
To: openembedded-devel
On Fri, 2018-09-07 at 20:25 +0300, Yevgeny Popovych wrote:
> This will allow other native recipes RDEPEND on virtual/java-native.
I don't understand, can you please explain why a target package would ever
want to runtime depend on a native package?
How did you test this?
Also, the virtual/ namespace is usually used in PROVIDES, not in RPROVIDES.
Cheers,
Andre'
>
> Change-Id: I85fcd012d09441867fa5f359463cbe8fff702fbe
> Signed-off-by: Yevgeny Popovych <yevgenyp@pointgrab.com>
> ---
> recipes-core/cacao/cacao_1.6.1.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-core/cacao/cacao_1.6.1.bb b/recipes-
> core/cacao/cacao_1.6.1.bb
> index 1074ff5..ead0e2f 100644
> --- a/recipes-core/cacao/cacao_1.6.1.bb
> +++ b/recipes-core/cacao/cacao_1.6.1.bb
> @@ -6,6 +6,7 @@ SECTION = "interpreters"
>
> DEPENDS_class-native = "zlib-native libtool-native ecj-initial-native
> fastjar-native classpath-initial-native classpath-native bdwgc-native
> virtual/java-initial-native"
> PROVIDES_class-native = "virtual/java-native"
> +RPROVIDES_${PN}_class-native = "virtual/java-native"
>
> DEPENDS = "zlib libtool classpath virtual/javac-native bdwgc"
> RPROVIDES_${PN} = "java2-runtime"
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native
2018-09-17 14:20 ` André Draszik
@ 2018-09-18 15:19 ` Richard Leitner
2018-09-19 10:34 ` Yevgeny Popovych
0 siblings, 1 reply; 5+ messages in thread
From: Richard Leitner @ 2018-09-18 15:19 UTC (permalink / raw)
To: openembedded-devel
Hi Andé,
thanks for reviewing this patch!
On 9/17/18 4:20 PM, André Draszik wrote:
> On Fri, 2018-09-07 at 20:25 +0300, Yevgeny Popovych wrote:
>> This will allow other native recipes RDEPEND on virtual/java-native.
>
> I don't understand, can you please explain why a target package would ever
> want to runtime depend on a native package?
I've totally overlooked that... You're right, it makes no sense in any
situation I can imagine...
Therefore I'll remove that patch from master-next soon.
regards;Richard.L
>
> How did you test this?
>
> Also, the virtual/ namespace is usually used in PROVIDES, not in RPROVIDES.
>
>
> Cheers,
> Andre'
>
>>
>> Change-Id: I85fcd012d09441867fa5f359463cbe8fff702fbe
>> Signed-off-by: Yevgeny Popovych <yevgenyp@pointgrab.com>
>> ---
>> recipes-core/cacao/cacao_1.6.1.bb | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/recipes-core/cacao/cacao_1.6.1.bb b/recipes-
>> core/cacao/cacao_1.6.1.bb
>> index 1074ff5..ead0e2f 100644
>> --- a/recipes-core/cacao/cacao_1.6.1.bb
>> +++ b/recipes-core/cacao/cacao_1.6.1.bb
>> @@ -6,6 +6,7 @@ SECTION = "interpreters"
>>
>> DEPENDS_class-native = "zlib-native libtool-native ecj-initial-native
>> fastjar-native classpath-initial-native classpath-native bdwgc-native
>> virtual/java-initial-native"
>> PROVIDES_class-native = "virtual/java-native"
>> +RPROVIDES_${PN}_class-native = "virtual/java-native"
>>
>> DEPENDS = "zlib libtool classpath virtual/javac-native bdwgc"
>> RPROVIDES_${PN} = "java2-runtime"
>> --
>> 2.7.4
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native
2018-09-18 15:19 ` Richard Leitner
@ 2018-09-19 10:34 ` Yevgeny Popovych
0 siblings, 0 replies; 5+ messages in thread
From: Yevgeny Popovych @ 2018-09-19 10:34 UTC (permalink / raw)
To: Richard Leitner, openembedded-devel
On 09/18/2018 06:19 PM, Richard Leitner wrote:
> Hi Andé,
> thanks for reviewing this patch!
>
> On 9/17/18 4:20 PM, André Draszik wrote:
>> On Fri, 2018-09-07 at 20:25 +0300, Yevgeny Popovych wrote:
>>> This will allow other native recipes RDEPEND on virtual/java-native.
>>
>> I don't understand, can you please explain why a target package would ever
>> want to runtime depend on a native package?
There is no _target_ package in question, it is all about native stuff.
Patch is about cacao-native providing runtime dependency under "virtual/java-native" name.
This, for example, will satisfy ca-certificates-java-native dependency
(line "RDEPENDS_${PN}_append_class-native = " virtual/java-native"").
Otherwise, there is no recipe that is able to satisfy the aforementioned dependency
of ca-certificates-java-native.
>
> I've totally overlooked that... You're right, it makes no sense in any
> situation I can imagine...
>
> Therefore I'll remove that patch from master-next soon.
Richard, it would be great if we could agree on a solution first..
>
> regards;Richard.L
>
>>
>> How did you test this?
By having a recipe that DEPENDS on ca-certificates-java-native.
This recipe would be able to use 'java' then.
The truth is that I also pull in openjdk-8-native to actually run the hook,
so this is more about being able to satisfy formal dependency of ca-certificates recipe.
>>
>> Also, the virtual/ namespace is usually used in PROVIDES, not in RPROVIDES.
>>
>>
>> Cheers,
>> Andre'
>>
>>>
>>> Change-Id: I85fcd012d09441867fa5f359463cbe8fff702fbe
>>> Signed-off-by: Yevgeny Popovych <yevgenyp@pointgrab.com>
>>> ---
>>> recipes-core/cacao/cacao_1.6.1.bb | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/recipes-core/cacao/cacao_1.6.1.bb b/recipes-
>>> core/cacao/cacao_1.6.1.bb
>>> index 1074ff5..ead0e2f 100644
>>> --- a/recipes-core/cacao/cacao_1.6.1.bb
>>> +++ b/recipes-core/cacao/cacao_1.6.1.bb
>>> @@ -6,6 +6,7 @@ SECTION = "interpreters"
>>>
>>> DEPENDS_class-native = "zlib-native libtool-native ecj-initial-native
>>> fastjar-native classpath-initial-native classpath-native bdwgc-native
>>> virtual/java-initial-native"
>>> PROVIDES_class-native = "virtual/java-native"
>>> +RPROVIDES_${PN}_class-native = "virtual/java-native"
>>>
>>> DEPENDS = "zlib libtool classpath virtual/javac-native bdwgc"
>>> RPROVIDES_${PN} = "java2-runtime"
>>> --
>>> 2.7.4
>>>
>>
--
Sincerely,
Yevgeny Popovych
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-19 10:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 17:25 [meta-java][PATCH] cacao: class-native: RPROVIDE virtual/java-native Yevgeny Popovych
2018-09-12 6:57 ` Richard Leitner
2018-09-17 14:20 ` André Draszik
2018-09-18 15:19 ` Richard Leitner
2018-09-19 10:34 ` Yevgeny Popovych
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.