* Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
[not found] <1536667978-10556-1-git-send-email-yuehaibing@huawei.com>
@ 2018-09-12 5:48 ` Pkshih
2019-01-29 5:57 ` YueHaibing
1 sibling, 0 replies; 6+ messages in thread
From: Pkshih @ 2018-09-12 5:48 UTC (permalink / raw)
To: yuehaibing, kvalo; +Cc: linux-wireless, netdev
T24gVHVlLCAyMDE4LTA5LTExIGF0IDEyOjEyICswMDAwLCBZdWVIYWliaW5nIHdyb3RlOg0KPiBG
aXhlcyBnY2MgJy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUnIHdhcm5pbmc6DQo+IA0KPiBkcml2
ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYmFzZS5jOiBJbiBmdW5jdGlvbg0KPiAn
cnRsX2MyaF9jb250ZW50X3BhcnNpbmcnOg0KPiBkcml2ZXJzL25ldC93aXJlbGVzcy9yZWFsdGVr
L3J0bHdpZmkvYmFzZS5jOjIzMTM6MTM6IHdhcm5pbmc6DQo+IMKgdmFyaWFibGUgJ2NtZF9zZXEn
IHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdDQo+IA0KPiBTaWdu
ZWQtb2ZmLWJ5OiBZdWVIYWliaW5nIDx5dWVoYWliaW5nQGh1YXdlaS5jb20+DQoNCkFja2VkLWJ5
OiBQaW5nLUtlIFNoaWggPHBrc2hpaEByZWFsdGVrLmNvbT4NCg0KVGhhbmtzDQo=
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
[not found] <1536667978-10556-1-git-send-email-yuehaibing@huawei.com>
2018-09-12 5:48 ` [PATCH] rtlwifi: remove set but not used variable 'cmd_seq' Pkshih
@ 2019-01-29 5:57 ` YueHaibing
2019-01-29 6:03 ` YueHaibing
1 sibling, 1 reply; 6+ messages in thread
From: YueHaibing @ 2019-01-29 5:57 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo
Cc: linux-wireless, netdev@vger.kernel.org kernel-janitors
ping...
On 2018/9/11 20:12, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/realtek/rtlwifi/base.c: In function 'rtl_c2h_content_parsing':
> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
> variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index f4122c8..92b6918 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct ieee80211_hw *hw,
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
> const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
> - u8 cmd_id, cmd_seq, cmd_len;
> + u8 cmd_id, cmd_len;
> u8 *cmd_buf = NULL;
>
> cmd_id = GET_C2H_CMD_ID(skb->data);
> - cmd_seq = GET_C2H_SEQ(skb->data);
> cmd_len = skb->len - C2H_DATA_OFFSET;
> cmd_buf = GET_C2H_DATA_PTR(skb->data);
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
2019-01-29 5:57 ` YueHaibing
@ 2019-01-29 6:03 ` YueHaibing
2019-01-30 1:31 ` Pkshih
0 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2019-01-29 6:03 UTC (permalink / raw)
To: Ping-Ke Shih, Kalle Valo; +Cc: linux-wireless, netdev
+cc netdev@vger.kernel.org
On 2019/1/29 13:57, YueHaibing wrote:
> ping...
>
> On 2018/9/11 20:12, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/wireless/realtek/rtlwifi/base.c: In function 'rtl_c2h_content_parsing':
>> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>> variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
>> index f4122c8..92b6918 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
>> @@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct ieee80211_hw *hw,
>> struct rtl_priv *rtlpriv = rtl_priv(hw);
>> struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
>> const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
>> - u8 cmd_id, cmd_seq, cmd_len;
>> + u8 cmd_id, cmd_len;
>> u8 *cmd_buf = NULL;
>>
>> cmd_id = GET_C2H_CMD_ID(skb->data);
>> - cmd_seq = GET_C2H_SEQ(skb->data);
>> cmd_len = skb->len - C2H_DATA_OFFSET;
>> cmd_buf = GET_C2H_DATA_PTR(skb->data);
>>
>>
>> .
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
2019-01-29 6:03 ` YueHaibing
@ 2019-01-30 1:31 ` Pkshih
2019-01-30 10:47 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Pkshih @ 2019-01-30 1:31 UTC (permalink / raw)
To: yuehaibing, kvalo; +Cc: linux-wireless, netdev
On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
> +cc netdev@vger.kernel.org
>
> On 2019/1/29 13:57, YueHaibing wrote:
> > ping...
> >
> > On 2018/9/11 20:12, YueHaibing wrote:
> >> Fixes gcc '-Wunused-but-set-variable' warning:
> >>
> >> drivers/net/wireless/realtek/rtlwifi/base.c: In function
> 'rtl_c2h_content_parsing':
> >> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
> >> variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for your fix.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> >> ---
> >> drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
> b/drivers/net/wireless/realtek/rtlwifi/base.c
> >> index f4122c8..92b6918 100644
> >> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> >> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> >> @@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct
> ieee80211_hw *hw,
> >> struct rtl_priv *rtlpriv = rtl_priv(hw);
> >> struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
> >> const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
> >> - u8 cmd_id, cmd_seq, cmd_len;
> >> + u8 cmd_id, cmd_len;
> >> u8 *cmd_buf = NULL;
> >>
> >> cmd_id = GET_C2H_CMD_ID(skb->data);
> >> - cmd_seq = GET_C2H_SEQ(skb->data);
> >> cmd_len = skb->len - C2H_DATA_OFFSET;
> >> cmd_buf = GET_C2H_DATA_PTR(skb->data);
> >>
> >>
> >> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
2019-01-30 1:31 ` Pkshih
@ 2019-01-30 10:47 ` Kalle Valo
2019-01-31 1:53 ` YueHaibing
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2019-01-30 10:47 UTC (permalink / raw)
To: Pkshih; +Cc: yuehaibing, linux-wireless, netdev
Pkshih <pkshih@realtek.com> writes:
> On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
>> +cc netdev@vger.kernel.org
>>
>> On 2019/1/29 13:57, YueHaibing wrote:
>> > ping...
>> >
>> > On 2018/9/11 20:12, YueHaibing wrote:
>> >> Fixes gcc '-Wunused-but-set-variable' warning:
>> >>
>> >> drivers/net/wireless/realtek/rtlwifi/base.c: In function
>> 'rtl_c2h_content_parsing':
>> >> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>> >> variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>> >>
>> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Thanks for your fix.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
For some reason I couldn't find the original patch from patchwork.
I didn't find the version sent today though:
https://patchwork.kernel.org/patch/10787619/
BTW YueHaibing, you can check the linux-wireless patch status yourself from
the patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
2019-01-30 10:47 ` Kalle Valo
@ 2019-01-31 1:53 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-01-31 1:53 UTC (permalink / raw)
To: Kalle Valo, Pkshih; +Cc: linux-wireless, netdev
On 2019/1/30 18:47, Kalle Valo wrote:
> Pkshih <pkshih@realtek.com> writes:
>
>> On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
>>> +cc netdev@vger.kernel.org
>>>
>>> On 2019/1/29 13:57, YueHaibing wrote:
>>>> ping...
>>>>
>>>> On 2018/9/11 20:12, YueHaibing wrote:
>>>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>>>
>>>>> drivers/net/wireless/realtek/rtlwifi/base.c: In function
>>> 'rtl_c2h_content_parsing':
>>>>> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>>>>> variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>>>>>
>>>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Thanks for your fix.
>>
>> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> For some reason I couldn't find the original patch from patchwork.
> I didn't find the version sent today though:
>
> https://patchwork.kernel.org/patch/10787619/
>
> BTW YueHaibing, you can check the linux-wireless patch status yourself from
> the patchwork:
Thanks, I'll check it.
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-31 1:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1536667978-10556-1-git-send-email-yuehaibing@huawei.com>
2018-09-12 5:48 ` [PATCH] rtlwifi: remove set but not used variable 'cmd_seq' Pkshih
2019-01-29 5:57 ` YueHaibing
2019-01-29 6:03 ` YueHaibing
2019-01-30 1:31 ` Pkshih
2019-01-30 10:47 ` Kalle Valo
2019-01-31 1:53 ` YueHaibing
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.