* [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected.
@ 2018-09-21 13:22 ` Sandeep Singh
0 siblings, 0 replies; 6+ messages in thread
From: Sandeep Singh @ 2018-09-21 13:22 UTC (permalink / raw)
To: linux-kernel, linux-usb, gregkh, mathias.nyman
Cc: Sandeep Singh, Nehal Shah, Shyam Sundar S K
From: Sandeep Singh <sandeep.singh@amd.com>
Observed "TRB completion code (27)" error which corresponds to Stopped -
Length Invalid error(xhci spec section 4.17.4) while connecting USB to
SATA bridge.
Looks like this case was not considered when the following patch[1] was
committed. Hence adding this new check which can prevent
the invalid byte size error.
[1] ade2e3a xhci: handle transfer events without TRB pointer
Signed-off-by: Sandeep Singh <sandeep.singh@amd.com>
cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
drivers/usb/host/xhci-ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index f0a99aa..8ba2cbc 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -2246,6 +2246,7 @@ static int handle_tx_event(struct xhci_hcd *xhci,
goto cleanup;
case COMP_RING_UNDERRUN:
case COMP_RING_OVERRUN:
+ case COMP_STOPPED_LENGTH_INVALID:
goto cleanup;
default:
xhci_err(xhci, "ERROR Transfer event for unknown stream ring slot %u ep %u\n",
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* xhci: Add check for invalid byte size error when UAS devices are connected.
@ 2018-09-21 13:22 ` Sandeep Singh
0 siblings, 0 replies; 6+ messages in thread
From: Sandeep Singh @ 2018-09-21 13:22 UTC (permalink / raw)
To: linux-kernel, linux-usb, gregkh, mathias.nyman
Cc: Sandeep Singh, Nehal Shah, Shyam Sundar S K
From: Sandeep Singh <sandeep.singh@amd.com>
Observed "TRB completion code (27)" error which corresponds to Stopped -
Length Invalid error(xhci spec section 4.17.4) while connecting USB to
SATA bridge.
Looks like this case was not considered when the following patch[1] was
committed. Hence adding this new check which can prevent
the invalid byte size error.
[1] ade2e3a xhci: handle transfer events without TRB pointer
Signed-off-by: Sandeep Singh <sandeep.singh@amd.com>
cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
---
drivers/usb/host/xhci-ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index f0a99aa..8ba2cbc 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -2246,6 +2246,7 @@ static int handle_tx_event(struct xhci_hcd *xhci,
goto cleanup;
case COMP_RING_UNDERRUN:
case COMP_RING_OVERRUN:
+ case COMP_STOPPED_LENGTH_INVALID:
goto cleanup;
default:
xhci_err(xhci, "ERROR Transfer event for unknown stream ring slot %u ep %u\n",
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected.
@ 2018-09-24 13:09 ` Mathias Nyman
0 siblings, 0 replies; 6+ messages in thread
From: Mathias Nyman @ 2018-09-24 13:09 UTC (permalink / raw)
To: Sandeep Singh, linux-kernel, linux-usb, gregkh, mathias.nyman
Cc: Nehal Shah, Shyam Sundar S K
On 21.09.2018 16:22, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@amd.com>
>
> Observed "TRB completion code (27)" error which corresponds to Stopped -
> Length Invalid error(xhci spec section 4.17.4) while connecting USB to
> SATA bridge.
>
> Looks like this case was not considered when the following patch[1] was
> committed. Hence adding this new check which can prevent
> the invalid byte size error.
>
> [1] ade2e3a xhci: handle transfer events without TRB pointer
>
Thanks, adding to queue.
Just out of curiosity, was the TRB pointer bits all zeroes
in this Stopped -Length invalid transfer event TRB?
-Mathias
^ permalink raw reply [flat|nested] 6+ messages in thread
* xhci: Add check for invalid byte size error when UAS devices are connected.
@ 2018-09-24 13:09 ` Mathias Nyman
0 siblings, 0 replies; 6+ messages in thread
From: Mathias Nyman @ 2018-09-24 13:09 UTC (permalink / raw)
To: Sandeep Singh, linux-kernel, linux-usb, gregkh, mathias.nyman
Cc: Nehal Shah, Shyam Sundar S K
On 21.09.2018 16:22, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@amd.com>
>
> Observed "TRB completion code (27)" error which corresponds to Stopped -
> Length Invalid error(xhci spec section 4.17.4) while connecting USB to
> SATA bridge.
>
> Looks like this case was not considered when the following patch[1] was
> committed. Hence adding this new check which can prevent
> the invalid byte size error.
>
> [1] ade2e3a xhci: handle transfer events without TRB pointer
>
Thanks, adding to queue.
Just out of curiosity, was the TRB pointer bits all zeroes
in this Stopped -Length invalid transfer event TRB?
-Mathias
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected.
@ 2018-09-25 9:14 ` Sandeep Singh
0 siblings, 0 replies; 6+ messages in thread
From: Sandeep Singh @ 2018-09-25 9:14 UTC (permalink / raw)
To: Mathias Nyman, Sandeep Singh, linux-kernel, linux-usb, gregkh,
mathias.nyman
Cc: Nehal Shah, Shyam Sundar S K
On 9/24/2018 6:39 PM, Mathias Nyman wrote:
> On 21.09.2018 16:22, Sandeep Singh wrote:
>> From: Sandeep Singh <sandeep.singh@amd.com>
>>
>> Observed "TRB completion code (27)" error which corresponds to Stopped -
>> Length Invalid error(xhci spec section 4.17.4) while connecting USB to
>> SATA bridge.
>>
>> Looks like this case was not considered when the following patch[1] was
>> committed. Hence adding this new check which can prevent
>> the invalid byte size error.
>>
>> [1] ade2e3a xhci: handle transfer events without TRB pointer
>>
>
> Thanks, adding to queue.
>
> Just out of curiosity, was the TRB pointer bits all zeroes
> in this Stopped -Length invalid transfer event TRB?
>
Yes, TRB pointer bits all zeroes
> -Mathias
>
Thanks
Sandeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* xhci: Add check for invalid byte size error when UAS devices are connected.
@ 2018-09-25 9:14 ` Sandeep Singh
0 siblings, 0 replies; 6+ messages in thread
From: Sandeep Singh @ 2018-09-25 9:14 UTC (permalink / raw)
To: Mathias Nyman, Sandeep Singh, linux-kernel, linux-usb, gregkh,
mathias.nyman
Cc: Nehal Shah, Shyam Sundar S K
On 9/24/2018 6:39 PM, Mathias Nyman wrote:
> On 21.09.2018 16:22, Sandeep Singh wrote:
>> From: Sandeep Singh <sandeep.singh@amd.com>
>>
>> Observed "TRB completion code (27)" error which corresponds to Stopped -
>> Length Invalid error(xhci spec section 4.17.4) while connecting USB to
>> SATA bridge.
>>
>> Looks like this case was not considered when the following patch[1] was
>> committed. Hence adding this new check which can prevent
>> the invalid byte size error.
>>
>> [1] ade2e3a xhci: handle transfer events without TRB pointer
>>
>
> Thanks, adding to queue.
>
> Just out of curiosity, was the TRB pointer bits all zeroes
> in this Stopped -Length invalid transfer event TRB?
>
Yes, TRB pointer bits all zeroes
> -Mathias
>
Thanks
Sandeep
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-25 9:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21 13:22 [PATCH] xhci: Add check for invalid byte size error when UAS devices are connected Sandeep Singh
2018-09-21 13:22 ` Sandeep Singh
2018-09-24 13:09 ` [PATCH] " Mathias Nyman
2018-09-24 13:09 ` Mathias Nyman
2018-09-25 9:14 ` [PATCH] " Sandeep Singh
2018-09-25 9:14 ` Sandeep Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.