[PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

[PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

[Kent Russell]

From: Shaoyun Liu <Shaoyun.Liu@amd.com>

Firmware have the workaround to replace the atomic Ops with read-modify-write on CP side.
User should not expect atomic Ops on system memory works normally if system didn't not
support it.

Change-Id: I89395b099fe0931b9b3627651b512dde3149fadd
Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com>
Signed-off-by: Kent Russell <kent.russell@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index b0c2afb..b505bf3 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -263,7 +263,7 @@ static const struct kfd_device_info vega20_device_info = {
 	.mqd_size_aligned = MQD_SIZE_ALIGNED,
 	.supports_cwsr = true,
 	.needs_iommu_device = false,
-	.needs_pci_atomics = true,
+	.needs_pci_atomics = false,
 	.num_sdma_engines = 2,
 	.num_sdma_queues_per_engine = 8,
 };
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 1818 bytes --]

Acked-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Kent Russell <kent.russell-5C7GfCeVMHo@public.gmane.org>
Sent: Wednesday, September 26, 2018 9:41:52 AM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Russell, Kent; Liu, Shaoyun
Subject: [PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

From: Shaoyun Liu <Shaoyun.Liu-5C7GfCeVMHo@public.gmane.org>

Firmware have the workaround to replace the atomic Ops with read-modify-write on CP side.
User should not expect atomic Ops on system memory works normally if system didn't not
support it.

Change-Id: I89395b099fe0931b9b3627651b512dde3149fadd
Signed-off-by: Shaoyun Liu <Shaoyun.Liu-5C7GfCeVMHo@public.gmane.org>
Signed-off-by: Kent Russell <kent.russell-5C7GfCeVMHo@public.gmane.org>
---
 drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
index b0c2afb..b505bf3 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
@@ -263,7 +263,7 @@ static const struct kfd_device_info vega20_device_info = {
         .mqd_size_aligned = MQD_SIZE_ALIGNED,
         .supports_cwsr = true,
         .needs_iommu_device = false,
-       .needs_pci_atomics = true,
+       .needs_pci_atomics = false,
         .num_sdma_engines = 2,
         .num_sdma_queues_per_engine = 8,
 };
--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 3086 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20

[Felix Kuehling]

On 2018-09-26 09:41 AM, Kent Russell wrote:
> From: Shaoyun Liu <Shaoyun.Liu@amd.com>
>
> Firmware have the workaround to replace the atomic Ops with read-modify-write on CP side.
> User should not expect atomic Ops on system memory works normally if system didn't not
> support it.
>
> Change-Id: I89395b099fe0931b9b3627651b512dde3149fadd
> Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com>
> Signed-off-by: Kent Russell <kent.russell@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> index b0c2afb..b505bf3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c
> @@ -263,7 +263,7 @@ static const struct kfd_device_info vega20_device_info = {
>  	.mqd_size_aligned = MQD_SIZE_ALIGNED,
>  	.supports_cwsr = true,
>  	.needs_iommu_device = false,
> -	.needs_pci_atomics = true,
> +	.needs_pci_atomics = false,
>  	.num_sdma_engines = 2,
>  	.num_sdma_queues_per_engine = 8,
>  };

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx