* [PATCH net-next] net: sched: make function qdisc_free_cb() static
@ 2018-09-27 14:47 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2018-09-27 14:47 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Vlad Buslov
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
net/sched/sch_generic.c:944:6: warning:
symbol 'qdisc_free_cb' was not declared. Should it be static?
Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/sched/sch_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 531fac1..3023929 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -941,7 +941,7 @@ void qdisc_free(struct Qdisc *qdisc)
kfree((char *) qdisc - qdisc->padded);
}
-void qdisc_free_cb(struct rcu_head *head)
+static void qdisc_free_cb(struct rcu_head *head)
{
struct Qdisc *q = container_of(head, struct Qdisc, rcu);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next] net: sched: make function qdisc_free_cb() static
@ 2018-09-27 14:47 ` Wei Yongjun
0 siblings, 0 replies; 4+ messages in thread
From: Wei Yongjun @ 2018-09-27 14:47 UTC (permalink / raw)
To: Jamal Hadi Salim, Cong Wang, Jiri Pirko, Vlad Buslov
Cc: Wei Yongjun, netdev, kernel-janitors
Fixes the following sparse warning:
net/sched/sch_generic.c:944:6: warning:
symbol 'qdisc_free_cb' was not declared. Should it be static?
Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/sched/sch_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 531fac1..3023929 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -941,7 +941,7 @@ void qdisc_free(struct Qdisc *qdisc)
kfree((char *) qdisc - qdisc->padded);
}
-void qdisc_free_cb(struct rcu_head *head)
+static void qdisc_free_cb(struct rcu_head *head)
{
struct Qdisc *q = container_of(head, struct Qdisc, rcu);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: sched: make function qdisc_free_cb() static
2018-09-27 14:47 ` Wei Yongjun
@ 2018-09-28 18:06 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-09-28 18:06 UTC (permalink / raw)
To: weiyongjun1; +Cc: jhs, xiyou.wangcong, jiri, vladbu, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Thu, 27 Sep 2018 14:47:56 +0000
> Fixes the following sparse warning:
>
> net/sched/sch_generic.c:944:6: warning:
> symbol 'qdisc_free_cb' was not declared. Should it be static?
>
> Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: sched: make function qdisc_free_cb() static
@ 2018-09-28 18:06 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-09-28 18:06 UTC (permalink / raw)
To: weiyongjun1; +Cc: jhs, xiyou.wangcong, jiri, vladbu, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Thu, 27 Sep 2018 14:47:56 +0000
> Fixes the following sparse warning:
>
> net/sched/sch_generic.c:944:6: warning:
> symbol 'qdisc_free_cb' was not declared. Should it be static?
>
> Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-29 0:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 14:47 [PATCH net-next] net: sched: make function qdisc_free_cb() static Wei Yongjun
2018-09-27 14:47 ` Wei Yongjun
2018-09-28 18:06 ` David Miller
2018-09-28 18:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.