* [PATCH] drm/ast: change resolution may cause screen blurred
@ 2018-10-01 5:26 Y.C. Chen
2018-10-01 8:22 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Y.C. Chen @ 2018-10-01 5:26 UTC (permalink / raw)
To: dri-devel; +Cc: airlied, eich
From: "Y.C. Chen" <yc_chen@aspeedtech.com>
The value of pitches is not correct while calling mode_set.
The issue we found so far on following system:
- Debian8 with XFCE Desktop
- Ubuntu with KDE Desktop
- SUSE15 with KDE Desktop
Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
---
drivers/gpu/drm/ast/ast_mode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 5e77d45..f06aae7 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -568,6 +568,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc,
}
ast_bo_unreserve(bo);
+ ast_set_offset_reg(crtc);
ast_set_start_address_crt1(crtc, (u32)gpu_addr);
return 0;
--
1.8.3.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ast: change resolution may cause screen blurred
2018-10-01 5:26 [PATCH] drm/ast: change resolution may cause screen blurred Y.C. Chen
@ 2018-10-01 8:22 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2018-10-01 8:22 UTC (permalink / raw)
To: Y.C. Chen; +Cc: airlied, dri-devel, eich
On Mon, Oct 01, 2018 at 01:26:04PM +0800, Y.C. Chen wrote:
> From: "Y.C. Chen" <yc_chen@aspeedtech.com>
>
> The value of pitches is not correct while calling mode_set.
> The issue we found so far on following system:
> - Debian8 with XFCE Desktop
> - Ubuntu with KDE Desktop
> - SUSE15 with KDE Desktop
>
> Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
I guess this wants a Cc: stable@vger.kernel.org too?
Cheers, Daniel
> ---
> drivers/gpu/drm/ast/ast_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 5e77d45..f06aae7 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -568,6 +568,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc,
> }
> ast_bo_unreserve(bo);
>
> + ast_set_offset_reg(crtc);
> ast_set_start_address_crt1(crtc, (u32)gpu_addr);
>
> return 0;
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ast: change resolution may cause screen blurred
2018-10-03 6:57 Y.C. Chen
2018-10-03 9:22 ` Daniel Vetter
@ 2018-11-21 14:49 ` Jean Delvare
1 sibling, 0 replies; 5+ messages in thread
From: Jean Delvare @ 2018-11-21 14:49 UTC (permalink / raw)
To: Y.C. Chen; +Cc: dri-devel, airlied, stable, eich
On Wed, 3 Oct 2018 14:57:47 +0800, Y.C. Chen wrote:
> From: "Y.C. Chen" <yc_chen@aspeedtech.com>
>
> The value of pitches is not correct while calling mode_set.
> The issue we found so far on following system:
> - Debian8 with XFCE Desktop
> - Ubuntu with KDE Desktop
> - SUSE15 with KDE Desktop
>
> Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
> ---
> drivers/gpu/drm/ast/ast_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 5e77d45..f06aae7 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -568,6 +568,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc,
> }
> ast_bo_unreserve(bo);
>
> + ast_set_offset_reg(crtc);
> ast_set_start_address_crt1(crtc, (u32)gpu_addr);
>
> return 0;
Tested-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
I did experience the mentioned display corruption on resolution change
on an ASPEED 1100/2050 chipset, under Plasma (KDE). I can confirm that
the patch above prevents it.
There is also a report in openSUSE's bugzilla:
https://bugzilla.opensuse.org/show_bug.cgi?id=1112963
where the user tested the patch above successfully on an ASPEED 2500
chipset.
Can we get the fix merged now?
Thanks,
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/ast: change resolution may cause screen blurred
2018-10-03 6:57 Y.C. Chen
@ 2018-10-03 9:22 ` Daniel Vetter
2018-11-21 14:49 ` Jean Delvare
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2018-10-03 9:22 UTC (permalink / raw)
To: Y.C. Chen; +Cc: dri-devel, airlied, eich, yc_chen, stable, daniel
On Wed, Oct 03, 2018 at 02:57:47PM +0800, Y.C. Chen wrote:
> From: "Y.C. Chen" <yc_chen@aspeedtech.com>
>
> The value of pitches is not correct while calling mode_set.
> The issue we found so far on following system:
> - Debian8 with XFCE Desktop
> - Ubuntu with KDE Desktop
> - SUSE15 with KDE Desktop
>
> Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
btw do you want commit rights for drm-misc for these ast patches?
https://drm.pages.freedesktop.org/maintainer-tools/drm-misc.html
Cheers, Daniel
> ---
> drivers/gpu/drm/ast/ast_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index 5e77d45..f06aae7 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -568,6 +568,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc,
> }
> ast_bo_unreserve(bo);
>
> + ast_set_offset_reg(crtc);
> ast_set_start_address_crt1(crtc, (u32)gpu_addr);
>
> return 0;
> --
> 1.8.3.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/ast: change resolution may cause screen blurred
@ 2018-10-03 6:57 Y.C. Chen
2018-10-03 9:22 ` Daniel Vetter
2018-11-21 14:49 ` Jean Delvare
0 siblings, 2 replies; 5+ messages in thread
From: Y.C. Chen @ 2018-10-03 6:57 UTC (permalink / raw)
To: dri-devel; +Cc: airlied, eich, yc_chen, stable, daniel
From: "Y.C. Chen" <yc_chen@aspeedtech.com>
The value of pitches is not correct while calling mode_set.
The issue we found so far on following system:
- Debian8 with XFCE Desktop
- Ubuntu with KDE Desktop
- SUSE15 with KDE Desktop
Signed-off-by: Y.C. Chen <yc_chen@aspeedtech.com>
---
drivers/gpu/drm/ast/ast_mode.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
index 5e77d45..f06aae7 100644
--- a/drivers/gpu/drm/ast/ast_mode.c
+++ b/drivers/gpu/drm/ast/ast_mode.c
@@ -568,6 +568,7 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc,
}
ast_bo_unreserve(bo);
+ ast_set_offset_reg(crtc);
ast_set_start_address_crt1(crtc, (u32)gpu_addr);
return 0;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-22 1:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 5:26 [PATCH] drm/ast: change resolution may cause screen blurred Y.C. Chen
2018-10-01 8:22 ` Daniel Vetter
2018-10-03 6:57 Y.C. Chen
2018-10-03 9:22 ` Daniel Vetter
2018-11-21 14:49 ` Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.